https://pantsbuild.org/ logo
Powered by
#general
  • r

    rough-minister-58256

    07/08/2015, 6:18 PM
    anyone have any ideas as to if/why this fork() is necessary in the NailgunExecutor? https://github.com/pantsbuild/pants/blob/master/src/python/pants/java/nailgun_executor.py#L302 - seems to me that the parent process is just blocking on the nailgun server to be ready anyway and the child is doing nothing more than launching a subprocess & exiting. thinking this can all be inlined in the function.
  • r

    rough-minister-58256

    07/08/2015, 6:19 PM
    seems to work when I modify the code as such
  • r

    rough-minister-58256

    07/08/2015, 6:19 PM
    wondering if there’s a historical reason here - maybe nailgun has a long tail synchronous startup but can actually take work much earlier?
  • e

    enough-analyst-54434

    07/08/2015, 6:20 PM
    the ng should outlive the current process
  • b

    bored-art-40741

    07/08/2015, 6:20 PM
    yes
  • r

    rough-minister-58256

    07/08/2015, 6:20 PM
    right, but its being spawned as a subprocess
  • b

    bored-art-40741

    07/08/2015, 6:20 PM
    A subprocess dies with the parent process
  • b

    bored-art-40741

    07/08/2015, 6:20 PM
    A forked process does not
  • r

    rough-minister-58256

    07/08/2015, 6:21 PM
    but the parent process is os._exiting
  • r

    rough-minister-58256

    07/08/2015, 6:21 PM
    e.g. we fork, run a subprocess then os._exit
  • b

    bored-art-40741

    07/08/2015, 6:21 PM
    Oh hm.
  • r

    rough-minister-58256

    07/08/2015, 6:21 PM
    afaict the nailguns stick around w/o the fork
  • w

    witty-crayon-22786

    07/08/2015, 6:21 PM
    dining nailguns
  • e

    enough-analyst-54434

    07/08/2015, 6:23 PM
    This is harder to follow now since it uses an Executor, but the code used to be just the daemonization pattern directly, but it should be the old double fork to prevent zombies
  • r

    rough-minister-58256

    07/08/2015, 6:24 PM
    well, im wondering if the fork is necessary at all
  • e

    enough-analyst-54434

    07/08/2015, 6:24 PM
    spawn now hides the grandchild fork
  • r

    rough-minister-58256

    07/08/2015, 6:24 PM
    but yeah double fork is essential to daemonization
  • e

    enough-analyst-54434

    07/08/2015, 6:24 PM
    well, the only requirement is a proper daemon process being created
  • e

    enough-analyst-54434

    07/08/2015, 6:25 PM
    So - if you keep/get that working, the change is fine
  • r

    rough-minister-58256

    07/08/2015, 6:25 PM
    cool
  • s

    silly-article-89931

    07/08/2015, 7:15 PM
    @rough-minister-58256: I am in the process of writing a doc for the vex project. Once I have it completed I’ll share it here and address the comment in the Pants summit agenda notes.
  • w

    witty-crayon-22786

    07/08/2015, 8:06 PM
    how does one publish a review against github.com/pantsbuild/jmake ?
  • w

    witty-crayon-22786

    07/08/2015, 8:06 PM
    and now that we have maven-central support, should we import that to pantsbuild/pants ?
  • w

    witty-crayon-22786

    07/08/2015, 8:09 PM
  • r

    rough-minister-58256

    07/08/2015, 8:16 PM
    @silly-article-89931: cool!
  • w

    witty-crayon-22786

    07/08/2015, 9:58 PM
    ring any bells for anyone?
    Copy code
    pex: Failed to translate SourcePackage(u'file:///private/var/folders/tc/kq93y4pd5jn6gy3pfzd2zd5h0000gn/T/tmpYCJaf8/twitter.common.collections-0.3.3.tar.gz')
pex: Traceback (most recent call last):
  File "/Users/stuhood/.pants.dev/os_pants/build-support/pants_dev_deps.venv/lib/python2.7/site-packages/pex/translator.py", line 101, in translate
    strict=(package.name not in ('distribute', 'setuptools')))
  File "/Users/stuhood/.pants.dev/os_pants/build-support/pants_dev_deps.venv/lib/python2.7/site-packages/pex/installer.py", line 60, in __init__
    self._interpreter.binary, self.__class__.__name__))
IncapableInterpreter: Interpreter /usr/bin/python not capable of running WheelInstaller
  • r

    rough-minister-58256

    07/08/2015, 9:59 PM
    wrong python in your $PATH?
  • w

    witty-crayon-22786

    07/08/2015, 9:59 PM
    right above that:
  • w

    witty-crayon-22786

    07/08/2015, 9:59 PM
    Copy code
    Detected interpreter /usr/bin/python: CPython-2.7.5
                     Detected interpreter /Users/stuhood/.pants.dev/os_pants/build-support/pants_dev_deps.venv/bin/python2.7: CPython-2.7.8
  • w

    witty-crayon-22786

    07/08/2015, 10:00 PM
    and yet
1...303132...2420Latest