https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    09/02/2015, 11:48 PM
    1 liner mod test
  • b

    bright-dinner-81701

    09/02/2015, 11:48 PM
    well i guess it just goes in the package.json support in general
  • e

    enough-analyst-54434

    09/02/2015, 11:49 PM
    but this is a fix to do now independent of that
  • b

    bright-dinner-81701

    09/02/2015, 11:49 PM
    im gonna finish the example as i would like it to work first
  • e

    enough-analyst-54434

    09/02/2015, 11:49 PM
    k
  • b

    bright-dinner-81701

    09/02/2015, 11:50 PM
    because a complete example needs to assume package.json support anyway
  • e

    enough-analyst-54434

    09/02/2015, 11:50 PM
    well
  • e

    enough-analyst-54434

    09/02/2015, 11:50 PM
    then it's too early
  • e

    enough-analyst-54434

    09/02/2015, 11:50 PM
    but however you want to land
  • b

    bright-dinner-81701

    09/02/2015, 11:50 PM
    you at least want a prepublish script...
  • e

    enough-analyst-54434

    09/02/2015, 11:51 PM
    I think you should land example + fix
  • e

    enough-analyst-54434

    09/02/2015, 11:51 PM
    as 1 RB
  • b

    bright-dinner-81701

    09/02/2015, 11:51 PM
    ok i can try that
  • e

    enough-analyst-54434

    09/02/2015, 11:51 PM
    that would be great
  • e

    enough-analyst-54434

    09/02/2015, 11:51 PM
    users won't care if there is an example when pants kills their packages.json!
  • b

    bright-dinner-81701

    09/02/2015, 11:52 PM
    haha
  • b

    bored-art-40741

    09/03/2015, 12:20 AM
    Oops!
  • b

    bored-art-40741

    09/03/2015, 12:21 AM
    Options migration missed missing_deps under compile.zinc
  • b

    bored-art-40741

    09/03/2015, 12:21 AM
    (Which is understandable, I think we only test under compile.java)
  • g

    gorgeous-fish-11040

    09/03/2015, 1:05 AM
    hey @enough-analyst-54434, seems pre-submit hooks are not enabled in ci. @rough-minister-58256 pointed that 
    isort.sh
    fails because of one of my recent changes. Do you mind if I will add 
    pre-commit.sh
    to 
    .travis.yml
    ?
  • e

    enough-analyst-54434

    09/03/2015, 1:07 AM
    It's already part of ci.sh - the problem must lay deeper
  • g

    gorgeous-fish-11040

    09/03/2015, 1:07 AM
    my bad I didn’t run 
    setup.sh
    tho
  • e

    enough-analyst-54434

    09/03/2015, 1:07 AM
    Shard 1 (0?) runs pre-commit.sh
  • g

    gorgeous-fish-11040

    09/03/2015, 1:09 AM
    indeed >Running pre-commit checks
  • g

    gorgeous-fish-11040

    09/03/2015, 1:14 AM
    hm. it’s because of GIT_HOOK=1 in 
    pre-commit.sh
  • g

    gorgeous-fish-11040

    09/03/2015, 1:16 AM
    git_hook only checks tracked files
  • g

    gorgeous-fish-11040

    09/03/2015, 1:39 AM
    @enough-analyst-54434: fixed here https://rbcommons.com/s/twitter/r/2758/
  • b

    bored-art-40741

    09/03/2015, 1:45 AM
    @adventurous-twilight-44110: I'm pretty sure 883fb3d5418096818849694b169f6b6f7c39b279 completely breaks zinc missing dep detection
  • b

    bored-art-40741

    09/03/2015, 1:46 AM
    (for third party deps)
  • b

    bored-art-40741

    09/03/2015, 1:47 AM
    The file name change in the middle of an otherwise semantically significant diff is difficult to follow
1...277278279...2420Latest