https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    09/01/2015, 4:22 PM
    I didn't know we had the capability to consume scalac plugins from source!
  • w

    witty-crayon-22786

    09/01/2015, 4:22 PM
    yea
  • w

    witty-crayon-22786

    09/01/2015, 4:22 PM
    testprojects/src/scala/org/pantsbuild/testproject/scalac/plugin/BUILD
  • w

    witty-crayon-22786

    09/01/2015, 4:22 PM
    and THAT is integration tested.
  • w

    witty-crayon-22786

    09/01/2015, 4:22 PM
    unlike the ability to consume remote plugins
  • w

    witty-crayon-22786

    09/01/2015, 4:23 PM
    but i'm wondering what the downside would be to requiring all plugins as targets
  • w

    witty-crayon-22786

    09/01/2015, 4:23 PM
    (more difficult to have a "globally" installed plugin? but could easily have a target list of default plugins)
  • w

    witty-crayon-22786

    09/01/2015, 4:29 PM
    @bored-art-40741: hm... it looks like this might have broken as far back as may
  • w

    witty-crayon-22786

    09/01/2015, 4:30 PM
    are you already using the 
    scalac_plugin
    target?
  • w

    witty-crayon-22786

    09/01/2015, 4:31 PM
    OH. false alarm.
  • w

    witty-crayon-22786

    09/01/2015, 4:31 PM
    bad merge =(
  • b

    bored-art-40741

    09/01/2015, 4:31 PM
    oops!
  • w

    witty-crayon-22786

    09/01/2015, 5:01 PM
    so, it looks like the scalajs situation is very similar to the multi-language thrift situation
  • w

    witty-crayon-22786

    09/01/2015, 5:02 PM
    where we essentially want to do a cross-compile for each language that depends on the target
  • w

    witty-crayon-22786

    09/01/2015, 5:03 PM
    don't know where we settled on that discussion last time around
  • l

    limited-country-20626

    09/01/2015, 5:06 PM
    congrats @rough-minister-58256!
  • r

    rough-minister-58256

    09/01/2015, 5:13 PM
    thx simple smile
  • m

    mammoth-pharmacist-54215

    09/01/2015, 5:41 PM
    @rough-minister-58256: congrats
  • e

    enough-analyst-54434

    09/01/2015, 7:37 PM
    @witty-crayon-22786: presumably to scala -> classfile & scala -> js you need 2 different scalac invocations?
  • w

    witty-crayon-22786

    09/01/2015, 7:37 PM
    @enough-analyst-54434: yep
  • w

    witty-crayon-22786

    09/01/2015, 7:37 PM
    but not necessarily two scala targets
  • e

    enough-analyst-54434

    09/01/2015, 7:38 PM
    so can scalajs just be a seperate task or does that run into actual perf issues that would be avoided doing it in more interesting ways?
  • w

    witty-crayon-22786

    09/01/2015, 7:38 PM
    except, perhaps if there is a scalajs root that indicates that its dependencies should be compiled as scalajs
  • w

    witty-crayon-22786

    09/01/2015, 7:38 PM
    separate task is my new tack
  • e

    enough-analyst-54434

    09/01/2015, 7:38 PM
    that is certainly the easiest path right now
  • w

    witty-crayon-22786

    09/01/2015, 7:39 PM
    it's a bit of a grouptask hack though: if there is a scala_js_binary target, then we transitively select any scala targets it depends on for scalajs compilation
  • w

    witty-crayon-22786

    09/01/2015, 7:39 PM
    i believe this is what thrift compilation used to do, and i'm wondering what happened with that
  • e

    enough-analyst-54434

    09/01/2015, 7:40 PM
    I was thinking a real seperate task
  • e

    enough-analyst-54434

    09/01/2015, 7:40 PM
    thus the perf nod
  • w

    witty-crayon-22786

    09/01/2015, 7:40 PM
    it is
1...266267268...2420Latest