#general
- e
enough-analyst-54434
08/31/2015, 7:57 PM@bored-art-40741: I'm going to take https://rbcommons.com/s/twitter/r/2738/ home shortly - killing sources_rel_path - unless you raise objections - r
rough-minister-58256
08/31/2015, 7:57 PMheads up, as an AI for #docfixitweek I finally managed to engage the Twitter Brand Design/Marketing team (the guys behind dev.twitter.com/get.fabric.io) who have agreed to put together a new site design for Pants.. would anyone here be interested in being part of the review panel for that? - r
rough-minister-58256
08/31/2015, 7:58 PMthe idea is that they’ll provide a non-twittery design for a simple landing page + doc site using the following other OSS tooling sites for inspiration: http://electron.atom.io/ https://facebook.github.io/watchman/ https://buckbuild.com/ https://atom.io/ http://mesos.apache.org/ http://bazel.io/ - e
enough-analyst-54434
08/31/2015, 8:01 PMI'm happy to rubber stamp their designs which are clearly of the awesome variety, I'll be most interested in the code reviews that implement them to make sure we don't lose BUILD dictionary functionality, CLI docs (flags), etc - r
rough-minister-58256
08/31/2015, 8:01 PMsure - r
rough-minister-58256
08/31/2015, 8:02 PMthey will largely just be providing the design components - someone from our side will still have to actually implement in said RBs - e
enough-analyst-54434
08/31/2015, 8:03 PMSounds great - having bling to work from might motivate folks - r
rough-minister-58256
08/31/2015, 8:03 PMyup yup - b
bored-art-40741
08/31/2015, 8:05 PM@enough-analyst-54434: shipped - e
enough-analyst-54434
08/31/2015, 8:06 PMty! - b
bored-art-40741
08/31/2015, 8:09 PM@witty-crayon-22786: I'm trying to figure out this transitivity question - b
bored-art-40741
08/31/2015, 8:09 PMI think that the two approaches happen to be equivalent in practice - w
witty-crayon-22786
08/31/2015, 8:09 PM@bored-art-40741: jar_library depending on another jar_library - w
witty-crayon-22786
08/31/2015, 8:09 PMis a thing - b
bored-art-40741
08/31/2015, 8:09 PMYeah, that's the case I'm thinking about - b
bored-art-40741
08/31/2015, 8:10 PMHowever in practice, transitive missing dep detection is all we test for - b
bored-art-40741
08/31/2015, 8:10 PMdirect is an option but I don't think it's used or tested - b
bored-art-40741
08/31/2015, 8:12 PMI suppose it's possible to get the exactly correct behavior though - b
bored-art-40741
08/31/2015, 8:13 PMI'm just hesitant to go messing with core abstractions when we are hoping to get rid of the global strategy soon anyway - w
witty-crayon-22786
08/31/2015, 8:14 PM@bored-art-40741: adding a method to ClasspathProducts should be straightforward - w
witty-crayon-22786
08/31/2015, 8:14 PM(and UnionProducts, i suppose.) - w
witty-crayon-22786
08/31/2015, 8:14 PMand i don't think this has anything to do with direct vs transitive. - w
witty-crayon-22786
08/31/2015, 8:15 PMthe analysis would just be inaccurate - w
witty-crayon-22786
08/31/2015, 8:15 PMthe reason cody extracted this was because he's going to be using it in another task that needs accuracy for these deps. - w
witty-crayon-22786
08/31/2015, 8:16 PMs/going to be using/is using/ - b
bored-art-40741
08/31/2015, 8:17 PMWhen it's transitive then the transitive dependencies (i.e. the JarLibrary depending on JarLibrary) situation collapses into being the same as what I'm doing now - b
bored-art-40741
08/31/2015, 8:17 PMBut yeah I'll add the non-transitive version - w
witty-crayon-22786
08/31/2015, 8:18 PMthanks. we want the most specific target - b
bored-art-40741
08/31/2015, 8:27 PMSplitting this into a separate RB - b
bored-art-40741
08/31/2015, 8:27 PMWith tests