#general
- w
witty-crayon-22786
08/31/2015, 7:49 PMbut unfortunately, new projects getting started with pants will occasionally want this. - w
witty-crayon-22786
08/31/2015, 7:49 PMwe could take a stand, but - e
enough-analyst-54434
08/31/2015, 7:50 PMas a reminder - this is only needed by projects following maven layout convention or g3 layout convention with a single library that composes both java and scala sources in 1 logical compile unit (jar) - w
witty-crayon-22786
08/31/2015, 7:50 PMmake that "22"... although those aren't all legit - e
enough-analyst-54434
08/31/2015, 7:50 PMSince maven layout is a real thing, we can likely never kill the feature, but just support it via SourceSets to make pants internals more sane here - w
witty-crayon-22786
08/31/2015, 7:50 PMyep, understood. - w
witty-crayon-22786
08/31/2015, 7:51 PM@enough-analyst-54434: well, it isn't strictly a requirement for maven_layout - w
witty-crayon-22786
08/31/2015, 7:51 PMbut definitely for the "one jar/ one project" case - e
enough-analyst-54434
08/31/2015, 7:51 PMits the convention - e
enough-analyst-54434
08/31/2015, 7:51 PMsrc/main/{java,scala} - e
enough-analyst-54434
08/31/2015, 7:51 PMthats the bit that kills pants - w
witty-crayon-22786
08/31/2015, 7:51 PMsure: which is fine if they're not cyclic - w
witty-crayon-22786
08/31/2015, 7:52 PMin the vast majority of cases they aren't - e
enough-analyst-54434
08/31/2015, 7:52 PMwell - by definition - a mven root is a jar - e
enough-analyst-54434
08/31/2015, 7:52 PMbut you may be violating that in your quest for more granularity - which is excellent - w
witty-crayon-22786
08/31/2015, 7:52 PMwe are. - e
enough-analyst-54434
08/31/2015, 7:52 PMSo its fraken-maven and fraken-pants - e
enough-analyst-54434
08/31/2015, 7:53 PMsuch is evolution - w
witty-crayon-22786
08/31/2015, 7:53 PMheh. - w
witty-crayon-22786
08/31/2015, 7:53 PMwell... franken maven if you consider having two projects rather than one - w
witty-crayon-22786
08/31/2015, 7:53 PM...to be franken - w
witty-crayon-22786
08/31/2015, 7:53 PManywho. - w
witty-crayon-22786
08/31/2015, 7:54 PMi actually suspect that twitter would be totally fine removing java_sources. we'd have to refactor a small number of libraries, and a few folks would grumble - e
enough-analyst-54434
08/31/2015, 7:54 PMCRUSH THEM - w
witty-crayon-22786
08/31/2015, 7:54 PMlol. - b
bored-art-40741
08/31/2015, 7:54 PM=john - r
rough-minister-58256
08/31/2015, 7:55 PMheh - w
witty-crayon-22786
08/31/2015, 7:55 PMwe burn a fair amount of political capital on having as many BUILD files as we do - w
witty-crayon-22786
08/31/2015, 7:55 PMmaybe after the graph server 😃 - w
witty-crayon-22786
08/31/2015, 7:55 PMcarrot and stick.