https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    08/31/2015, 4:12 PM
    Twitter stepped forward to do work when it had time after their monorepo internal work settled and I offered to prototype in the gap ahead of that, we've both failed so far
  • w

    witty-crayon-22786

    08/31/2015, 4:14 PM
    we're nearly ready
  • w

    witty-crayon-22786

    08/31/2015, 4:14 PM
    as to the short term solution: any reason the bundle couldn't be exposed in the 
    resources
    product?
  • f

    freezing-motorcycle-14222

    08/31/2015, 4:15 PM
    I've been prototyping a Haskell plugin to pants and I would like to submit it to a more formal review process to see if people are interested in adding it. Is there some process around adding new 
    contrib/
    plugins to pants?
  • e

    enough-analyst-54434

    08/31/2015, 4:15 PM
    No - exactly, we can hack it in
  • e

    enough-analyst-54434

    08/31/2015, 4:15 PM
  • f

    freezing-motorcycle-14222

    08/31/2015, 4:16 PM
    Awesome! Thank you
  • e

    enough-analyst-54434

    08/31/2015, 4:16 PM
    PLease try to not land it all at once though
  • e

    enough-analyst-54434

    08/31/2015, 4:16 PM
    or at least have it broken up into building layers
  • e

    enough-analyst-54434

    08/31/2015, 4:16 PM
    The goog convention of trying to stick to <= 500 delta lines is a good one to get good reviews
  • w

    witty-crayon-22786

    08/31/2015, 4:16 PM
    @freezing-motorcycle-14222: it's worthwhile to contribute a few other patches to get warmed up before diving into a plugin
  • e

    enough-analyst-54434

    08/31/2015, 4:16 PM
    Sometime hard for new stuff granted
  • f

    freezing-motorcycle-14222

    08/31/2015, 4:17 PM
    The whole thing is less than 500 lines, including all tests (it outsources most of the work to the 
    stack
    tool). However, that's why I need some sort of RFC because I need to know if the approach I'm taking is a bit unusual
  • e

    enough-analyst-54434

    08/31/2015, 4:18 PM
    You can always post an RB labelled as an RFC
  • e

    enough-analyst-54434

    08/31/2015, 4:18 PM
    so we'll just review for broad approach
  • f

    freezing-motorcycle-14222

    08/31/2015, 4:18 PM
    Alright
  • e

    enough-analyst-54434

    08/31/2015, 4:18 PM
    That's often much more useful than floaty words - for too-concrete-people like me anyway
  • f

    freezing-motorcycle-14222

    08/31/2015, 4:19 PM
    I'll do what @witty-crayon-22786 suggests and contribute a couple of small patches first to warm up and then I'll post my work as an RFC review board
  • e

    enough-analyst-54434

    08/31/2015, 4:19 PM
    K - and on your RFC please educate us with pointers to stack docs and the like
  • f

    freezing-motorcycle-14222

    08/31/2015, 4:19 PM
    Yeah, I will provide a lot of context and README material. Don't worry
  • e

    enough-analyst-54434

    08/31/2015, 4:19 PM
    We'll mostly all be dumb about this
  • e

    enough-analyst-54434

    08/31/2015, 4:19 PM
    k - great
  • e

    enough-analyst-54434

    08/31/2015, 4:24 PM
    It may be worth perusing go or node contribs, they both farm out almost all their work to the underlying ecosystem build tool(s), go uses 
    go [verb]
    and node uses 
    npm [verb]
    , so likely these plugins attack integration with pants in ways similar to yours
  • f

    freezing-motorcycle-14222

    08/31/2015, 4:25 PM
    Yeah, I cribbed heavily from the 
    contrib/go
    and 
    contrib/cpp
    plugins
  • e

    enough-analyst-54434

    08/31/2015, 4:48 PM
    Question for folks with custom plugins. Do any of you pass source_rel_path in any of these? ... mainly looking jvm_target.py and python_target.py:
    Copy code
    $ git grep "sources_rel_path=None" -- **/*.py | grep targets/
contrib/cpp/src/python/pants/contrib/cpp/targets/cpp_target.py:               sources_rel_path=None,
contrib/node/src/python/pants/contrib/node/targets/node_module.py:               sources_rel_path=None,
src/python/pants/backend/jvm/targets/jvm_target.py:               sources_rel_path=None,
src/python/pants/backend/python/targets/python_target.py:               sources_rel_path=None,
  • e

    enough-analyst-54434

    08/31/2015, 4:48 PM
    It appears to be vestigal and I'd like to kill
  • w

    witty-crayon-22786

    08/31/2015, 4:52 PM
    looking
  • w

    witty-crayon-22786

    08/31/2015, 4:53 PM
    @enough-analyst-54434: we do not
  • e

    enough-analyst-54434

    08/31/2015, 4:53 PM
    Excellent
  • e

    enough-analyst-54434

    08/31/2015, 4:53 PM
    Thank you
1...245246247...2420Latest