#general
- b
bored-art-40741
08/30/2015, 11:37 PMCan you point specifically at where that happens? - w
witty-crayon-22786
08/30/2015, 11:37 PM...oh: it doesn't test twice. i thought it was extending the compile integration test - b
bored-art-40741
08/30/2015, 11:37 PMAh, okay - w
witty-crayon-22786
08/30/2015, 11:38 PMwill add that test. - b
bored-art-40741
08/30/2015, 11:38 PMIf it's the case that builds won't succeed on follow-up runs because of cache hits, this is great - b
bored-art-40741
08/30/2015, 11:38 PMBest of both worlds - b
bored-art-40741
08/30/2015, 11:39 PMI'll kill my revert RB and apply the improvements to missing dep detection to HEAD - b
bored-art-40741
08/30/2015, 11:48 PMThanks for clarifying, Stu - w
witty-crayon-22786
08/30/2015, 11:51 PMnp. and now i cross my fingers and hope that it really wasn't broken... - b
bored-art-40741
08/30/2015, 11:51 PMha - b
bored-art-40741
08/30/2015, 11:51 PMMe too! - w
witty-crayon-22786
08/30/2015, 11:51 PMrunning the test now. - w
witty-crayon-22786
08/30/2015, 11:51 PMbut we thought carefully about the failure cases, so our primary sin was not expanding the test coverage. - b
bored-art-40741
08/30/2015, 11:52 PMHopefully we will all soon live in a world with no global strategy - b
bored-art-40741
08/30/2015, 11:52 PMWhere all sins are forgiven - w
witty-crayon-22786
08/30/2015, 11:52 PMhaha - w
witty-crayon-22786
08/30/2015, 11:55 PM@bored-art-40741: looks like we're good. https://rbcommons.com/s/twitter/r/2732/ - e
enough-analyst-54434
08/30/2015, 11:58 PMSo - Patrick's assertion that products are cached is correct, but after the unpack, the missing dep still fails - e
enough-analyst-54434
08/30/2015, 11:58 PMIs that right? - b
bored-art-40741
08/30/2015, 11:59 PMOne thing I'm not convinced of at first glance of this patch is that the same workdir/cache are used between tests - w
witty-crayon-22786
08/30/2015, 11:59 PM@bored-art-40741: take a look at BaseCompileIT - b
bored-art-40741
08/30/2015, 11:59 PMYeah reading now - b
bored-art-40741
08/30/2015, 11:59 PMBut I ended up in its superclass - b
bored-art-40741
08/30/2015, 11:59 PMDid I miss something? - w
witty-crayon-22786
08/31/2015, 12:00 AMdo_test_compile -> run_test_compile - w
witty-crayon-22786
08/31/2015, 12:00 AMself.run_pants_with_workdir - b
bored-art-40741
08/31/2015, 12:00 AMOh, it takes iterations as a param - w
witty-crayon-22786
08/31/2015, 12:00 AMyea. 2 by default - b
bored-art-40741
08/31/2015, 12:01 AMHm, and really artifact caching should not matter here, just regular workdir caching should trigger the same behavior - b
bored-art-40741
08/31/2015, 12:02 AMThus two iterations where we expect failure should be sufficient