pantsbuild #general

Channels

welcome

github-notifications

announce

bitter-ability-32190

06/20/2022, 9:25 PM

I dont think so

bitter-ability-32190

06/20/2022, 9:26 PM

Because AFAICT I can't make the name based on registry.

bitter-ability-32190

06/20/2022, 9:26 PM

And so even if I could hack it, I'd need 2 publish commands

bitter-ability-32190

06/20/2022, 9:36 PM

Is this pluggable? I'm down for more in repo plugins

curved-television-6568

06/21/2022, 5:28 AM

Not pluggable.. yet. We could add that.

curved-television-6568

06/21/2022, 5:29 AM

Or just fix the configurability for this case.. ;)

curved-television-6568

06/21/2022, 5:50 AM

There are per registry extra image tags. Could easily add per registry repository setting in there.

bitter-ability-32190

06/21/2022, 10:21 AM

Let's do that. We're tagging on the CLI now so not blocked, but eventually I just want one command

bitter-ability-32190

06/21/2022, 12:39 PM

I'm not sure how the design would look to be dlexible. I think ideally we allow a mapping of registry to additional context key/value pairs? Then I can interpolate:

repository="{registry.PREFIX}{name}"

abundant-hospital-56388

06/21/2022, 12:49 PM

Hello, I am trying to define a dependency of a

python_source

on a

shell_source

, which works according to the

./pants dependencies

command, but the

shell_source

is not included in the

.pex

file when running

./pants package

. When I replace the

shell_source

and use

resource

instead, I can make it work.

cold-soccer-63228

06/21/2022, 2:27 PM

Is there any way to run

update-build-files

on a subset of files? I want to run it in a pre-commit hook as a formatter, but having it run over the entirety of the repository causes commits to be extremely slow. From https://www.pantsbuild.org/docs/reference-update-build-files, I see:

This goal is run without arguments. It will run over all BUILD files in your project.

abundant-hospital-56388

06/21/2022, 3:07 PM

Is there a way that I can execute a command that I run with

./pants run

sudo

without pants switching to the root user cache?

bitter-ability-32190

06/21/2022, 3:10 PM

So it looks like in Pants 2.14 you can (and are actually forced) to use arguments. You might try it and see if it works with your Pants version today.

bitter-ability-32190

06/21/2022, 3:11 PM

Otherwise, you might get clever, and pass

--pants-ignore="+['...', '...']"

to tell pants to "ignore" certain dirs. during the command. YMMV on if that works

cold-soccer-63228

06/21/2022, 3:11 PM

The following command seems to still run on all files as of Pants 2.11 😞

Copy code

./pants --changed-since=origin/master update-build-files

bitter-ability-32190

06/21/2022, 3:12 PM

Ah yeah you can probably get really clever by running some shell command to revert changes to

BUILD

files that werent changed in this branch 🤷‍♂️

bitter-ability-32190

06/21/2022, 3:13 PM

But you mention its slow, so that band-aid isn't gonna help with speed

happy-kitchen-89482

06/21/2022, 3:54 PM

Ah, gotcha.

happy-kitchen-89482

06/21/2022, 3:55 PM

This page has a lot of pertinent info: https://www.pantsbuild.org/docs/python-third-party-dependencies

happy-kitchen-89482

06/21/2022, 3:55 PM

Generally, the way to tame dependency hell is via lockfiles

happy-kitchen-89482

06/21/2022, 3:57 PM

A lockfile is tied to a named "resolve" - a universe of mutually compatible 3rd-party dependencies. You define a resolve by manually authoring a requirements.txt that contains the requirements your code directly depends on. You then generate a lockfile for that resolve, and the lockfile pins specific versions of each of those requirements and all their transitive dependencies. So a lockfile gives you secure, repeatable builds even when the state of the world changes.

happy-kitchen-89482

06/21/2022, 3:59 PM

Now ideally your repo would have just one lockfile, so that every part of your repo has to be compatible with just one version of a given 3rdparty dep. In practice that may not be possible - you may genuinely need different parts of your repo to consume different versions of something. Or, you may at least temporarily need that while you consolidate down to a single lockfile.

happy-kitchen-89482

06/21/2022, 4:00 PM

But even with multiple lockfiles, at least the dep management is rigorous - each target in your internal code has to declare which lockfile(s) it's compatible with.

happy-kitchen-89482

06/21/2022, 4:01 PM

One straightforward way to migrate to this is to have one lockfile for each requirements.txt in your repo, and then start consolidating them down

happy-kitchen-89482

06/21/2022, 4:03 PM

You don't usually need to declare explicit dependencies on 3rdparty deps. Dependency inference takes care of it. The only time you do is when there is no

import

statement to infer from, or if your code is compatible with multiple resolves, and the same package is provided in more than one of those resolves.

happy-kitchen-89482

06/21/2022, 4:04 PM

So basically Pants takes your implicit dep hell and makes it explicit, forcing you to name your dependency "universes", and then gives you the tools to de-hell it, by consolidating down to - ideally - one global resolve.

happy-kitchen-89482

06/21/2022, 4:04 PM

Does this help?

wide-midnight-78598

06/21/2022, 4:18 PM

How many files and directories are there in your project? I'm assuming it'll glob through, but isn't it only acting on a single file per directory (at most?). I'm more surprised it's slow, than anything else

rhythmic-battery-45198

06/21/2022, 4:30 PM

Hi All (CC: @witty-family-13337): Question related to the new helm backend: > 🧵

proud-dentist-22844

06/21/2022, 4:44 PM

Has anyone worked on including a LICENSE file in their

python_distribution

✅ 1