pantsbuild #general

Channels

welcome

github-notifications

announce

bitter-ability-32190

04/05/2022, 8:39 PM

Hmmmm....

Copy code

python_tests(
    name="tests",
    tags=["manual_test"],
)

Copy code

./pants --tag='-manual_test' test path/to/tests/:

Seems to run the tests

bitter-ability-32190

04/05/2022, 8:40 PM

As does

./pants --tag='-manual_test' test ::

echoing-farmer-15630

04/05/2022, 8:43 PM

Yes! Sorry; works fine now with 2.11.rc1 on the poetry resolver (my issues with the pex resolver are now in another thread). Not sure what the issue is but we've made the switch to the poetry resolver and merged that into our master branch; it's working well.

🙌 1

bitter-ability-32190

04/05/2022, 8:43 PM

Oh but

list

does do the filtering. Weeeeeird

bitter-ability-32190

04/05/2022, 8:44 PM

Copy code

[DEBUG] Completed: Scheduling: Run Pytest for ...

hundreds-father-404

04/05/2022, 8:46 PM

probably https://github.com/pantsbuild/pants/issues/14977 and https://github.com/pantsbuild/pants/issues/11123. We need very badly to fix this

hundreds-father-404

04/05/2022, 8:47 PM

Maybe I'll try to slip it in after I finish some docs work and a presentation I'm preparing this week. No promises though

hundreds-father-404

04/05/2022, 8:47 PM

I think this is now the third or fourth time that this issue has come up this month

bitter-ability-32190

04/05/2022, 8:51 PM

https://github.com/pantsbuild/pants/issues/15012

bitter-ability-32190

04/05/2022, 8:53 PM

I might look into going the mark route + trying to silence the error 5 for all-manual tests

hundreds-father-404

04/05/2022, 8:54 PM

use this

Copy code

def test_hacky():
    pass

high-yak-85899

04/05/2022, 8:55 PM

Yeah that's another thing we did

hundreds-father-404

04/05/2022, 8:55 PM

We've also gone back-and-forth on whether to special case exit code 5 so that it no longer causes Pants to fail. There are pros and cons to both approaches, so thus far we have stuck with keeping normal PYtest semantics

high-yak-85899

04/05/2022, 8:56 PM

Since that came up in the marked case because pants collects things that we normally wouldn't have. So we added a dummy unittest in the same file.

high-yak-85899

04/05/2022, 8:56 PM

I'd be very interested in seeing a solution that does not require that

bitter-ability-32190

04/05/2022, 8:57 PM

I'm gonna try and whip one up

🙌 1

bitter-ability-32190

04/05/2022, 9:01 PM

Oh huh it doesn't report exit 5 if it skips all tests

👀 1

bitter-ability-32190

04/05/2022, 9:01 PM

Copy code

import pytest

@pytest.mark.skip
def test_nothing():
    pass

bitter-ability-32190

04/05/2022, 9:03 PM

Copy code

joshuacannon@CEPHANDRIUS:~/work/techlabs$ ./pants test --force --output=all path/to/test_foo.py  -- -vv
16:01:25.17 [INFO] Completed: Run Pytest - path/to/test_foo.py:tests succeeded.                                                                     
============================= test session starts ==============================                                                                                            
platform linux -- Python 3.8.12, pytest-6.1.1, py-1.11.0, pluggy-0.13.1 -- /home/joshuacannon/.cache/pants/named_caches/pex_root/venvs/s/cf02046f/venv/bin/python3.8
cachedir: .pytest_cache
rootdir: /tmp/process-executionUMiF6w, configfile: pytest.ini
plugins: profiling-1.7.0, kafka-0.5.0, forked-1.4.0, cov-3.0.0, mock-3.7.0, xdist-2.4.0, timeout-2.1.0, mockito-0.0.4
collecting ... collected 1 item

path/to/test_foo.py::test_nothing SKIPPED        [100%]

- generated xml file: /tmp/process-executionUMiF6w/path.to.test_foo.py.tests.xml -
============================== 1 skipped in 0.02s ==============================



✓ path/to/test_foo.py:tests succeeded in 0.24s

bitter-ability-32190

04/05/2022, 9:06 PM

Gonna try this out Thursday and report back: https://pypi.org/project/pytest-manual-marker/

👀 1

bitter-ability-32190

04/05/2022, 9:13 PM

that plugin deselects instead of skips 😞

bitter-ability-32190

04/05/2022, 9:14 PM

Therefore error code 5

👎 1

bitter-ability-32190

04/05/2022, 9:16 PM

https://github.com/RonnyPfannschmidt/pytest-manual-marker/issues/6

wide-zoo-86070

04/05/2022, 9:29 PM

Hi there. We use

exclude

arg in Black to exclude some dirs from black. However, it seems the exclude flag is not working with

pants

by using he same config file pyproject.toml. Anyone having this issue as well?

bitter-ability-32190

04/05/2022, 9:33 PM

Ronny is a beast:

Good point, will add matching cases hopefully by the end of the week

high-yak-85899

04/05/2022, 9:38 PM

Will that will only work for manual tests? We have some custom markers for integration tests that it sounds like we'd be right back in the same "make a dummy test to circumvent the deselecting error code" issue.

bitter-ability-32190

04/05/2022, 9:40 PM

I think if you skip instead of deselect you're OK

high-yak-85899

04/05/2022, 9:43 PM

Well we're just using the

pytest.mark.<my_custom_marker>

after specifying custom markers in

pytest.ini

. I'm not sure how to configure the skip/deselect behavior. Is that something supported out of the box?

high-yak-85899

04/05/2022, 9:45 PM

seems like there's some stuff here

high-yak-85899

04/05/2022, 9:45 PM

we currently have something similar that controlled test collection but pants ignored that because it does the collection on its own