https://pantsbuild.org/ logo
Powered by
#general
  • b

    busy-vase-39202

    01/12/2022, 8:35 PM
    Following up on https://pantsbuild.slack.com/archives/C046T6T9U/p1642007275215400 from your perspective, when you were evaluating whether to choose a monorepo arch, what are the top 3 or 4 questions you needed answered? What were the top 3 or 4 challenges you faced in reaching a decision (whether personally, as a team, or as an org)? Answer this any way you want. There's no correct pov here. We're trying to learn from you how to help newcomers better. Thank you for sharing insights into your thought process!
    w
    • 2
    • 6
  • f

    flat-zoo-31952

    01/12/2022, 10:08 PM
    I'm trying to think of ways to incrementally add pants to a chaotic monorepo, and I'd like to validate an idea I had. The plan would be to deeply restrict where BUILD files go to a few components that sit at the leaves of our messy dependency graph, and then just ask Pants if it knows about those files in CI... If it knows about the full set of files in the changeset, we could use Pants to direct the CI pipeline. If there are files Pants doesn't know about, then we'd give up and just run the old pipeline (which basically runs all tests in the monorepo). Does this approach make sense?
    b
    b
    +2
    • 5
    • 41
  • w

    witty-crayon-22786

    01/12/2022, 10:22 PM
  • c

    calm-ambulance-65371

    01/12/2022, 11:07 PM
    Back on my Pants 2.2 -> 2.9 upgrade. Latest issue is this: 
    ERROR: Package '<redacted>' requires a different Python: 3.8.10 not in '>=3.8'
    👀 1
    h
    h
    • 3
    • 4
  • c

    curved-television-6568

    01/13/2022, 9:09 AM
    When running some tests, I’m trying to understand why there’s such large differences in time, although it says they are both memoized: [SOLVED]
  • c

    curved-television-6568

    01/13/2022, 9:09 AM
    Copy code
    ✓ src/python/pants/backend/docker/util_rules/dependencies_test.py:tests succeeded in 60.21s (memoized).
✓ src/python/pants/backend/docker/util_rules/docker_binary_test.py:tests succeeded in 4.37s (memoized).
  • c

    curved-television-6568

    01/13/2022, 9:10 AM
    Anyone has any insights for me here (or what else to look for to dig further..?)
  • h

    happy-kitchen-89482

    01/13/2022, 10:13 AM
    I believe that is the time it took to run originally, when it was memoized? Or are you seeing it actually take that long?
  • c

    curved-television-6568

    01/13/2022, 10:13 AM
    Ah, ok, yeah that makes sense.
  • c

    curved-television-6568

    01/13/2022, 10:14 AM
    Currently my computer is so laggish and nothing is working properly, so I think it needs a hard reboot…
  • c

    curved-television-6568

    01/13/2022, 10:15 AM
    But no you’re right, those times are from the original run, it seems.
  • d

    dry-analyst-73584

    01/13/2022, 5:13 PM
    Hey! I'm looking for some info on the future of pants support for web dev - specifically for people developing React apps. Can anyone fill me in or point me at some documentation?
    👀 1
    b
    b
    +5
    • 8
    • 36
  • w

    witty-crayon-22786

    01/13/2022, 5:22 PM
    yea, that is vaguely confusing
    👍 1
  • w

    witty-crayon-22786

    01/13/2022, 5:24 PM
    we don’t currently record metadata around how long the cache hit or memoization itself took
  • i

    incalculable-yacht-75851

    01/13/2022, 6:05 PM
    I'm attempting to upgrade from 2.8 to 2.9 and I'm getting the following warning which is related to an internal plugin:
    Copy code
    10:04:29.00 [WARN] DEPRECATED: the `pants_requirement` macro will be removed in version 2.10.0.dev0.

Use the target `pants_requirements` instead. First, add `pants.backend.plugin_development` to `[GLOBAL].backend_packages` in `pants.toml`. Then, delete all `pants_requirement` calls and replace them with a single `pants_requirements(name='pants')`.

By default, `pants_requirements` will generate a `python_requirement` target for both `pantsbuild.pants` and `pantsbuild.pants.testutil`.
    More in 🧵
    w
    • 2
    • 4
  • h

    high-energy-55500

    01/13/2022, 7:03 PM
    is it possible to specify a commit hash for a linter version? i tried this in 
    pants.toml
    but it didn’t work
    Copy code
    [pylint]
config = ".pylintrc"
version = "<git+git://github.com/PyCQA/pylint.git@e75e37a2908ef1c003ea5816c1e234523bdd38be#egg=pylint>"
lockfile = "pylint.lock"
    h
    • 2
    • 4
  • c

    curved-television-6568

    01/13/2022, 7:32 PM
    I think it makes more sense to present the original time (perhaps the time used to get the cached/memoized result would be interesting in addition as well)
    👍 1
  • h

    hundreds-father-404

    01/13/2022, 7:51 PM
    yeah I agree it's useful to show original time. Otherwise imagine how frustrating it would be to try to find "what are my slowest tests?" You'd have to make sure caching and memoization is disabled
    ➕ 1
  • p

    polite-garden-50641

    01/13/2022, 8:07 PM
    What is the logic for trimming 
    .pants.d/pants.log
    (when pantsd is active) ? How to we make pants keep more data in this log? Running in CI, I noticed this file only contains logs from the last few steps that run in CI before the file was uploaded and it is missing log message from pants run that occur earlier on in the CI Job.
  • b

    brash-baker-91190

    01/13/2022, 8:33 PM
    Just wanted to say "thanks" to everyone for all the great deprecation messages in Pants! It makes upgrading a very easy experience! 🙇
    👍 5
    ❤️ 1
  • c

    curved-television-6568

    01/13/2022, 8:36 PM
    speaking of that, I had a thought earlier, about optionally sorting all the completed tests based on their execution time (to get the slowest at top/bottom)
  • h

    hundreds-father-404

    01/13/2022, 9:22 PM
  • b

    brash-baker-91190

    01/13/2022, 9:23 PM
    🤔 After upgrading to 2.9, I'm seeing some failures when running Pytest tests.
    Copy code
    ProcessExecutionFailure: Process 'Building pytest_runner.pex' failed with exit code 1.
    Followed by a bunch of these:
    Copy code
    pex.environment.ResolveError: Failed to resolve requirements from PEX environment @ /home/maier/.cache/pants/named_caches/pex_root/unzipped_pexes/f00d5546a767d36a195e863e80031df5797b7eb8.
Needed manylinux_2_28_x86_64-cp-37-cp37m compatible dependencies for:
 1: boto3
    Required by:
      FingerprintedDistribution(distribution=grapl-common 0.0.6 (/home/maier/.cache/pants/named_caches/pex_root/installed_wheels/7f5c555e91114b099cc3946517adba787c2ede3e/grapl_common-0.0.6-py3-none-any.whl), fingerprint='a76df1c3f9ecd1ae5ae2352850c933b30140ba93')
    But this pex had no 'boto3' distributions.
 2: botocore
    Required by:
      FingerprintedDistribution(distribution=grapl-common 0.0.6 (/home/maier/.cache/pants/named_caches/pex_root/installed_wheels/7f5c555e91114b099cc3946517adba787c2ede3e/grapl_common-0.0.6-py3-none-any.whl), fingerprint='a76df1c3f9ecd1ae5ae2352850c933b30140ba93')
    But this pex had no 'botocore' distributions.
 3: mypy-boto3-cloudwatch
    Required by:
      FingerprintedDistribution(distribution=grapl-common 0.0.6 (/home/maier/.cache/pants/named_caches/pex_root/installed_wheels/7f5c555e91114b099cc3946517adba787c2ede3e/grapl_common-0.0.6-py3-none-any.whl), fingerprint='a76df1c3f9ecd1ae5ae2352850c933b30140ba93')
    But this pex had no 'mypy-boto3-cloudwatch' distributions.
 4: mypy-boto3-dynamodb
    Required by:
      FingerprintedDistribution(distribution=grapl-common 0.0.6 (/home/maier/.cache/pants/named_caches/pex_root/installed_wheels/7f5c555e91114b099cc3946517adba787c2ede3e/grapl_common-0.0.6-py3-none-any.whl), fingerprint='a76df1c3f9ecd1ae5ae2352850c933b30140ba93')
    But this pex had no 'mypy-boto3-dynamodb' distributions.
    (plus 8 similar missing dependencies) Any pointers on where to look? I've regenerated my pytest lockfile. Thanks in advance.
    👀 1
    h
    p
    e
    • 4
    • 48
  • c

    curved-television-6568

    01/13/2022, 9:28 PM
    Haha… yeah, about the same time, by the looks of it. 😄
  • p

    polite-garden-50641

    01/13/2022, 10:38 PM
    @witty-crayon-22786
  • w

    witty-crayon-22786

    01/13/2022, 10:41 PM
    i believe that it used to be kept indefinitely, but it does appear to be the case right now that every time 
    pantsd
    is restarted, it is cleared
  • w

    witty-crayon-22786

    01/13/2022, 10:42 PM
    that… should probably be considered a bug.
    👍 1
  • w

    witty-crayon-22786

    01/13/2022, 10:45 PM
    hm. but the most obvious location for it to be cleared doesn’t appear to be: https://github.com/pantsbuild/pants/blob/b80eb7cfae31b5b4c8f2722a8a938117ffafbe48/src/rust/engine/logging/src/logger.rs#L79-L83 … the 
    append(true)
    there should cause us to append to an existing file.
  • p

    polite-garden-50641

    01/13/2022, 10:55 PM
    I see this behavior in our internal CI, so I will provide links and info over in our internal slack.
  • w

    witty-crayon-22786

    01/13/2022, 10:55 PM
    I think it repros locally, so no need
1...225422552256...2420Latest