https://pantsbuild.org/ logo
Powered by
#general
  • b

    billowy-motherboard-58443

    09/21/2020, 3:50 PM
    e.g if I say 
    dependencies = [ "//:requests" ]
    or have "ns/core" in both
  • a

    aloof-angle-91616

    09/21/2020, 3:52 PM
    hmmm. i assume a 
    python_tests()
    target declared in 
    ns/config/test/BUILD
    depends on something in 
    ns/config/BUILD
    ? if so, then you wouldn't need to redeclare it, because dependencies apply transitively in python targets. what is the error you're seeing?
  • b

    billowy-motherboard-58443

    09/21/2020, 3:52 PM
    well
  • b

    billowy-motherboard-58443

    09/21/2020, 3:53 PM
    if I have ALL the deps in test/BUILD it runs fine, but I'm thinking that that is inappropriate insofar as an actual build of the lib wants ns/config/BUILD to declare at least 3rd party things like requests as actual deps...
  • b

    billowy-motherboard-58443

    09/21/2020, 3:53 PM
    whereas ns/config/tests/BUILD wants to include "//:mock" (and the real pkg does not)
  • a

    aloof-angle-91616

    09/21/2020, 3:54 PM
    hmmmm. that is interesting. duplicate dependencies shouldn't be an error in any case
  • b

    billowy-motherboard-58443

    09/21/2020, 3:54 PM
    the error message is an eternal spew of "circular detected"
  • b

    billowy-motherboard-58443

    09/21/2020, 3:54 PM
    Copy code
    15:48:36.42 [WARN] Couldn't remove cycle containing dirty nodes after 11 attempts; nodes in cycle:
    and a ton of data
  • a

    aloof-angle-91616

    09/21/2020, 3:55 PM
    ah ok. well first of all i wish it wouldn't go eternally, sorry. second, we might be able to have tools for better detecting this. is it possible there's a legitimate circular dependency, i.e. 
    ns/core
    depends on something else that depends on 
    ns/config
    ? i think 
    ./pants dependees --transitive ns/config
    will tell you if anything unexpected is transitively depending on it
  • b

    billowy-motherboard-58443

    09/21/2020, 3:56 PM
    that gives
  • b

    billowy-motherboard-58443

    09/21/2020, 3:56 PM
    Copy code
    ns/util:util
ns/util/tests:tests
  • a

    aloof-angle-91616

    09/21/2020, 3:57 PM
    i might also go the other way and try 
    ./pants dependencies --transitive ns/core
  • b

    billowy-motherboard-58443

    09/21/2020, 3:57 PM
    which I think are what uses ns/config
  • a

    aloof-angle-91616

    09/21/2020, 3:57 PM
    ok, that seems normal then. i wouldn't expect anything to be depending on 
    ns/config/tests
    either
  • b

    billowy-motherboard-58443

    09/21/2020, 3:58 PM
    no, 
    --transitive ns/config/tests
    gives nothing
  • b

    billowy-motherboard-58443

    09/21/2020, 3:58 PM
    so, when I have all the deps in ns/config/tests/BUILD - tests work
  • b

    billowy-motherboard-58443

    09/21/2020, 3:59 PM
    when I move the things which mater to ns/config (and therefor the tests too) up to ns/config/BUILD - and leave things like "//:mock" in tests/BUILD
  • b

    billowy-motherboard-58443

    09/21/2020, 3:59 PM
    tests fail with import errors
  • a

    aloof-angle-91616

    09/21/2020, 3:59 PM
    ok well you should be able to declare all your 3rdparty deps in 
    ns/config
    (except for 
    //:mock
    ) and have it work -- is that right?
  • a

    aloof-angle-91616

    09/21/2020, 3:59 PM
    hm. that's very strange
  • b

    billowy-motherboard-58443

    09/21/2020, 3:59 PM
    right
  • a

    aloof-angle-91616

    09/21/2020, 3:59 PM
    also, what is the output of 
    ./pants dependencies --transitive ns/core
    ?
  • a

    aloof-angle-91616

    09/21/2020, 4:00 PM
    note that's 
    dependencies
    , not 
    dependees
  • b

    billowy-motherboard-58443

    09/21/2020, 4:00 PM
    empty
  • b

    billowy-motherboard-58443

    09/21/2020, 4:00 PM
    haven't filled in everything yet though so... 🤷
  • b

    billowy-motherboard-58443

    09/21/2020, 4:01 PM
    hmmm.. Which makes me wonder what happens if both core and util depend on //:requests and util depends on core....
  • a

    aloof-angle-91616

    09/21/2020, 4:02 PM
    that should also be fine, i think
  • a

    aloof-angle-91616

    09/21/2020, 4:02 PM
    still a directed acyclic
  • b

    billowy-motherboard-58443

    09/21/2020, 4:02 PM
    hmmm
  • a

    aloof-angle-91616

    09/21/2020, 4:03 PM
    ok so (1) you should be able to have duplicate dependencies just fine in 
    ns/config/BUILD
    and 
    ns/config/tests/BUILD
    . in fact, that's somewhat preferred over putting it in just the one parent target. (2) the cycle should only happen if there's a legitimate dependency cycle between dependencies declared in BUILD files, which you should be able to see. there is a shadow of a chance that this is a nondeterministic pantsd error, which you can check by running 
    ./pants kill-pantsd
    and then re-running the command
1...217221732174...2420Latest