https://pantsbuild.org/ logo
Powered by
#general
  • b

    billowy-motherboard-58443

    09/21/2020, 3:14 PM
    (namely to the enclosing pkg ...)
  • a

    aloof-angle-91616

    09/21/2020, 3:14 PM
    you will need to have at least one BUILD file somewhere that owns each file. the BUILD file can be in any parent directory of the file you wish to test
  • b

    billowy-motherboard-58443

    09/21/2020, 3:15 PM
    Copy code
    python_tests(
    name = "tests",
    dependencies = [
        "ns/foo",
    ]
)
    as ns/foo/tests/BUILD
  • a

    aloof-angle-91616

    09/21/2020, 3:15 PM
    if it's not the same directory, you can use relative paths, or recursive globs
  • b

    billowy-motherboard-58443

    09/21/2020, 3:15 PM
    (I tried moving that file out of there and the test goal complained about its non-existence)
  • a

    aloof-angle-91616

    09/21/2020, 3:15 PM
    if you have your test files in the same directory, that should work. if they're in 
    ns/foo/tests/xx/
    , you'll want 
    sources=['**/test_*.py']
    or 
    sources=['xx/test_*.py']
  • a

    aloof-angle-91616

    09/21/2020, 3:17 PM
    if you like, you could have a BUILD file in 
    ns
    with:
    Copy code
    python_tests(
  name = "tests",
  sources = ['**/test_*.py'],
  ...
)
  • a

    aloof-angle-91616

    09/21/2020, 3:17 PM
    and then you would run 
    ./pants test ns:tests
  • a

    aloof-angle-91616

    09/21/2020, 3:17 PM
    or even at the root
  • b

    billowy-motherboard-58443

    09/21/2020, 3:17 PM
    hmm
  • b

    billowy-motherboard-58443

    09/21/2020, 3:18 PM
    ns/foo/tests/BUILD is working fine with
    Copy code
    python_tests(
    name = "tests",
    dependencies = [
        "ns/foo",
    ]
)
  • a

    aloof-angle-91616

    09/21/2020, 3:18 PM
    BUILD files allow you to specify the level of granularity you want. if you typically run different sets of tests differently, you would have different targets in some BUILD files (maybe the same BUILD file) so that you can address them separately
  • a

    aloof-angle-91616

    09/21/2020, 3:19 PM
    sources=['test_*.py']
    is inferred if none is provided, for 
    python_tests()
    targets
  • b

    billowy-motherboard-58443

    09/21/2020, 3:19 PM
    all our test files are named eitehr test_x.py or x_test.py so I guess they're being caught?
  • b

    billowy-motherboard-58443

    09/21/2020, 3:19 PM
    oh, not both ways? only 
    test_*.py
    ?
  • a

    aloof-angle-91616

    09/21/2020, 3:19 PM
    good question. you can test this using file arguments with 
    ./pants test ns/foo/tests/x_test.py
  • a

    aloof-angle-91616

    09/21/2020, 3:20 PM
    i thought it was just 
    test_*.py
    but i haven't checked in a while and am more likely to be wrong than you are
  • b

    billowy-motherboard-58443

    09/21/2020, 3:20 PM
    x_test.py is definitely getting hit with my current setup
    👍 1
  • a

    aloof-angle-91616

    09/21/2020, 3:20 PM
    Copy code
    class PythonTestsSources(PythonSources):
    default = ("test_*.py", "*_test.py", "tests.py", "conftest.py")
  • a

    aloof-angle-91616

    09/21/2020, 3:21 PM
    looks like both are supported! although the last two might just be in pants 2.0.0+
  • b

    billowy-motherboard-58443

    09/21/2020, 3:21 PM
    yes, confirmed
    🌈 1
  • a

    aloof-angle-91616

    09/21/2020, 3:21 PM
    awesome
  • a

    aloof-angle-91616

    09/21/2020, 3:21 PM
    please let us know if you experience further issues
  • a

    aloof-angle-91616

    09/21/2020, 3:23 PM
    thanks for your patience, i wasn't up to date on all the recent changes
  • b

    billowy-motherboard-58443

    09/21/2020, 3:23 PM
    thank you for your prompt efforts to help
    ❤️ 1
  • b

    billowy-motherboard-58443

    09/21/2020, 3:48 PM
    @aloof-angle-91616 still here? 🙂
  • a

    aloof-angle-91616

    09/21/2020, 3:48 PM
    yes!
  • b

    billowy-motherboard-58443

    09/21/2020, 3:49 PM
    so.. with 
    ns/config
    - trying to sort what belongs in ns/config/BUILD and ns/config/test/BUILD
  • b

    billowy-motherboard-58443

    09/21/2020, 3:49 PM
    seems like your dependency analyzer doesn't like to see duplicate deps in those...
  • a

    aloof-angle-91616

    09/21/2020, 3:50 PM
    oh yes -- although i'm not sure if dependency inference is turned on in 1.30.x, but not sure. what duplicates are you referring to?
1...217121722173...2420Latest