https://pantsbuild.org/ logo
Powered by
#general
  • a

    aloof-angle-91616

    09/21/2020, 2:50 PM
    not a problem at all
  • b

    billowy-motherboard-58443

    09/21/2020, 2:50 PM
    when I made it ['/', 'realval of ns'] (forgive me being cagey...)
    a
    • 2
    • 1
  • b

    billowy-motherboard-58443

    09/21/2020, 2:51 PM
    the test target now complains about 
    No module found: 'real-ns'
  • b

    billowy-motherboard-58443

    09/21/2020, 2:51 PM
    so simply addnign that directory name to root_patterns isn't quite it...
  • a

    aloof-angle-91616

    09/21/2020, 2:53 PM
    yes. i think 
    "/"
    is the right pattern to add, i think that adding 
    /real-ns
    to patterns would make it detect packages so that you would need 
    from bar.common.model.security import xxx
  • a

    aloof-angle-91616

    09/21/2020, 2:54 PM
    i will create an issue about adding a tool to display all detected python package namespaces to help debug this issue. let me know if you can think of anything else that would help you figure this out. sorry again, i think you're doing everything right
  • b

    billowy-motherboard-58443

    09/21/2020, 2:54 PM
    I copied the pants.toml from the example repo - so it has
    Copy code
    [source]
# The Python source root is the repo root. See <https://www.pantsbuild.org/docs/source-roots>.
root_patterns = ["/"]
  • a

    aloof-angle-91616

    09/21/2020, 2:55 PM
    ah yes, sorry to link you to that again then. i think that's still correct
  • a

    aloof-angle-91616

    09/21/2020, 2:56 PM
    oh, one last possibility: could you check whether explicitly not ignoring the directory helps? as per https://www.pantsbuild.org/docs/troubleshooting#pants-cannot-find-a-file-in-your-project
  • b

    billowy-motherboard-58443

    09/21/2020, 2:56 PM
    when it is 
    ["/", "/real-ns"]
    I get the 
    E   ModuleNotFoundError: No module named 'real-ns'
    h
    • 2
    • 1
  • a

    aloof-angle-91616

    09/21/2020, 2:57 PM
    i might also recommend trying 
    ./pants filedeps real-ns/bar/bar/common/model/security
    in order to see if it picks up the desired files as per https://www.pantsbuild.org/docs/project-introspection#filedeps---find-which-files-a-target-owns
  • b

    billowy-motherboard-58443

    09/21/2020, 2:57 PM
    simply moving .gitignore out of the way for a run doesn't change the error
    👍 1
  • b

    billowy-motherboard-58443

    09/21/2020, 2:57 PM
    kk
  • a

    aloof-angle-91616

    09/21/2020, 2:59 PM
    also, if you have non-empty 
    __init__.py
    files, it looks like you need a separate option (https://www.pantsbuild.org/docs/python-backend):
    Copy code
    [python-infer]
inits = true
  • a

    aloof-angle-91616

    09/21/2020, 2:59 PM
    not sure why we can't check if the files are empty and do that automatically
  • b

    billowy-motherboard-58443

    09/21/2020, 2:59 PM
    ./pants filedeps ns/bar
    =>
    Copy code
    ns/bar/BUILD
ns/bar/__init__.py
    👍 1
  • b

    billowy-motherboard-58443

    09/21/2020, 3:00 PM
    but if I do 
    ns/bar/common
  • b

    billowy-motherboard-58443

    09/21/2020, 3:00 PM
    Copy code
    ResolveError: "common" was not found in namespace "ns/bar/common". Did you mean one of:
  • b

    billowy-motherboard-58443

    09/21/2020, 3:00 PM
    we do have non-empty init.py files scattered around, but not in any consistent way
    h
    • 2
    • 2
  • a

    aloof-angle-91616

    09/21/2020, 3:02 PM
    ok, i think you may need to turn on that option then. to your message just now: is there a BUILD file in 
    ns/bar/common
    ?
  • b

    billowy-motherboard-58443

    09/21/2020, 3:02 PM
    15:02:00 [ERROR] Invalid scope [python-infer] in /src/gh-pants-test/pants.toml
    ????
  • a

    aloof-angle-91616

    09/21/2020, 3:02 PM
    apologies. which pants version are you using?
  • b

    billowy-motherboard-58443

    09/21/2020, 3:03 PM
    1.30.1rc0
  • b

    billowy-motherboard-58443

    09/21/2020, 3:03 PM
    to answer your other question, no, there is no BUILD below 
    ns/bar
    (yet)
  • a

    aloof-angle-91616

    09/21/2020, 3:03 PM
    ah ok, so dependency inference i think is not active. very sorry for missing that
  • b

    billowy-motherboard-58443

    09/21/2020, 3:04 PM
    so, what is the rule on "where does one have to have a BUILD file, and what contents are required?"
    h
    • 2
    • 1
  • a

    aloof-angle-91616

    09/21/2020, 3:04 PM
    in that case, i think you will need to use 
    **/*.py
    as the 
    sources
    in 
    ns/bar/BUILD
  • a

    aloof-angle-91616

    09/21/2020, 3:05 PM
    there are no contents required in a BUILD file, but if you specify e.g.
    Copy code
    python_library(
  sources=['*.py'],
)
    it will only pick up python files in the current directory. to make it see through recursive subdirectories, you would want:
    Copy code
    python_library(
  sources=['**/*.py'],
)
  • a

    aloof-angle-91616

    09/21/2020, 3:05 PM
    both methods should work equally well
  • b

    billowy-motherboard-58443

    09/21/2020, 3:05 PM
    so... I should add that to the declaration at 
    ns/bar/BUILD
    ?
    ✨ 1
1...216921702171...2420Latest