#general
- a
aloof-angle-91616
09/21/2020, 2:29 PMone thing i found somewhat annoying but i think there's a good reason for is that i think we still require an
file in every directory in order to detect a package within it. is there such a file in__init__.py
?ns/bar/common - b
billowy-motherboard-58443
09/21/2020, 2:29 PMlooks - b
billowy-motherboard-58443
09/21/2020, 2:30 PMyep - a
aloof-angle-91616
09/21/2020, 2:30 PMgrrr. sorry. also, we could possibly improve the error message a tad by scrubbing the process execution directory - b
billowy-motherboard-58443
09/21/2020, 2:30 PMpretty sure we have that convention everywhere from "plain python"👍 1 - a
aloof-angle-91616
09/21/2020, 2:31 PMi'm under the impression you've done everything right here so i will attempt to reproduce your description within the pants repo - b
billowy-motherboard-58443
09/21/2020, 2:32 PMkk - a
aloof-angle-91616
09/21/2020, 2:39 PMi have reproduced the error - a
aloof-angle-91616
09/21/2020, 2:40 PMah, but i forgot intermediate
files, let me try again__init__.py - a
aloof-angle-91616
09/21/2020, 2:41 PMah, ok, that seemed to work. do you have
andns/__init__.py
as well? i assume so since you mentioned "plain python"ns/bar/__init__.py - a
aloof-angle-91616
09/21/2020, 2:42 PMah. sorry. i think the issue is "source roots". let me find a good reference for that - a
aloof-angle-91616
09/21/2020, 2:44 PMtry this page: https://www.pantsbuild.org/docs/source-roots. i believe what's happening is that if
is a top-level directory, then it's not within a nested directory such asns/
. pants uses "source root patterns" to infer what the root package is. there are ways to avoid having to modify your directory structure thoughsrc/python - b
billowy-motherboard-58443
09/21/2020, 2:44 PMyes, I have those files - b
billowy-motherboard-58443
09/21/2020, 2:44 PMok ,so... - b
billowy-motherboard-58443
09/21/2020, 2:44 PMin pants.toml I need.... - a
aloof-angle-91616
09/21/2020, 2:45 PMCopy code
i think[source] root_patterns = ['/'] - b
billowy-motherboard-58443
09/21/2020, 2:45 PMor
?root_patterns = ['/', 'ns'] - a
aloof-angle-91616
09/21/2020, 2:45 PMhmmmm. it says that's in the default - b
billowy-motherboard-58443
09/21/2020, 2:45 PMwhat's the way to print out what it thinks it is using?👍 1 - a
aloof-angle-91616
09/21/2020, 2:45 PMit should be just the
, so i've failed to answer your question twice/ - a
aloof-angle-91616
09/21/2020, 2:46 PM./pants roots - b
billowy-motherboard-58443
09/21/2020, 2:46 PM
did not help, FWIWroot_patterns = ["/", "/ns"]👍 1 - a
aloof-angle-91616
09/21/2020, 2:47 PMyes, sorry, the docs say
is included as default/ - b
billowy-motherboard-58443
09/21/2020, 2:47 PMhmm.
simply replies with./pants roots
even after I added./ns - a
aloof-angle-91616
09/21/2020, 2:48 PMthat's actually correct, sorry. the "source root" is the directory containing the first directory component of a package name - a
aloof-angle-91616
09/21/2020, 2:49 PMcould i ask you to copy/paste your problem description into an issue at https://github.com/pantsbuild/issues/new? i believe someone else more familiar with dependency inference will be able to answer your question later today, but not sure when they'll wake up - b
billowy-motherboard-58443
09/21/2020, 2:49 PMheh - b
billowy-motherboard-58443
09/21/2020, 2:50 PMhang on - a
aloof-angle-91616
09/21/2020, 2:50 PMseparately, it would be nice to have debugging tools for this scenario beyond
. we should be able to print every python package namespace that it detects, for example./pants roots - b
billowy-motherboard-58443
09/21/2020, 2:50 PMso, I did something silly (I used the actuall string
which isn't what it really is in the repo)ns👍 1