pantsbuild #general

Channels

welcome

github-notifications

announce

plain-river-51682

09/11/2020, 7:51 AM

does someone has any idea why this happens? https://pantsbuild.slack.com/archives/C14C1AKHP/p1599745914007000

narrow-activity-17405

09/11/2020, 8:06 AM

Is there any way how can I run tests against distribution targets? It would be good to test them before uploading to pypi - I can imagine that for instance, some dependency might be missing...

wooden-thailand-8386

09/11/2020, 7:48 PM

Hey what would be a good pattern for shared fixtures for multiple tests? Right now I have a

tests

folder that branches into a similar structure as I have for my projects ands libs.. something like:

Copy code

tests/
  libs/
    libA/
    libB/
   projects/
    projectA/
    projectB/

and for libA and libB I might have a couple of fixtures that are basically the same. Should I create a “fixtures-lib” and use / put a fixtures folder under

tests

and reuse it or duplicate code?

wooden-thailand-8386

09/12/2020, 3:35 PM

hey @happy-kitchen-89482 I’m sending you all my love ❤️ just tested the PR that you merged and it’s working like a charm. I can finally use pants v2 and it’s amazing! 😄 Thanks @hundreds-father-404 too for putting up with me annoying you guys on CA Certs thing lol

👖 1

👍 1

❤️ 1

🔥 1

acceptable-guitar-79854

09/13/2020, 12:25 PM

Thank you @happy-kitchen-89482 @hundreds-father-404 I can pip install external packages behind a proxy with 2.0.0a3 👍 👍

❤️ 2

acceptable-guitar-79854

09/13/2020, 12:34 PM

Now it seems to complain about internal packages:

Copy code

ERROR: Could not find a version that satisfies <interal-package> (from -c constraints.txt (line 1)) (from versions: none)
pid: <PID> -> path/to/python /.../.cache/pants/named_caches/pex_root/pip.pex/<hash> --disable-pip-version-check --isolated --no-python-version-warning --exists-action a -q -cache-dir /.../.cache/pants/named_caches/pex_root download --dest /tmp/<tmp dir>/<path to python bin separated with .> --index-url <https://pypi.org/simple> --extra-index-url <http://our-artifactory>:port/.../simple --trusted-host our-actifactory:port --header Cache-Control:max-age=3600 --retries 5 timeout 15 --constraint constraints.txt <internal-package> flask requests

raised Executing <<the command above>>

• In pants.toml I added

Copy code

[python-repos]
indexes.add = ["<http://our-artifactory>:port/.../simple"]

acceptable-guitar-79854

09/13/2020, 12:40 PM

the strange thing is that if I just copy+paste+run that command separately. In

/tmp/<tmp dir>/<path to python bin separated with .>

there is a

<internal-package>.whl

along with other packages. So basically that command works if not run through pants.

acceptable-guitar-79854

09/13/2020, 12:44 PM

Question number 2 is: requirements.txt/constraints.txt contains packages which in total add up to 5GB which is a bit too dangerous for /tmp/ is there a way this can be configured? I tried setting

Copy code

[GLOBAL]
local_execution_root_dir = '...'

but this doesn't change

--dest

in the command above

aloof-angle-91616

09/14/2020, 11:23 AM

am starting a conversation with a bazeler on how to integrate the nix reproducible (checksummed) package manager with pants and bazel, i think a PR (an issue to start) on the nix repo to discuss how to configure nix to install itself to some specified prefix instead of requiring /nix as i believe it does atm. user is not from google but tweag dot io. i will try to follow up on this for now. https://twitter.com/mboesp/status/1305464631297806336?s=21

wonderful-iron-54019

09/15/2020, 6:59 PM

[tesitng custom plugins thread]

witty-crayon-22786

09/15/2020, 9:56 PM

https://pantsbuild.slack.com/archives/CASMF8SJ1/p1600197208080100

👖 1

fancy-motherboard-24956

09/16/2020, 2:30 PM

Hi here, I’ve got the most noobish question:

Copy code

./pants --version
Bootstrapping pants_deps with requirements:
  /Users/pchevalier/Documents/code/pants/3rdparty/python/requirements.txt
  /Users/pchevalier/Documents/code/pants/3rdparty/python/twitter/commons/requirements.txt
  /Users/pchevalier/Documents/code/pants/pants-plugins/3rdparty/python/requirements.txt
  /Users/pchevalier/Documents/code/pants/contrib/python/src/python/pants/contrib/python/checks/checker/3rdparty/requirements.txt
Using python at /usr/bin/python3
Using base prefix '/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8'
New python executable in /Users/pchevalier/Documents/code/pants/build-support/virtualenvs/Darwin/pants_dev_deps.py38.venv/bin/python3
Also creating executable in /Users/pchevalier/Documents/code/pants/build-support/virtualenvs/Darwin/pants_dev_deps.py38.venv/bin/python
Traceback (most recent call last):
  File "/Users/pchevalier/Documents/code/pants/build-support/virtualenv.dist/virtualenv.py", line 2619, in <module>
    main()
  File "/Users/pchevalier/Documents/code/pants/build-support/virtualenv.dist/virtualenv.py", line 857, in main
    create_environment(
  File "/Users/pchevalier/Documents/code/pants/build-support/virtualenv.dist/virtualenv.py", line 1142, in create_environment
    install_python(home_dir, lib_dir, inc_dir, bin_dir, site_packages=site_packages, clear=clear, symlink=symlink)
  File "/Users/pchevalier/Documents/code/pants/build-support/virtualenv.dist/virtualenv.py", line 1607, in install_python
    shutil.copy(original_python, py_executable)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/shutil.py", line 415, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/shutil.py", line 240, in copyfile
    if _samefile(src, dst):
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/shutil.py", line 217, in _samefile
    return os.path.samefile(src, dst)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/genericpath.py", line 100, in samefile
    s1 = os.stat(f1)
TypeError: stat: path should be string, bytes, os.PathLike or integer, not NoneType

Failed to create venv.

fancy-motherboard-24956

09/16/2020, 2:31 PM

So my question is: whyyyyyy 😅? Or rather: has someone experienced the same problem with their python setup and do you know how to get back to a state where I can use pants?

hundreds-breakfast-49010

09/16/2020, 7:09 PM

general announcement that the first 2.0.0 beta release is now on PyPI: https://pypi.org/project/pantsbuild.pants/2.0.0b0/ . note that this release restores protobuf support (thanks @witty-crayon-22786!)

❗ 1

👖 3

❤️ 2

plain-river-51682

09/17/2020, 8:42 AM

We currently have a bunch of bash files in our CI pipeline that get the list of targets to build (using

list, dependees, minimize, filter

). Is there a way to write a pants plugin that invokes these goals?

hundreds-father-404

09/17/2020, 7:08 PM

3 weeks later…`filter` is now documented 🙂 https://www.pantsbuild.org/docs/project-introspection#filter---find-targets-that-match-a-predicate

user

09/18/2020, 5:59 PM

https://twitter.com/HousingAnywhere/status/1301935554267951113 Pants Build retweeted: Our Data Scientist Duc Anh Bui, released a new article. In this article, Duc showed how Data Scientists can setup a… https://twitter.com/i/web/status/1301935554267951113 Twitter

billowy-motherboard-58443

09/21/2020, 2:19 PM

Question about BUILD files - while I'm grateful for the examples in the example repo, I can't find any definitive documentation about where they are required, and what must be in them for $functionality to work In the process of testing a migration of a big library repo to be a monorepo (core + various other libs, no apps), I find that when invoking the

test

goal, code which runs fine with plain

pytest namespace/pkg/tests/

has trouble with resolving modules.

billowy-motherboard-58443

09/21/2020, 2:19 PM

tries to cook a more explicit example

billowy-motherboard-58443

09/21/2020, 2:22 PM

if I have

Copy code

ns/foo/
ns/bar/

as packages (ns == namespace)

👍 1

billowy-motherboard-58443

09/21/2020, 2:23 PM

each has a

tests

dir underneath

aloof-angle-91616

09/21/2020, 2:24 PM

(did you see this comment? https://pantsbuild.slack.com/archives/C046T6T9U/p1600698023006200?thread_ts=1600697955.005600&cid=C046T6T9U)

billowy-motherboard-58443

09/21/2020, 2:24 PM

in ns/foo/tests/BUILD we have something like

Copy code

python_tests(
    name = "tests",
    dependencies = [
        ns/bar",
    ]
)

👍 1

billowy-motherboard-58443

09/21/2020, 2:24 PM

yes, I did, but I don't think it answers my Q, unless I'm a poor reader (could be)

👍 1

aloof-angle-91616

09/21/2020, 2:25 PM

no that's great thank you please continue

billowy-motherboard-58443

09/21/2020, 2:25 PM

so, code which gets loaded in say, ns/foo/tests/test_something.py will try to do

from ns.bar.baz import xxx

billowy-motherboard-58443

09/21/2020, 2:26 PM

that fails, while code doing only one level deep, e.g.

from ns.bar import yyy

works fine

billowy-motherboard-58443

09/21/2020, 2:26 PM

the failure mesage will look like

billowy-motherboard-58443

09/21/2020, 2:27 PM

Copy code

ImportError while importing test module '/tmp/process-executionTdDU86/ns/foo/tests/test_object_input.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
gh/util/tests/test_object_input.py:8: in <module>
    from ns.bar.common.model.security.claim import Claim
E   ModuleNotFoundError: No module named 'ns.bar.common'

billowy-motherboard-58443

09/21/2020, 2:27 PM

Suggestions?