pantsbuild #general

Channels

welcome

github-notifications

announce

fresh-architect-74417

03/10/2020, 6:43 PM

Thanks for checking on me ^_^

happy-kitchen-89482

03/10/2020, 6:52 PM

Ah I see

happy-kitchen-89482

03/10/2020, 6:52 PM

yes, that message needs improving

witty-crayon-22786

03/10/2020, 7:07 PM

@fresh-architect-74417: that should be fixed in more recent versions of pants

👍 1

witty-crayon-22786

03/10/2020, 7:08 PM

was fixed in

1.23.0.dev0

: https://www.pantsbuild.org/notes-master.html#heading_dev_195 https://github.com/pantsbuild/pants/pull/8422

early-needle-54791

03/10/2020, 8:46 PM

How do I run the black formatting goal it looks like fmt2 was removed?

Copy code

❯ ./pants fmt2 src/python/pants/cache/
Unknown goals: fmt2
Use `./pants goals` to list goals.
Use `./pants help` to get help.

hundreds-father-404

03/10/2020, 8:48 PM

Renamed to

fmt

hundreds-father-404

03/10/2020, 8:49 PM

Internally for Pants repo, you can run

./v2 fmt

./pants --v2 fmt

fresh-architect-74417

03/10/2020, 9:44 PM

Thanks, will try it out.

fancy-queen-20734

03/10/2020, 11:59 PM

might it be worth documenting in an issue in case someone else hits it and googles?

wide-energy-11069

03/11/2020, 12:22 AM

might be easier to add an assertion for python version >=3.6.8? or whatever the minimal version is

fancy-queen-20734

03/11/2020, 12:22 AM

that sounds good to me!

hundreds-father-404

03/11/2020, 12:25 AM

That seems a little wrong to me to stick that check into our codebase and run it every single time someone runs Pants, especially because 3.6.1 is so outdated. I think an issue would make more sense, but won’t block of course

wide-energy-11069

03/11/2020, 12:28 AM

checked with our internal prod version python 3.6.4, it works fine. so yeah, not blocking

👍 1

calm-artist-46894

03/11/2020, 1:27 AM

Quick question: will pants (1.26.0rc1) be impacted by the installed version of

pip

and

setuptools

from local system? (I am helping a college to debug build failure remotely and the error message suggest it is pip and setuptool related)

enough-analyst-54434

03/11/2020, 4:48 PM

I've got a proposal to remove support for python interpreter constraint ORing posted to pants-devel: https://groups.google.com/d/topic/pants-devel/CsqySLux1io/discussion The tracking issue is https://github.com/pantsbuild/pants/issues/9273 and I'd love feedback from folks who use the feature today.

🌈 2

🔥 2

fancy-queen-20734

03/11/2020, 7:01 PM

the pants.java.distribution.Distribution API is really awkward

fancy-queen-20734

03/11/2020, 7:02 PM

eg, you can’t inspect an instance of a distribution that doesn’t match the min/max versions because all the public methods include checks against them

enough-analyst-54434

03/11/2020, 7:08 PM

The API is pretty dang old, I think you have free license to fix.

💯 1

fancy-queen-20734

03/11/2020, 7:08 PM

fresh-architect-74417

03/12/2020, 6:04 PM

Hi all, I don't need zip_safe=False for open functions if the file is already included in the pex, right?

enough-analyst-54434

03/12/2020, 6:24 PM

The

open

builtin does not understand zipfile entries; so to access a file included in a PEX zipfile you'll need to use a resource API like

pkg_resources

from setuptools (https://setuptools.readthedocs.io/en/latest/pkg_resources.html#basic-resource-access). If you want to use

open

then you do need

zip_safe=False

fancy-queen-20734

03/12/2020, 6:38 PM

https://github.com/pantsbuild/pants/pull/9274 — changes jvm distribution lookup so that when looking at the cache the cache entries are sorted lowest first, rather than by dict.values() sorting, which may vary by python implementation.

fresh-architect-74417

03/12/2020, 6:40 PM

ok, thanks ^_^

fancy-queen-20734

03/13/2020, 1:40 AM

https://github.com/pantsbuild/pants/pull/9287 — adds strict as a platform attr so that platforms can be bounded.

red-balloon-89377

03/13/2020, 2:00 PM

Is there a quick and easy way to make unit testing in pants a bit faster? I’m trying to iterate on a change in

pants/python/pants_test/backend/project_info/export_dep_as_jar

, and it bootstraps a new pex every time, resulting in ~2min turnaround time for 30 python tests, when running

./v2 test pants/python/pants_test/backend/project_info:export_dep_as_jar

hundreds-father-404

03/13/2020, 2:15 PM

export NO_REGEN_PEX=true iirc. See the pants script for the exact env var

hundreds-breakfast-49010

03/13/2020, 6:47 PM

https://blog.rust-lang.org/2020/03/12/Rust-1.42.html#useful-line-numbers-in-option-and-result-panic-messages <- very excited about thsi

witty-crayon-22786

03/13/2020, 6:51 PM

anyone want to take a stab at the 1.41 update first? =x

hundreds-breakfast-49010

03/13/2020, 7:11 PM

was there anything particularly problematic about that upgrade?