#general
- h
happy-kitchen-89482
10/07/2019, 4:13 PMIt's as if someone crept into the garden in the night and painted the bike shed a different color. OK, it's not what I wanted, but it's not worth repainting it back...👌 1 - h
happy-kitchen-89482
10/07/2019, 4:14 PMAnd since Black's whole thing is that it's opinionated, I doubt they'd welcome such a change (although I remain surprised that this is their choice...) - a
aloof-angle-91616
10/07/2019, 4:14 PMok, but we have our own versions of tools all the time. if it's not a huge change and/or difficulty to maintain the fork, does that change the calculus? - h
hundreds-father-404
10/07/2019, 4:14 PMPainted it a different color, although at the same time installed an automatic bike lock system 😀 - h
happy-kitchen-89482
10/07/2019, 4:15 PMDunno, TBH - a
aloof-angle-91616
10/07/2019, 4:15 PMi'll put up a prototype - h
happy-kitchen-89482
10/07/2019, 4:15 PMI will set my IDE to 4 spaces instead of 2, and probably forget all about it within a week. - h
happy-kitchen-89482
10/07/2019, 4:15 PMUp to you, but I'm not sure that's worth the work. Might as well embrace our new formatting overlords. - a
aloof-angle-91616
10/07/2019, 4:18 PMunless 4 space indent is slated to be a requirement for later python versions, or there's further tooling support for 4 spaces instead of 2, i don't think this change is specifically warranted just because this single tool happens to have made a choice which is very easy to revert. - h
happy-kitchen-89482
10/07/2019, 4:39 PMOK so the instructions for dealing with the black merge conflicts are not working for me. There appear to be major issues around docstring indentation.hfw- 4
- 10
- h
happy-kitchen-89482
10/07/2019, 4:42 PMIt's not just docstrings but also triple-quoted strings in general.hf- 3
- 3
- h
hundreds-father-404
10/07/2019, 4:48 PMPython community is converging around Black, and consequently, four spaces. Pytest, Django, Tox, attrs, SQLAlchemy, Pipenv, Virtualenv, and CPython’s dataclasses module all use it now. Not to mention PEP8 has always called for four spaces That, of course, does not mean we must do what the greater community does, but worth acknowledging the direction of the greater ecosystem - a
aloof-angle-91616
10/07/2019, 4:50 PMthat sounds like great content for a discussion involving @enough-analyst-54434, @happy-kitchen-89482, and relevant stakeholders at twitter regarding the recent formatting changes in which we get explicit sign-off from pants contributors by using pants-devel. - h
happy-kitchen-89482
10/07/2019, 4:53 PMI think we have a bigger problem, around black's apparent inability to handle triple-quoted strings correctly. - a
aloof-angle-91616
10/07/2019, 4:54 PMthat's not super good - h
hundreds-father-404
10/07/2019, 4:54 PM@happy-kitchen-89482 that is a known issue with docstrings that Pierre is working to fix! They don’t touch docstrings, so the indentation stayed the same - a
aloof-angle-91616
10/07/2019, 4:55 PMshould we have fixed the issue before formatting the whole repo? - h
hundreds-father-404
10/07/2019, 4:55 PMThere’s an autoformatter for docstrings that Pierre is going to put a PR to fix - h
happy-kitchen-89482
10/07/2019, 4:55 PMA known issue is still an issue... Right now it is preventing me from resolving merge conflicts, as running black requires running pants, which requires the source to not be broken... - h
happy-kitchen-89482
10/07/2019, 4:56 PMPierre's rebasing instructions don't work for this reason. - h
happy-kitchen-89482
10/07/2019, 4:56 PMAlso, that autoformatter only solves the problem for docstrings, not for other uses of triple-quoted strings, which we have many of, e.g., in tests. - h
hundreds-father-404
10/07/2019, 4:57 PMHm it’s broken for triple strings in general? That would indeed be a major problem, although would be surprised given how widely used the tool is - h
happy-kitchen-89482
10/07/2019, 4:58 PMYep, as far as I can tell. - a
aloof-angle-91616
10/07/2019, 4:58 PMit might be because we had an entire large codebase formatted with two spaces and moved it to 4 in a single pass, not sure if that's typical - h
hundreds-father-404
10/07/2019, 4:59 PM@aloof-angle-91616 Django did the same thing - a
aloof-angle-91616
10/07/2019, 4:59 PMespecially if it doesn't touch triple quoted strings at all, which were also written with 2 spaces in mind - a
aloof-angle-91616
10/07/2019, 4:59 PMdid django have a discussion about it on their mailing list beforehand? - a
aloof-angle-91616
10/07/2019, 5:12 PMblack can be run with 2 spaces, and i've posted an example of what that might look like here: https://github.com/pantsbuild/pants/pull/8408. would love to re-open the discussion on this especially since it may be breaking triple-quoted strings. - h
happy-kitchen-89482
10/07/2019, 5:16 PMHmmm, interesting. - a
aloof-angle-91616
10/07/2019, 5:17 PMi'll try rebasing an old PR i have and seeing if i experience any issues with the directions