https://pantsbuild.org/ logo
Powered by
#general
  • a

    aloof-angle-91616

    08/13/2019, 11:23 PM
    looking through it to see if i solved this or not
  • a

    aloof-angle-91616

    08/13/2019, 11:24 PM
    it looks like i did not
  • a

    aloof-angle-91616

    08/13/2019, 11:25 PM
    i think it is a bug that it doesn’t work. is your work currently in a PR?
  • h

    hundreds-breakfast-49010

    08/13/2019, 11:26 PM
  • a

    aloof-angle-91616

    08/13/2019, 11:28 PM
    thanks!
  • h

    hundreds-breakfast-49010

    08/13/2019, 11:29 PM
    chatting with benjy, I was able to make the test work by passing in an 
    args
    parameter to the call to 
    assert_console_output
    👍 1
  • a

    aloof-angle-91616

    08/13/2019, 11:30 PM
    ok, does that work around setting option values or solve it (as in, is there still something to fix)?
  • h

    hundreds-breakfast-49010

    08/13/2019, 11:31 PM
    it does seem to set option values in a way that works, but benjy suggested it wasn't ideal
  • h

    hundreds-breakfast-49010

    08/13/2019, 11:32 PM
    I'm not sure what way we want to be able to set options in these sorts of tests
  • h

    hundreds-breakfast-49010

    08/13/2019, 11:32 PM
    it's not obvious to me personally that calling 
    set_options_for_scope
    is the right way
    a
    h
    w
    • 4
    • 31
  • h

    hundreds-breakfast-49010

    08/14/2019, 6:38 PM
    how does the 
    type_checked
    tag that the mypy.py script that runs as part of the commit hooks work?
  • h

    hundreds-breakfast-49010

    08/14/2019, 6:38 PM
    I assume somehow we're tagging some but not all python source files to get typechecked by that script
    ☝️ 1
    g
    w
    • 3
    • 28
  • h

    hundreds-breakfast-49010

    08/14/2019, 8:37 PM
    what's the correct way to get 
    context.target_roots
    in a v2 rule?
    a
    w
    • 3
    • 32
  • a

    aloof-angle-91616

    08/14/2019, 9:11 PM
    ^ for anyone interested in v2 rules, the answer to the above question is kinda cool: https://pantsbuild.slack.com/archives/C046T6T9U/p1565817025113200?thread_ts=1565815021.108500&cid=C046T6T9U
  • h

    hundreds-breakfast-49010

    08/15/2019, 12:21 AM
    is there a reason why a lot of pants code that expects a variable number of arguments
  • h

    hundreds-breakfast-49010

    08/15/2019, 12:21 AM
    asks for a tuple rather than a list?
  • h

    hundreds-breakfast-49010

    08/15/2019, 12:21 AM
    doesn't python have a maximum tuple size?
  • w

    witty-crayon-22786

    08/15/2019, 12:32 AM
    it does not
  • w

    witty-crayon-22786

    08/15/2019, 12:32 AM
    they're basically interchangeable, except that tuple is immutable
  • w

    witty-crayon-22786

    08/15/2019, 12:33 AM
    and immutability is a very helpful thing in a system that does caching (and can't otherwise control mutation as in rust)
  • h

    hundreds-breakfast-49010

    08/15/2019, 12:38 AM
    ah that makes sense
  • f

    fierce-park-88503

    08/15/2019, 2:30 PM
    how do you write a pants plugin that uses 3rdparty deps? my plugin seems to work w/ just loose source files w/o a BUILD file, but then I can’t declare that I need to use any 3rdparty deps. When I try to add a BUILD file it doesn’t seem to help, but I can’t tell if pants is even looking at that BUILD file
  • h

    happy-kitchen-89482

    08/15/2019, 10:49 PM
    It's non-intuitive, and we will have to fix this, but for now the way to do this is to specify the 3rdparty deps in your 
    plugins: []
    list in pants.ini
  • h

    happy-kitchen-89482

    08/15/2019, 10:49 PM
    E.g.,
  • h

    happy-kitchen-89482

    08/15/2019, 10:50 PM
    Copy code
    plugins: [
    # External plugins.
    'pantsbuild.pants.contrib.awslambda-python==%(pants_version)s',
    'pantsbuild.pants.contrib.codeanalysis==%(pants_version)s',
    'pantsbuild.pants.contrib.go==%(pants_version)s',
    'pantsbuild.pants.contrib.mypy==%(pants_version)s',
    'pantsbuild.pants.contrib.node==%(pants_version)s',
    'pantsbuild.pants.contrib.python.checks==%(pants_version)s',

    # 3rdparty deps of in-repo, loose source plugins.
    'boto3==1.9.194',
    'isort==4.3.21',
    'pkginfo==1.5.0.1',
    'plyvel==1.1.0',
    'protobuf==3.9.0',
    'setuptools==40.6.3',
  ]
    🙏 1
  • h

    happy-kitchen-89482

    08/15/2019, 10:51 PM
    cc @fierce-park-88503 ^
  • e

    echoing-alligator-60945

    08/19/2019, 12:50 AM
    Hey everyone, Satwik here, I'm a junior at UIUC, l my internship at Twitter ended last friday but I hope to keep contributing to the pants community via open source channels, I was working on the Apache thrift NodeJs support for pants and hope to refine it further so we can get it merged, #8101
    👋 1
    h
    h
    w
    • 4
    • 5
  • e

    echoing-alligator-60945

    08/19/2019, 12:52 AM
    @aloof-angle-91616 Hello hello.
    ❤️ 4
  • a

    aloof-angle-91616

    08/19/2019, 12:53 AM
    hello friend!!!
    ❤️ 3
  • b

    brave-policeman-49804

    08/21/2019, 12:35 PM
    hey, I am trying to deploy the pex as a lambda function. I followed the pants docs and used 
    python_awslambda
    and generated the pex file. then I used lambdex test to test my pex file and it works but when I deploy this pex file as zip to the aws lambda service it gives me the error when testing that 
    "Unable to import module 'lambdex_handler': No module named 'lambdex_handler'"
    Any idea what's happening?
1...211821192120...2420Latest