pantsbuild #general

Channels

welcome

github-notifications

announce

witty-crayon-22786

08/01/2019, 3:58 PM

you will in general want to keep caches in CI, yea.

proud-yak-54773

08/01/2019, 6:51 PM

mostly i was wondering about the files in (buildroot)/.cache i am not seeing any speedup in my builds whether those files are there or blown away.

proud-yak-54773

08/01/2019, 7:59 PM

actually, digging around a bit more, it looks like this is exactly what i’m asking about: https://github.com/pantsbuild/pants/blob/master/pants.cache.ini from this, i’m assuming the local artifact cache shouldn’t be cached for CI purposes?

jolly-whale-64112

08/01/2019, 8:39 PM

I’m working with pants generated cobertura coverage reports for python tests. When I take a look at the report, the package names will sometimes follow a standard syntax of

com.foo.bar.blah

, but a good portion of the time I’ll receive something much less readable, like

.Users.foo.bar..pants.d.pyprep.sources.e3ffed3b0fe5ff4d0f6f9dd42ca3cd26cecb0788.blah

. Does anyone know why that is, or how I can get names that are a bit more consistent and readable?

fresh-architect-74417

08/02/2019, 9:32 PM

Hi team: How do I tell which build target has a dependency cycle? I'm getting the following error:

Copy code

timestamp: 2019-08-02T21:31:29.994167
Exception caught: (pants.build_graph.address_lookup_error.AddressLookupError) (backtrace omitted)
Exception message: Build graph construction failed: ExecutionError 1 Exception encountered:
  Exception: Dep graph contained a cycle.

witty-crayon-22786

08/02/2019, 9:36 PM

pass

--print-exception-stacktrace

... sorry for the trouble. that's https://github.com/pantsbuild/pants/issues/5739

fresh-architect-74417

08/02/2019, 9:37 PM

Thanks lot ❤️

happy-kitchen-89482

08/05/2019, 3:08 PM

Is this a known spurious ci error: https://travis-ci.org/pantsbuild/pants/jobs/567426836 ?

happy-kitchen-89482

08/05/2019, 3:08 PM

Copy code

Unexpected problem writing target jar /home/travis/build/pantsbuild/pants/.pants.d/tmp/tmpj30kqeem.pants.d/bootstrap/bootstrap-jvm-tools/tool_cache/binary_jars/com.google.errorprone.ErrorProneCompiler-66a2181907f9e0c278dee8c5ad66ef2af8817878-ShadedToolFingerprintStrategy_3c828f4d38a9.jar: org.pantsbuild.tools.jar.JarBuilder$IndexingException: Problem indexing jar at /home/travis/build/pantsbuild/pants/.pants.d/tmp/tmpj30kqeem.pants.d/bootstrap/bootstrap-jvm-tools/a0ebe8e0b001/ivy/jars/com.google.errorprone/error_prone_core/jars/error_prone_core-2.3.1.jar: error in opening zip file

aloof-angle-91616

08/05/2019, 3:09 PM

the incremental caching test i have seen flake before but only once or twice, not sure if it was that exact error

happy-kitchen-89482

08/05/2019, 3:09 PM

This seems consistent

happy-kitchen-89482

08/05/2019, 3:14 PM

But doesn't reproduce locally

happy-kitchen-89482

08/05/2019, 3:14 PM

I might have to murder some caches

fierce-park-88503

08/05/2019, 3:14 PM

Is there a way to disable individual pythonstyle checks? We want to start using

black

, but some of its choices go against some of the checks

dazzling-diamond-4749

08/06/2019, 2:46 AM

Does anyone know of any plan to specify Golang deps but in

pip-compile

style and let pants pin the deps?

dry-policeman-7927

08/07/2019, 11:03 AM

Hello good people! This is a nice python profiler written in Rust https://github.com/benfred/py-spy I was using it to investigate why thrift encoding in py_zipkin is slow.

witty-crayon-22786

08/09/2019, 7:22 PM

for posterity: further discussion of the above will be in the #infra room

wide-energy-11069

08/09/2019, 9:21 PM

https://pantsbuild.slack.com/archives/C18RRR4JK/p1565384543042800

average-cpu-49873

08/12/2019, 6:04 PM

Let me know if there's a better channel to post this question. If I were wanting to use a different version of yarn package manager, how would I point Pants to use a binary hosted at an endpoint such as

<https://github.com/yarnpkg/yarn/releases/download/<version>/yarn-<version>.tar.gz>

, where the

<version>

is specified in the Pants options like so?

Copy code

binaries_baseurls: +[
    '<https://binaries.pantsbuild.org>',
    '<https://github.com/yarnpkg/yarn/releases/download>',
  ]

[yarnpkg-distribution]
version: v1.17.3

The root of the issue is that Pants is expecting a specific folder structure

<https://github.com/yarnpkg/yarn/releases/download/bin/yarnpkg/mac/10.13/v1.17.3/yarnpkg.tar.gz>

, and I'm wondering if there is a way to circumvent that.

hundreds-breakfast-49010

08/13/2019, 6:31 PM

hey all, I'm running into a problem running the lint command in the pre-commit hook (namely,

./pants --exclude-target-regexp='testprojects/.*' --changed-parent="master" lint

)

hundreds-breakfast-49010

08/13/2019, 6:32 PM

on my system, on a clean master, I'm hitting the following error:

Copy code

Traceback (most recent call last):
                       File "/home/gregs/code/pants/.pants.d/lint/pythonstyle/checker/f056857f828f95f73143d5abef284733401993e1-DefaultFingerprintStrategy.946276fa33a5/CPython-3.7.3/.bootstrap/pex/pex.py", line 356, in execute
                         self.patch_sys(pex_inherit_path)
                       File "/home/gregs/code/pants/.pants.d/lint/pythonstyle/checker/f056857f828f95f73143d5abef284733401993e1-DefaultFingerprintStrategy.946276fa33a5/CPython-3.7.3/.bootstrap/pex/pex.py", line 285, in patch_sys
                         new_sys_path, new_sys_path_importer_cache, new_sys_modules = self.minimum_sys(inherit_path)
                       File "/home/gregs/code/pants/.pants.d/lint/pythonstyle/checker/f056857f828f95f73143d5abef284733401993e1-DefaultFingerprintStrategy.946276fa33a5/CPython-3.7.3/.bootstrap/pex/pex.py", line 259, in minimum_sys
                         sys_modules = cls.minimum_sys_modules(site_libs)
                       File "/home/gregs/code/pants/.pants.d/lint/pythonstyle/checker/f056857f828f95f73143d5abef284733401993e1-DefaultFingerprintStrategy.946276fa33a5/CPython-3.7.3/.bootstrap/pex/pex.py", line 179, in minimum_sys_modules
                         if cls._tainted_path(module_file, site_libs):
                       File "/home/gregs/code/pants/.pants.d/lint/pythonstyle/checker/f056857f828f95f73143d5abef284733401993e1-DefaultFingerprintStrategy.946276fa33a5/CPython-3.7.3/.bootstrap/pex/pex.py", line 157, in _tainted_path
                         paths = frozenset([path, os.path.realpath(path)])
                       File "/home/gregs/code/pants/build-support/pants_dev_deps.py37.venv/lib/python3.7/posixpath.py", line 394, in realpath
                         filename = os.fspath(filename)
                     TypeError: expected str, bytes or os.PathLike object, not NoneType
                     
FAILURE: 1 Python Style issues found. You may try `./pants fmt <targets>`

hundreds-breakfast-49010

08/13/2019, 8:50 PM

it looks like

build-support/pants_dev_deps.py37.venv

isn't in version control and it has symlinks to system python files

hundreds-breakfast-49010

08/13/2019, 8:50 PM

but why is something trying to run python linting against it?

hundreds-breakfast-49010

08/13/2019, 8:50 PM

this also comes up when I run unreltaed tests

hundreds-breakfast-49010

08/13/2019, 11:18 PM

unrelated question: it seems like

set_options_for_scope

doesn't actually work when testing v2 rules

hundreds-breakfast-49010

08/13/2019, 11:18 PM

is it supposed to (and it's a bug that it doesn't), or is this not actually the way that we want to provide mock options to rule tests going forwards?

hundreds-breakfast-49010

08/13/2019, 11:20 PM

or at least, it doesn't work for testing v2 console rules, since the relevant test method is

ConsoleRuleTestBase.execute_rule

aloof-angle-91616

08/13/2019, 11:23 PM

i think that’s supposed to work and that it doesn’t. i’ve had a redo of a v1 task in v2 lying around for a bit that also ran into this issue, let me find it

hundreds-breakfast-49010

08/13/2019, 11:23 PM

aloof-angle-91616

08/13/2019, 11:23 PM

https://github.com/pantsbuild/pants/pull/7419