pantsbuild #general

Channels

welcome

github-notifications

announce

hundreds-breakfast-49010

07/15/2019, 9:03 PM

"The command "./build-support/bin/ci.py --githooks --sanity-checks --doc-gen --lint" exited with 1."

brief-engineer-67497

07/16/2019, 8:19 AM

Hi is there a way to have a resource prepared before some targets and clean up afterwards ? the use case is our integration tests. Before each suite we start progammatically a docker and stop it afterwards. It take ages. A quick win would be to use one docker for all suite. However we would like to have it drove by pants. I can see how to do a start before all : have a task inheriting from junit_test requiring an artifact provided by the task that start the docker. but how to stop it at the end ? we cannot use the same trick because if tests fails, the docker won't be stopped …

fancy-motherboard-24956

07/16/2019, 12:37 PM

Hi all, I joined Twitter yesterday, to work on pants. Could I be added as a contributor to the project? My GitHub handle is pierrechevalier83 😄

nutritious-guitar-44515

07/18/2019, 12:50 PM

Has anyone used pants to build a python app that has a dependency on a java jar or lib? And is this a bad idea or are there existing patterns? It seems that pants will not complain if i add a jvm dependency into my python_library's BUILD file, and it will even compile the java dependency in the event of a pants run invocation on the python app. BUT then the python app doesnt have access to the right classpath (that i guess is dynamically generated by pants?).

echoing-manchester-70122

07/18/2019, 6:31 PM

Hi all. I'm trying to write a python pants plugin that produces a .tar.gz file but I'm having some issues getting my targets to build

echoing-manchester-70122

07/18/2019, 6:32 PM

The only time anything happens is if I register a task with the 'binary' goal. If I do that, my code executes

echoing-manchester-70122

07/18/2019, 6:32 PM

But if I just have the target in the BUILD file and have it listed in build_file_aliases(), it doesn't build

echoing-manchester-70122

07/18/2019, 6:32 PM

It doesn't show up in the list of targets at all

echoing-manchester-70122

07/18/2019, 6:33 PM

Am I missing a mixin class or something? Right now I'm just using class Task and class Target

echoing-manchester-70122

07/18/2019, 6:33 PM

I looked at the verst docker plugin and it doesn't seem like he does anything special to register his targets

echoing-manchester-70122

07/18/2019, 6:33 PM

other than adding a couple fields

aloof-angle-91616

07/18/2019, 6:35 PM

have you seen the task developer's guide yet? https://www.pantsbuild.org/dev_tasks.html

echoing-manchester-70122

07/18/2019, 9:17 PM

ok I have managed to figure out how to get results_dir created and have created an artifact within that.

echoing-manchester-70122

07/18/2019, 9:17 PM

but the artifact doesn't get moved to my dist/ directory after the build is complete

echoing-manchester-70122

07/18/2019, 9:34 PM

nvm I guess that needs to be done manually..

hundreds-breakfast-49010

07/20/2019, 12:18 AM

one random thing I've noticed is that when you run

./pants goals

the last one printed is

validate

with no description

hundreds-breakfast-49010

07/20/2019, 12:19 AM

looking at https://github.com/pantsbuild/pants/blob/master/src/python/pants/help/help_printer.py#L49 where this is done

hundreds-breakfast-49010

07/20/2019, 12:19 AM

it looks like

validate

is coming from that

known_scope_to_info

for-loop (which doesn't check for a null description)

hundreds-breakfast-49010

07/20/2019, 12:20 AM

rather than the

goal_descriptions.update

line, which does

hundreds-breakfast-49010

07/20/2019, 12:20 AM

is this intentional or a bug?

enough-analyst-54434

07/20/2019, 8:38 AM

Probably a bug, although

validate

is the only v2 goal in that list and the UI for v2 is not fully worked out.

hundreds-breakfast-49010

07/22/2019, 6:50 PM

isn't

list

also a v2 goal? it's defined with

console_rule

list_targets.py

, right?

hundreds-breakfast-49010

07/22/2019, 6:50 PM

(in general is there a quick way to tell whether a goal in that list is v1 or v2, without finding exactly where it's implemented in code?)

hundreds-breakfast-49010

07/22/2019, 6:51 PM

anyway, either way, it should have a description to be rendered there, right?

./pants goals

shouldn't care wehther the engine is v1 or v2?

hundreds-breakfast-49010

07/22/2019, 6:52 PM

I wonder if it would be helpful for

./pants goals

to print the source file where that goal is implemented (maybe with a special

--debug

flag?)

👍 2

hundreds-breakfast-49010

07/22/2019, 11:05 PM

anyone have any idea why: https://travis-ci.org/pantsbuild/pants/jobs/562266429 might be failing? when I run

./pants test tests/python/pants_test/backend/graph_info/tasks:list_targets

locally it passes on that code

hundreds-breakfast-49010

07/23/2019, 6:44 PM

I'd like to call

goals_by_version

Options

_print_goals_help

HelpPrinter

hundreds-breakfast-49010

07/23/2019, 6:44 PM

right now this is returning three empty tuples, like the

Options

hasn't been initialized yet with the goals

hundreds-breakfast-49010

07/23/2019, 6:45 PM

but that same method is already calling

Goals.all()

, so something is aware of goals already

hundreds-breakfast-49010

07/23/2019, 6:45 PM

I'm not sure if I should figure out how to initialize the goals that

Options

is aware of earlier so I can use that method, or reimplement the functionality to look for goals by version on the

Goal

class