pantsbuild #general

Channels

welcome

github-notifications

announce

acoustic-book-58772

05/22/2019, 6:30 PM

so both the one in

[binary]

and under

[DEFAULT]

yeah?

aloof-angle-91616

05/22/2019, 6:30 PM

yes!

aloof-angle-91616

05/22/2019, 6:32 PM

if you've removed it and made sure the env var isn't set (or explicitly call

unset PANTS_BINARIES_PATH_BY_ID

), and it continues to fail, then adding

binaries_path_by_id: {('darwin', '18'): ('mac', '10.14')}

[GLOBAL]

should solve the problem -- but i would ask you to make an issue if you can with any repro info you have at hand, since this is supposed to be fixed. it's possible we could do something more complex to detect if the option is being overridden, but it's not clear what the right behavior would necessarily be there

acoustic-book-58772

05/22/2019, 6:36 PM

Hmmm I see, will see how that goes. For additional information, here's the output to the options:

Copy code

binaries_path_by_id = {(u’darwin’, u'18'): (u’mac’, u'10.14')} (from CONFIG in pants.ini)

aloof-angle-91616

05/22/2019, 6:36 PM

ah, ok, thank you

aloof-angle-91616

05/22/2019, 6:37 PM

also make sure the mac version corresponds to your osx version, but i assumed you are on osx 10.14?

acoustic-book-58772

05/22/2019, 6:41 PM

Yeah we are on 10.14, just double checked

acoustic-book-58772

05/22/2019, 6:45 PM

Just kidding. Turns out the problem was developer hasn't updated the repo in more than a year 'cause he usually works on a different project, and was still on

1.4

derp. Really should have done all the fundamental checks first my bad.

👍 1

acoustic-book-58772

05/22/2019, 6:45 PM

This is why all the tech support operators go through all those checks when you call them....

happy-kitchen-89482

05/22/2019, 9:09 PM

I just saw this symlink fail in our CI: https://github.com/pantsbuild/pants/blob/0bc0178a54ae4610c92ee8bcd45c77abdab48dfe/src/python/pants/backend/jvm/subsystems/zinc.py#L217

happy-kitchen-89482

05/22/2019, 9:09 PM

This seems impossible, given the lock and the check

happy-kitchen-89482

05/22/2019, 9:10 PM

Context is upgrading from JDK8 to JDK11, but that shouldn't be an issue given the lock and the check...

aloof-angle-91616

05/22/2019, 9:10 PM

i'm very impressed and glad it was working for so long on

1.4

though!

happy-kitchen-89482

05/22/2019, 9:10 PM

Any thoughts?

aloof-angle-91616

05/22/2019, 9:10 PM

restarting always seems to help me personally

🔥 1

aloof-angle-91616

05/22/2019, 9:10 PM

thanks for diving in and figuring it out! this sort of investigation is still useful to us

happy-kitchen-89482

05/22/2019, 9:13 PM

Oh, I got it.

os.path.exists

on a symlink returns false if the thing it links to (in our case the old JDK) is gone.

happy-kitchen-89482

05/22/2019, 9:14 PM

but the broken link still exists

aloof-angle-91616

05/22/2019, 9:28 PM

that's a little annoying -- is there a way to say "does this file show up in `ls`", or is the idiomatic way to specifically check for symlinks?

late-article-56753

05/23/2019, 12:19 PM

Hello, on our CI server sometimes we got following exception:

Copy code

timestamp: 2019-05-22T09:05:16.435110
Exception caught: (pants.invalidation.cache_manager.IllegalResultsDir) (backtrace omitted)
Exception message:
The results_dirs state should not be manually cleaned or recreated by tasks.

The current_results_dir directory was not found
       * /home/bamboo/git/r9/.pants.d/compile/zinc/a53b6931478d/nucleus.java.com.r9.nucleus.commons.memoization.memoization/1cd408ba5a91

pants_version: 1.14.0rc3

actualy

/nucleus.java.com.r9.nucleus.commons.memoization.memoization/current

points to

1cd408ba5a91

and this does not exits. I did not find anything on our system what could delete that directory. Maybe some known behaviour?

little-action-42934

05/23/2019, 5:12 PM

Copy code

error[E0034]: multiple applicable items in scope

little-action-42934

05/23/2019, 5:13 PM

i’m getting some rustc errors when running

./pants setup-py src/python/pants:pants-packaged

little-action-42934

05/23/2019, 5:13 PM

Copy code

error[E0034]: multiple applicable items in scope
   --> /Users/allan/.cache/pants/rust-toolchain/registry/src/github.com-1ecc6299db9ec823/petgraph-0.4.4/src/graph.rs:489:17
    |
489 |         assert!(Ix::max().index() == !0 || NodeIndex::end() != node_idx);
    |                 ^^^^^^^ multiple `max` found
    |
note: candidate #1 is defined in the trait `graph_impl::IndexType`
   --> /Users/allan/.cache/pants/rust-toolchain/registry/src/github.com-1ecc6299db9ec823/petgraph-0.4.4/src/graph.rs:47:5
    |
47  |     fn max() -> Self;
    |     ^^^^^^^^^^^^^^^^^
    = help: to disambiguate the method call, write `graph_impl::IndexType::max(...)` instead
note: candidate #2 is defined in the trait `std::cmp::Ord`
    = help: to disambiguate the method call, write `std::cmp::Ord::max(...)` instead

error[E0034]: multiple applicable items in scope
   --> /Users/allan/.cache/pants/rust-toolchain/registry/src/github.com-1ecc6299db9ec823/petgraph-0.4.4/src/graph.rs:526:17
    |
526 |         assert!(Ix::max().index() == !0 || EdgeIndex::end() != edge_idx);
    |                 ^^^^^^^ multiple `max` found
    |
note: candidate #1 is defined in the trait `graph_impl::IndexType`
   --> /Users/allan/.cache/pants/rust-toolchain/registry/src/github.com-1ecc6299db9ec823/petgraph-0.4.4/src/graph.rs:47:5
    |
47  |     fn max() -> Self;
    |     ^^^^^^^^^^^^^^^^^
    = help: to disambiguate the method call, write `graph_impl::IndexType::max(...)` instead
note: candidate #2 is defined in the trait `std::cmp::Ord`
    = help: to disambiguate the method call, write `std::cmp::Ord::max(...)` instead

error: aborting due to 2 previous errors

little-action-42934

05/23/2019, 5:14 PM

is there a way to pin the version of rust that pants uses

witty-crayon-22786

05/23/2019, 5:18 PM

@little-action-42934: we do pin it... how old is this working copy?

happy-kitchen-89482

05/23/2019, 5:18 PM

What's the right way to set java compiler flags now? What with

Zinc argument '"+['-C-parameters']"' is not supported, and is subject to change/removal!

hundreds-father-404

05/23/2019, 5:21 PM

Cc @aloof-angle-91616 (I think)

witty-crayon-22786

05/23/2019, 5:29 PM

@happy-kitchen-89482: compiler_options_sets

witty-crayon-22786

05/23/2019, 5:30 PM

i think that the PR might still be the best documentation though, unfortunately: https://github.com/pantsbuild/pants/issues/5360

witty-crayon-22786

05/23/2019, 5:39 PM

the definitions of options are on

./pants help-advanced compile.zinc

and

./pants help-advanced java