It’s a review by Tejal that fixed the issue

I think @gorgeous-fish-11040 meant to tag @bored-art-40741 for that one

gotcha.. my followup was gonna be "what issue"? simple smile

sorry 😄

We are having a discussion on https://rbcommons.com/s/twitter/r/2677/ about how to plumb in configuration for the JDK paths and I thought I’d bring it here just to get on the same page.

The first patch looked like this to configure:

[jvm]
    jdk_paths: {
        'macos': [
          '/Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk',
          '/Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk',
        ],
        'linux': [
          '/usr/java/jdk1.7.0_80',
        ]
      }
   options:  [ ‘-Xmx300M’]

Now it looks like this:

[jvm-distribution]
    paths = {
        'macos': [
          '/Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk',
          '/Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk',
        ],
        'linux': [
          '/usr/java/jdk1.7.0_80',
        ]
      }
  [jvm]
  options : [ ‘-Xmx300M’]

To me, its very complicated to explain to users 1) Why is there a separate subsystem just to configure the jdk paths? 2) why the option:

—jvm-distribution-paths

not a part of the jvm subsystem?

its alot easier if the 2nd version plurailizes

the heading is a lie right now

I understand the pants plubing issues, but the point of options is to make things usable for end users.

its N different jdks - 6,7,8,9

and clearly jvm options may only applyt to 1

To be clear, I am a fanboy of the version on top.

I think the verion on top lies

The version on bottom less so

[jvm-distributions]

Is about all avaiable distributions

A given one will get a set of jvm options applied, that's the snd bit

Explain to me why don’t we have a

[jvm-options]

subsystem then.

we do

thats the platforms thing?

One thing - jvm-distributions is global, you define 1 set

whereas jvm:options is meant to be local

you can define a global to default from, but its a set of options for a given task subscope more normally

so they really should be seperate beastss

The only reason to define a global jvm:options is to cap the standard Xmx ?

I see your point, we do have a separate

[jvm-platforms]

subsystem, but that is not the one I was talking about.

It seems to me the stuff we are putting in

[jvm-platforms]

and

[jvm-distributions]

is related. I guess the ‘jvm’ subsystem is one that is meant to be inherited by all tasks and these other are intended to be global settings.

I totally agree with that last stuff