https://pantsbuild.org/ logo
Powered by
#general
  • f

    fresh-architect-74417

    02/28/2019, 9:07 PM
    I'm caching all the test results. It's hard to know which one was cached, and which was rebuilt.
  • f

    fresh-architect-74417

    02/28/2019, 9:07 PM
    At Google, they print (cached) next to the success message.
  • f

    fresh-architect-74417

    02/28/2019, 9:07 PM
    I can send PR for that.
    👍 1
  • a

    acoustic-book-58772

    02/28/2019, 10:24 PM
    follow up on the 
    --no-fast
    thing: is that flag or something similar available for 
    compile
    as well? (I didn't seem to find them with a quick 
    ./pants compile --help | grep 'fast'
    We did recently run into a problem where mixing targets produced different results than running separately when we're compiling changed targets, and as a result had to split them all up and run in a loop.
    w
    • 2
    • 3
  • w

    wide-energy-11069

    02/28/2019, 11:20 PM
    The difference largely stems from third party resolve, and currently we cannot do that per target yet
  • w

    wide-energy-11069

    02/28/2019, 11:21 PM
    as a result had to split them all up and run in a loop.
    Sounds like the right approach
    👍 1
  • w

    witty-crayon-22786

    02/28/2019, 11:47 PM
    and yea, what Yi said is right. 
    --no-fast
    only affects the test runners themselves.
  • a

    acoustic-book-58772

    02/28/2019, 11:50 PM
    Sounds good. Thanks!
  • w

    witty-crayon-22786

    02/28/2019, 11:51 PM
    there are sketches of plans for solving this for both python and the JVM... python will see solutions mid-year, but we hope to tackle the JVM later this year.
  • w

    witty-crayon-22786

    02/28/2019, 11:52 PM
    (related to the v2 engine, in particular.)
  • b

    brief-engineer-67497

    03/01/2019, 12:52 PM
    Hello, has someone already ran in a similar issue ? :
    Copy code
    ## Exception when compiling 44 sources to /data/var/lib/jenkins/workspace/pr-mediarithmics-platform-pants/.pants.d/compile/zinc/a53b6931478d/mediarithmics-api.core-api.src.test.scala.scala/current/classes
                       [error] java.io.IOException: Analysis at (1bf5f43a12d32f19b8a21e7b38f4e306: /data/var/lib/jenkins/workspace/pr-mediarithmics-platform-pants/.pants.d/compile/zinc/a53b6931478d/mediarithmics-api.common-play-api.src.main.scala.scala/053bd30b9406/z.analysis) has changed since startup!
    Not sure where to start to solve it 😕
    w
    • 2
    • 2
  • b

    brief-engineer-67497

    03/01/2019, 1:00 PM
    the weird thing is that if I do 
    ./pants compile ::
    it works fine but then if I run this script :
    Copy code
    #!/usr/bin/env bash

set -eEux

function clean_pants() {
	./pants ng-killall
}

trap clean_pants ERR

remote=${1:-"origin"}
changedParent="${remote}/${2:-"master"}"

# Disable Zinc incremental compilation to ensure no historical cruft pollutes the current build.
export PANTS_COMPILE_ZINC_INCREMENTAL=false


changed=$(./pants --changed-parent=${changedParent} list)
dependees=$(./pants dependees --dependees-transitive --dependees-closed ${changed})
filtered=$(mktemp)
./pants filter --filter-type=junit_tests \
               --filter-tag-regex=-integration,test-dev,suite-by-suite ${dependees} | sort > ${filtered}

for target in $(cat ${filtered}); do
  ./pants test.junit --output-mode=ALL --no-fast --parallel-threads=12 ${target} 
done

./pants filter --filter-type=junit_tests \
               --filter-tag-regex=suite-by-suite ${dependees} | sort > ${filtered}

for target in $(cat ${filtered}); do
    ./build-support/test-scripts/test-suite-by-suite.sh ${target%:*}
done

rm ${filtered}
    I run into the problem
  • b

    brief-engineer-67497

    03/01/2019, 1:01 PM
    where test-suite-by-suite is the following :
    Copy code
    #!/usr/bin/env bash

set -eEux

dir=$1

suites=$(find ${dir} \
        -name "*Spec.scala" -printf "%P\n" -or \
        -name "*Test.scala" -printf "%P\n" | sed -r 's@/@.@g ; s/\.scala$//g')

for s in $suites; do
    ./pants test.junit --test=$s --output-mode=ALL ${dir}
done
  • w

    wide-energy-11069

    03/01/2019, 5:45 PM
    is there a good way to do 
    +
    and 
    -
    at the same time in pants.ini? E.g.
    Copy code
    backend_packages: +[
    "pants.backend.docgen",
]
    but then I also want to remove one of default plugins
  • h

    happy-kitchen-89482

    03/01/2019, 6:25 PM
    I think you can separate them with a comma
    🔥 3
  • h

    happy-kitchen-89482

    03/01/2019, 6:25 PM
    Yep
  • h

    happy-kitchen-89482

    03/01/2019, 6:25 PM
    Our pants.ini has:
  • h

    happy-kitchen-89482

    03/01/2019, 6:25 PM
    Copy code
    backend_packages: +['toolchain.pants'],-[
                    'pants.backend.codegen.antlr.java',
                    'pants.backend.codegen.antlr.python',
                    'pants.backend.codegen.jaxb',
                    'pants.backend.codegen.protobuf.java',
                    'pants.backend.codegen.ragel.java',
                    'pants.backend.codegen.thrift.java',
                    'pants.backend.codegen.thrift.python',
                    'pants.backend.codegen.wire.java']
  • w

    wide-energy-11069

    03/01/2019, 7:20 PM
    oh neat. thanks!
  • w

    witty-crayon-22786

    03/01/2019, 7:36 PM
    but note https://github.com/pantsbuild/pants/issues/5230 (maybe not relevant here)
    • 1
    • 1
  • b

    busy-car-23170

    03/04/2019, 10:06 PM
    Hey all, I'm spending some time trying to update Pants at my company (it's become an annual-ish event for me), and am hitting this error while moving from 1.7.0 -> 1.8.0.
    Copy code
    [shade-zinc]
==== stderr ====
Exception in thread "main" java.util.zip.ZipException: invalid entry size (expected 526140 but got 0 bytes)
    I noticed this PR went into 1.8.0, which initially smells correlated: https://github.com/pantsbuild/pants/pull/5953 we do have a 3rdparty dependency on guava 20.0, is there more shading I should try and do? Can also provide more stacktrace/debug details in a gist. Thanks in advance!
    w
    • 2
    • 15
  • b

    brief-engineer-67497

    03/05/2019, 3:45 PM
    is there a plugin to build a docker image ? It seems I don't find anything on the subject
  • b

    brief-engineer-67497

    03/05/2019, 3:45 PM
    or rather my search give me docker images of pants >_<
  • b

    brief-engineer-67497

    03/05/2019, 4:13 PM
  • h

    happy-kitchen-89482

    03/05/2019, 8:59 PM
    Am I imagining it, or is there a generic way to have an option's value point to a file to read the actual value from?
  • h

    happy-kitchen-89482

    03/05/2019, 9:01 PM
    Ah yes, 
    fromfile=True
  • a

    acoustic-book-58772

    03/06/2019, 12:05 AM
    Hello, a few things: 1) Yesterday we ran into a problem where a transitive dependency upgrade dropped python 2 support and broke our stuff, similar to the issue we had with 
    pytest
    and 
    more-itertools
    . In this case it was with 
    tornado
    . We ended up making the affected target "depend" on 
    tornado
    while pinning 
    tornado
    in our requirements file to an older version. Is there a better way to deal with this?
    h
    • 2
    • 2
  • a

    acoustic-book-58772

    03/06/2019, 12:06 AM
    2) we seem to be running into https://github.com/pantsbuild/pants/issues/6861 a bit lately too. Are there any updates on how to deal with that? We've just been rerunning the thing.
  • p

    purple-microphone-26575

    03/06/2019, 6:33 AM
    @happy-kitchen-89482 You mentioned you’re using Pants for a Django application. I’m looking into one that’s run using mod_wsgi. I see there has been some work in the 
    pex
    project about embedding uwsgi in the generated pex file, is this what you’re doing for the Django project?
  • h

    hundreds-father-404

    03/06/2019, 2:03 PM
    Oof, I personally wasn’t aware this is hitting actual users. Others might have already known though. I don’t think we have a solution yet, and the best workaround for now is to re-run the command as you’re doing. Please comment on that issue noting that this is hitting you all. It would be helpful to mention things like how frequently it’s been happening, if you noticed it happening more recently than before, if certain commands seem more problematic, etc. Thanks!
1...209921002101...2420Latest