https://gist.github.com/nitay/79f9ec8298d8bb55a3e2b77b3bfd7588 has anyone seen this before? am trying to upgrade our pants from 1.7 to 1.9, guessing I’m missing some option or carrying around some old thing that I shouldnt be, but not clear where problem is

have you tried running a

clean-all

? i think what happens here is that if the zip file is corrupted or interrupted when we try to write it a previous time, then the zip library (and most compression utilities, for some reason) will try to open up the file and edit it instead of overwriting it. this may be better perf-wise? and this is also a wild guess regardless, but if it is correct then a

clean-all

(which should delete that file) should fix it

in general, we recommend upgrading one version at a time (e.g. 1.7 -> 1.8 -> 1.9) (which i know is annoying advice, and may not be relevant here if you're already doing that)

i believe we have a slightly different version of coursier on the dropbox (built with the pants BUILD files in the coursier repo i think?) @wide-energy-11069 would know the specific difference

# 3rdparty/jvm/io/get-coursier/BUILD

jar_library(name='coursier-dep',
  jars=[
    jar(org='io.get-coursier', name='coursier-cli_2.12', rev='1.1.0-M8'),
  ],
)

jvm_binary(
    name='coursier-bin',
    main='coursier.cli.Coursier',
    dependencies=[
        ':coursier-dep',
    ])

jvm_app(
    name='coursier',
    binary=':coursier-bin',
)

./pants bundle 3rdparty/jvm/io/get-coursier:coursier

just for future reference @brief-engineer-67497 you can use

scala_jar(org='io.get-coursier', name='coursier-cli', rev='1.1.0-M8')

which avoids the

_2.12

(it uses the scala version you're using)

i can't believe this isn't on the docsite lol

(making a PR)

k lemme try those things

thx @aloof-angle-91616 for the tip, but in this precise case I did not want it to be bind to my scala version

just in case

pants is using an older version right now https://github.com/pantsbuild/pants/commit/33c85286fdc0c57045d264e50b6ecf555be118dd

we need to vet the newer versions internally before actually bumping it

@famous-holiday-38439 afaict the standalone jar, can you verify it has

$ unzip -l coursier-cli_2.12-1.1.0-M8-standalone.jar | grep Coursier
warning [coursier-cli_2.12-1.1.0-M8-standalone.jar]:  55 extra bytes at beginning or within zipfile
  (attempting to process anyway)
      209  10-24-2018 10:28   coursier/cli/Coursier.class

The standalone one is proguarded, so the classnames are gibberish. How are you using it?

ok i did clean-all, and am trying just 1.8 now, still getting same thing above

we used it as the value for

bootstrap_jar_url

that's the reason why we created a fat jar and uploaded it somewhere. However not using an "official" link was really disapproved by our ops. After some digging the problem comes from nailgun so

[resolve.coursier]
execution_strategy=subprocess

let us use

<https://oss.sonatype.org/content/repositories/releases/io/get-coursier/coursier-cli_2.12/1.1.0-M8/coursier-cli_2.12-1.1.0-M8-standalone.jar>

https://github.com/coursier/coursier/releases/download/pants_release_1.5.x/coursier-cli-1.1.0.cf365ea27a710d5f09db1f0a6feee129aa1fc417.jarshould be official enough right? @brief-engineer-67497

i haven’t tried

coursier-cli_2.12-1.1.0-M8-standalone.jar

yet, but will do in a bit

thx ^_^

actually the coursier sonatype address is also "official" enough

https://github.com/lgirault/coursier-fatjar/blob/master/coursier-cli-1.1.0-M8.jar?raw=true was not

😛

ok. so are you unblocked?

we are ! thank you

I just added the info to let you know about the

execution_strategy=subprocess

trick

seems like the thing that messes the jar is this bit : https://github.com/coursier/coursier/blob/84727d8883007cbd3abb25a3707841c5b4391e26/project/ZipUtil.scala#L77

are you saying

coursier-cli_2.12-1.1.0-M8-standalone.jar

works with subprocess but fails with nailgun?

well, messes the jar as far nailgun is concerned