pantsbuild #general

i have a post it on my monitor of flaky tests but it might be useful to use a github milestone or something to track tickets with flaky tests? thinking out loud

wide-energy-11069

11/16/2018, 6:45 AM

the run id issue only shows up for

tests/python/pants_test/backend/jvm/tasks:jar_publish_integration

for some reason, but I’m not sure what’s so special about these tests

wide-energy-11069

11/16/2018, 6:51 AM

Copy code

# Select a globally unique ID for the run, that sorts by time.
    millis = int((self._run_timestamp * 1000) % 1000)
    run_id = 'pants_run_{}_{}_{}'.format(
      time.strftime('%Y_%m_%d_%H_%M_%S', time.localtime(self._run_timestamp)),
      millis,
      uuid.uuid4().hex
    )

wide-energy-11069

11/16/2018, 6:52 AM

so runs had to have the same timestamp and uuid…and those are all integration tests with obvious gaps between runs. how’s that possible?

wide-energy-11069

11/16/2018, 7:16 AM

seems to be passing now, argh..

brief-engineer-67497

11/16/2018, 9:51 AM

Hi, I'm having trouble to undersand how the argument

classpath_spec

of the method

register_jvm_tool

of the class

JvmToolMixin

works. in pants codebas I often see

//:foo

even if there is no target foo in the

BUILD

file in the same directory of the declaration. Btw, how is the

//

intrepreted ?

brief-engineer-67497

11/16/2018, 9:53 AM

I tried to dig in the code but

classpath_spec

is passed to the

register

and I'm not clear on the nature of this function

brief-engineer-67497

11/16/2018, 10:02 AM

More specifically my use case is the following. I have this directory structure in my repo.

Copy code

pants-plugin
      python
          foo
              targets
                  foo_library.py
              tasks
                  foo_gen.py
              register.py
      scala
          foo-cli
              Foo.scala
              BUILD

foo_gen.py

, there is

Copy code

cls.register_jvm_tool(register, 'foo-cli',
                              classpath=[
                                  JarDependency(org='bar',
                                                name='foo-cli',
                                                rev='0.0.1-SNAPSHOT'),
                              ],
                              classpath_spec='//pants-plugins/scala/foo-cli'
                              )

and in

scala/foo-cli/BUILD

Copy code

java_library(
    sources = rglobs('*.scala'),
    dependencies = [
        '3rdparty/jvm/some/dependency'
        ],
    provides = artifact(org='bar',
                        name='foo-cli',
                        repo=snapshots)
    )

When I run my task I still get a

ClassNotFoundException

from my third party dependency. (I'm sure that

foo-cli

is correctly published with a pom listing the 3rd party dependencies and that the foo-cli jar used is fetched from the nexus repository). Do you see how to fix this ?

average-vr-56795

11/16/2018, 2:19 PM

People who know nailgun… I’m starting a nailgun server in an empty dir, and running things using the C nailgun client in another dir. The executions are failing because files can’t be found, and if I copy the files into the nailgun dir, things work. The C client definitely passes through the working dir config. Is this likely to be a bug in nailgun or a bug in the server being nailgun’d?

enough-analyst-54434

11/16/2018, 2:41 PM

This is the whole nail vs main. Since nailgun server is java and multithreaded - one thread to service each requests - it cannot set env vars or chdir transparently it can only tell a nail these facts.

average-vr-56795

11/16/2018, 2:43 PM

ok, so odds are I need to dependency inject the cwd into code being nailgun’d, and maybe make a

nailMain

for it?

enough-analyst-54434

11/16/2018, 2:43 PM

http://www.martiansoftware.com/nailgun/doc/javadoc/com/martiansoftware/nailgun/NGContext.html

enough-analyst-54434

11/16/2018, 2:44 PM

You need to write a Nail instead of a main - a Nail gets the linked NGContext passed to it

enough-analyst-54434

11/16/2018, 2:44 PM

Basically - the java code to run has to know about nailgun the minute you need env vars or cwd.

average-vr-56795

11/16/2018, 2:44 PM

Cool 🙂 Thanks

average-vr-56795

11/16/2018, 2:44 PM

Any strong objections to doing so for the pants zinc wrapper?

enough-analyst-54434

11/16/2018, 2:45 PM

Not at all

average-vr-56795

11/16/2018, 2:45 PM

Yay I get to write scala!

average-vr-56795

11/16/2018, 2:45 PM

(People shouldn’t let me write scala)

❤️ 3

😂 4

red-balloon-89377

11/16/2018, 5:02 PM

How bad would it be to tamper with the “walk transitive dependency graph” function? In particular, I want to add optional prelude and epilogue to the traversal, functions that get called right before expanding children, and right after. Context for this is implementing Dependency Banning, and the propagation of banning constraints through dependencies, and the desire not to make it n^2

silly-refrigerator-91543

11/17/2018, 8:04 AM

Anyone know if global scalac plugins are broken? I have a very simple case where I just want a global plugin, so per the documentation I have

Copy code

jar_library(
    name = 'scalac-plugin-dep',
    jars = [
        scala_jar('org.spire-math', 'kind-projector', '0.9.7'),
    ],
)

in my BUILD.tools. (I'm using 1.11.0rc1.) Unfortunately it seems to have no effect whatsoever. FWIW, if I 'misdeclare' the dependency, e.g. by misspelling the group name (org.spire-math) is does result in resolution errors, so it's at least going through ivy resolution. It just doesn't seem to have any effect on compilation and I get compilation errors where none would be expected. (I have a fully working SBT build, so I know for a fact that the code all compiles). (Aside: Would scalac plugins be expected to work with the pants IDEA plugin and/or project generation? If not then the above question is irrelevant 🙂 )

silly-refrigerator-91543

11/17/2018, 8:20 AM

Oh, yes, and I've tried the alternative apporach (from the doc) by adding have a differently named jar_library target and adding a

scalac_plugins

in the

[compile.zinc]

section in the

pants.ini

file, but that approach complains that there's no such option. EDIT: Any help debugging this (e.g. flags I can use to show the compiler options actually being used, etc.) would be greatly appreciated.

aloof-angle-91616

11/18/2018, 6:29 AM

Mikhail Filipchuk -- i can't find your username, but i spoke to you at Scale by the Bay. i made an issue about a remote buildcache implementation: https://github.com/pantsbuild/pants/issues/6788.

❤️ 1

brief-engineer-67497

11/19/2018, 4:18 PM

hi, do you know if anybody uses pants to build jvm projects using aspectj ?

wide-energy-11069

11/19/2018, 7:05 PM

Currently prepping for 1.12.0rc0, so would appreciate hold off landing, or if you have commits that want to get in before the cuts, please let me know know as well. https://github.com/pantsbuild/pants/pull/6791

witty-crayon-22786

11/19/2018, 7:34 PM

@wide-energy-11069: i'd love to get in https://github.com/pantsbuild/pants/pull/6790 ... but i should be able to cherry-pick it if need be. i have at least one more CI run, so probably best not to wait.

wide-energy-11069

11/19/2018, 7:35 PM

cool. as long as it can be cherry picked 🙂