https://pantsbuild.org/ logo
Powered by
#general
  • b

    brainy-answer-80371

    08/25/2018, 12:55 AM
    Anyone out there with an example of integrating a django project with pants? I’m having difficulties getting the 
    python_tests
    target working
  • b

    brainy-answer-80371

    08/25/2018, 1:31 AM
    Found the cause of my issues. python_tests seems to behave differently based on where the BUILD file is. https://github.com/pantsbuild/pants/issues/6398
  • h

    happy-kitchen-89482

    08/25/2018, 1:41 AM
    We’ve got several Django projects in a pants codebase
  • h

    happy-kitchen-89482

    08/25/2018, 1:43 AM
    Ah, but sounds like this isn’t a Django issue
  • h

    happy-kitchen-89482

    08/25/2018, 2:10 AM
    @hundreds-father-404 I successfully got that shard to not use a cache, but it’s still failing
  • h

    happy-kitchen-89482

    08/25/2018, 2:11 AM
    You’ll have to sort that out with the #engine folks I guess?
  • h

    happy-kitchen-89482

    08/25/2018, 2:12 AM
    Hmm, it’s nothing to do with your change, since it’s failing the release as well
  • h

    hundreds-father-404

    08/25/2018, 2:14 AM
    Yeah that shard was consistently passing before today
  • a

    adamant-quill-79654

    08/27/2018, 8:52 PM
    hello, can I add some json file to 
    python_libilary
    and open it. Lib which I work on should provide interface for this data.
  • a

    adamant-quill-79654

    08/27/2018, 8:53 PM
    i find this: https://www.pantsbuild.org/resources.html but i do not know how to use it together 😕
  • h

    happy-kitchen-89482

    08/27/2018, 11:57 PM
    You add the json file as a 
    source
    to a 
    resources
    target, and have the python target depend on it. Then you can load the json file from the PYTHONPATH using pkg_resources
  • h

    happy-kitchen-89482

    08/27/2018, 11:58 PM
    E.g., 
    json.loads(pkg_resources.resource_string('my.pkg.path', 'myfile.json'))
  • h

    happy-kitchen-89482

    08/27/2018, 11:58 PM
    where the BUILD file is something like
  • h

    happy-kitchen-89482

    08/27/2018, 11:59 PM
    Copy code
    python_library(
  dependencies = [
    ':myfiles',
    '3rdparty/python:setuptools`
  ]
)

resources(
  name = 'myfiles',
  sources = globs(*.json')
)
    👍 2
    a
    • 2
    • 2
  • e

    enough-analyst-54434

    08/28/2018, 12:02 AM
    NB: pkg_resources comes from 
    setuptools
    , so you'll want a dependency on that.
  • h

    happy-kitchen-89482

    08/28/2018, 12:04 AM
    Ah yes, added
  • h

    happy-kitchen-89482

    08/28/2018, 12:06 AM
    Of course this means you have 
    setuptools
    in your 
    3rdparty/python/BUILD
    (or in a 
    requirements.txt
    in that dir, if the BUILD file has 
    python_requirements()
    in it)
  • h

    happy-kitchen-89482

    08/28/2018, 12:06 AM
    And you can enumerate the files if you prefer: 
    sources = ['myfile.json', 'myotherfile.json']
    .
  • h

    high-advantage-47550

    08/28/2018, 4:59 PM
    hi! i'm trying to add support for another jvm language via a plugin (to pants 1.2.x). I'm able to get the sources to compile, and they end up in 
    .pants.d/compile
    , but when I add the library as a dependency, the generated classes don't end up on the classpath. I minimally extended 
    JvmCompile
    for this -- is there some mechanism I'm missing that defines how the classpath should change?
  • w

    witty-crayon-22786

    08/28/2018, 5:01 PM
    1.2 is almost two years old now, so i wouldn't recommend adding language support there...
  • h

    high-advantage-47550

    08/28/2018, 5:01 PM
    although, hmm, it's not registering in any sense, because if I delete the compiled sources and try to compile the dependee target, the original isn't compiled or registered as a target
  • h

    high-advantage-47550

    08/28/2018, 5:02 PM
    fair point 😁
  • w

    witty-crayon-22786

    08/28/2018, 6:21 PM
    would be happy to answer questions in the context of a more recent version though!
    👍 1
    h
    • 2
    • 6
  • f

    fierce-park-88503

    08/29/2018, 2:41 PM
    should the changed subsystem (v 1.7) be able to detect a change to the version of a python library in a requirements.txt file? (from a 
    python_requirements()
    target)
  • f

    fierce-park-88503

    08/29/2018, 2:43 PM
    (some quick experimentation seems to point to “no”, but maybe I’m holding it wrong?)
  • e

    enough-analyst-54434

    08/29/2018, 2:44 PM
  • e

    enough-analyst-54434

    08/29/2018, 2:45 PM
    This was just fixed yesterday on master - will be out Friday in 1.10.0.dev5 and it's being cherry-picked to 1.9.x and - maybe 1.8.x
  • f

    fierce-park-88503

    08/29/2018, 2:51 PM
    wow, coincidence lol. ok, sg.
  • e

    enough-analyst-54434

    08/29/2018, 2:51 PM
    Looks like it was cherry-picked to both 1.8.x and 1.9.x so there will be a release of each of those stable branches at some point that has the fix too.
    w
    • 2
    • 1
  • f

    fierce-park-88503

    08/29/2018, 6:35 PM
    follow up, since I don’t totally follow the fix in that PR: does this mean that a change to anything in the requirements file will invalidate the file itself, and thus all deps in that file will be marked as changed? or will it be scoped down to just the requirements that actually changed?
1...205820592060...2420Latest