https://pantsbuild.org/ logo
Powered by
#general
  • r

    rough-minister-58256

    08/19/2015, 11:07 PM
    bet benjy knows
  • a

    adventurous-twilight-44110

    08/19/2015, 11:08 PM
    @happy-kitchen-89482: does any of this ring a bell? invalid options prefixed with 
    --jvm-
    don’t raise errors
  • f

    fancy-queen-20734

    08/19/2015, 11:08 PM
    my guess would be that the subsystem de-scoping code ignores scopes that it doesn’t know
  • f

    fancy-queen-20734

    08/19/2015, 11:09 PM
    so those flags just get round binned
  • a

    adventurous-twilight-44110

    08/19/2015, 11:09 PM
    doesn’t seem to be the case for the 
    thrift-defaults
    subsystem: 
    ./pants compile --thrift-defaults-fdjksjdep examples/src/java/org/pantsbuild/example/hello/main
  • h

    happy-kitchen-89482

    08/19/2015, 11:09 PM
    the de-scoping code only looks at scopes it knows
  • h

    happy-kitchen-89482

    08/19/2015, 11:10 PM
    if it doesn't see a scope prefix it treats the entire thing as the option name
  • h

    happy-kitchen-89482

    08/19/2015, 11:10 PM
    so I'm not sure what that's about
  • h

    happy-kitchen-89482

    08/19/2015, 11:10 PM
    But I'm elbow deep in that code right now for other reasons, so I'll take a look
  • a

    adventurous-twilight-44110

    08/19/2015, 11:11 PM
    thanks!
  • r

    rough-minister-58256

    08/19/2015, 11:45 PM
    is there some implicit benefit to having the RunTracker dangle off BuildGraph.run_tracker? I don’t see how thats getting used.
  • r

    rough-minister-58256

    08/19/2015, 11:45 PM
    was planning to excise that in support of serialization but wanted to make sure I’m not missing anything
  • e

    enough-analyst-54434

    08/20/2015, 1:11 AM
    It's unused and can be killed, ditto on BuildFileParser
  • e

    enough-analyst-54434

    08/20/2015, 1:11 AM
    refactor cruft
  • r

    rough-minister-58256

    08/20/2015, 1:19 AM
    sweet!
  • r

    rough-minister-58256

    08/20/2015, 1:20 AM
    did some GoalRunner refactoring and threw it in there, will get an RB out
  • h

    happy-kitchen-89482

    08/20/2015, 1:30 AM
    urg
  • h

    happy-kitchen-89482

    08/20/2015, 1:30 AM
    I have a pending change that touches GoalRunner also
  • h

    happy-kitchen-89482

    08/20/2015, 1:31 AM
    the part that gathers subsystem dependencies
  • r

    rough-minister-58256

    08/20/2015, 1:54 AM
    ah, heh
  • r

    rough-minister-58256

    08/20/2015, 1:55 AM
    how pending we talking here
  • h

    happy-kitchen-89482

    08/20/2015, 1:57 AM
    it's done, just dealing with a test breakage
  • r

    rough-minister-58256

    08/20/2015, 1:58 AM
    ah, 2029 nice
  • r

    rough-minister-58256

    08/20/2015, 1:58 AM
    you beat me by one - 2030
  • h

    happy-kitchen-89482

    08/20/2015, 1:58 AM
    it's not a huge impact
  • h

    happy-kitchen-89482

    08/20/2015, 1:58 AM
    but might be better to get it in before yours
  • r

    rough-minister-58256

    08/20/2015, 1:58 AM
    ah cool
  • h

    happy-kitchen-89482

    08/20/2015, 1:59 AM
    as yours will be the more disruptive change
  • r

    rough-minister-58256

    08/20/2015, 1:59 AM
    sgtm
  • h

    happy-kitchen-89482

    08/20/2015, 1:59 AM
    Yeah, the diff on goal_runner.py is very minor
1...196197198...2420Latest