#general
- a
astonishing-jelly-60479
08/19/2015, 7:29 PMi mostly agree but do like jumping to definitions in libraries - b
bored-art-40741
08/19/2015, 7:30 PMWhy would it error? - b
bored-art-40741
08/19/2015, 7:30 PMTwo different aliases can point to the same target type - e
enough-analyst-54434
08/19/2015, 7:30 PMIt would error or only allow 1 alias - e
enough-analyst-54434
08/19/2015, 7:30 PMat any rate it will be unambiguous what the alias maps to - e
enough-analyst-54434
08/19/2015, 7:30 PMby the time we're parsing BUILDs - b
bored-art-40741
08/19/2015, 7:30 PMWe use this for backward compatible transitions from an old target type to a new one, where the alias doesn't change - e
enough-analyst-54434
08/19/2015, 7:31 PMIf I guess right @jolly-chef-92794 is asking about this in the context of macros - b
bored-art-40741
08/19/2015, 7:31 PMIt's unambiguous what the alias maps to, it's not unambiguous what a given target instance was defined using - e
enough-analyst-54434
08/19/2015, 7:31 PMRIght now a macro has to call parse_context.create_object(<I know my own alias and I should not need to>, ...) - b
bored-art-40741
08/19/2015, 7:31 PMAh, if there's more context then maybe you can. I was only working with the question he asked - e
enough-analyst-54434
08/19/2015, 7:34 PMGotcha - the idea would be either the ParseContext would know the mapping and could turn a concrete TargetType -> alias or the alias itself would be embedded in targets in a property or else made queryable through the address mapper which might just hang on to it via parse context feedback - b
bored-art-40741
08/19/2015, 7:35 PMFinding it through the address mapper seems most plausible - j
jolly-chef-92794
08/19/2015, 7:35 PMI was actually asking not in reference to macros; I’m just working on a patch which involves users passing the names of targets in an option, and it’d be nicer if users could use ‘java_library’ instead of ‘JavaLibrary' - b
bored-art-40741
08/19/2015, 7:35 PMI can see how it would be preserved there without otherwise messing up the interfaces - e
enough-analyst-54434
08/19/2015, 7:35 PMyeah - ParseContext direct only works for macros - b
bored-art-40741
08/19/2015, 7:36 PM@jolly-chef-92794: In that case it's impossible to do in the general case, perhaps with the exception that you might be able to look it up from an AddressMapper - b
bored-art-40741
08/19/2015, 7:36 PMI forget if it hangs on to that information though - e
enough-analyst-54434
08/19/2015, 7:37 PMIt doesn't its in the ParseContext only right now - e
enough-analyst-54434
08/19/2015, 7:37 PMSorry - j
jolly-chef-92794
08/19/2015, 7:37 PMIs there a way, given a Target object, to tell if it maps to a particular alias? - e
enough-analyst-54434
08/19/2015, 7:37 PMBuildCOnfiguration - which creates the ParseContext - e
enough-analyst-54434
08/19/2015, 7:37 PMno - not today - e
enough-analyst-54434
08/19/2015, 7:37 PMwe discussed this on an RB, issue filed from that is here: - e
enough-analyst-54434
08/19/2015, 7:39 PMum... I may be imaginging creating an issue - just a sec - e
enough-analyst-54434
08/19/2015, 7:43 PMI guess I made this all up - I could've sworn though that we had this conversation on a review Garrett - e
enough-analyst-54434
08/19/2015, 7:43 PMDoes not exist - please create it! - e
enough-analyst-54434
08/19/2015, 7:44 PM@witty-crayon-22786: I'll need you to add me and all others to pantsbuild.pants.contrib.go - w
witty-crayon-22786
08/19/2015, 8:00 PM@enough-analyst-54434: - w
witty-crayon-22786
08/19/2015, 8:00 PMok