https://pantsbuild.org/ logo
Powered by
#general
  • a

    average-vr-56795

    12/05/2017, 6:27 PM
    There are three levels of problem here... 1: Why is the fmt.isort command invoking code unrelated to formatting? 2: Why are they broken? At a glance, I think the latter two are because we changed the default jdk target... 3: How are we meant to find out that they're broken on CI when they break, rather than because I happen to touch a BUILD file?
  • w

    witty-crayon-22786

    12/05/2017, 6:30 PM
    `1: Why is the fmt.isort command invoking code unrelated to formatting?`: when 
    fmt.*
    is invoked, all of the tasks in the 
    fmt
    goal run... yes, non-intuitive
  • w

    witty-crayon-22786

    12/05/2017, 6:30 PM
    2: ...
    good question, worth a bug
  • w

    witty-crayon-22786

    12/05/2017, 6:31 PM
    3: ...
    depends on 2
  • a

    average-vr-56795

    12/05/2017, 6:31 PM
    The code failing for the latter two cases is around target JDK mismatches, which I would be surprised if they were part of a fmt task...
  • a

    average-vr-56795

    12/05/2017, 6:32 PM
    And the first case is invoking antlr before failing, which again is surprising for fmt to be invoking...
  • w

    witty-crayon-22786

    12/05/2017, 6:32 PM
    @average-vr-56795: hm... they fail in travis, or on your laptop?
  • a

    average-vr-56795

    12/05/2017, 6:32 PM
    On my laptop
  • a

    average-vr-56795

    12/05/2017, 6:32 PM
    Haven't tried on travis, but I can do 🙂
  • w

    witty-crayon-22786

    12/05/2017, 6:32 PM
    worth trying. it's possible that they don't properly skip themselves if a sufficient number of JDKs aren't present
  • b

    busy-car-23170

    12/05/2017, 7:05 PM
    Hey there, I'm trying to upgrade to pants 1.3.0 and started getting python test failures when trying to read from a configuration file, looks like it's due to pyprep not including the file. When I add the file to the 
    sources
    glob, 
    pytest
    is unable to find the file. What's the best way to go about having my conf file be visible to the tests?
  • w

    witty-crayon-22786

    12/05/2017, 7:06 PM
    @busy-car-23170: you should declare a dependency on a 
    resources
    target that captures the config.
  • b

    busy-car-23170

    12/05/2017, 7:08 PM
    Perfect! Thanks @witty-crayon-22786
  • b

    busy-car-23170

    12/05/2017, 9:23 PM
    Hi again, I previously had the 
    scalastyle
    task installed on the 
    compile
    goal, but now it's installed on the 
    lint
    goal by default. This is causing an exception: 
    An option with this name was already registered on this scope. [option --jvm-options in scope compile.scalastyle]
    . I can remove 
    scalastyle
    from 
    compile
    , but then it no longer runs on compile which is not desirable. How can I remove 
    scalastyle
    from the 
    lint
    goal so that the previous functionality is maintained?
  • w

    witty-crayon-22786

    12/05/2017, 9:31 PM
    @busy-car-23170: 
    Goal.by_name('lint').uninstall_task('scalastyle')
  • b

    busy-car-23170

    12/05/2017, 9:32 PM
    Hmm I already tried that and I'm still getting the same error
  • b

    busy-car-23170

    12/05/2017, 9:32 PM
    I'll try refreshing the cache
  • a

    aloof-angle-91616

    12/05/2017, 9:32 PM
    why would installing it on the 
    lint
    goal cause that error message? sounds like it might be getting registered for 
    compile
    twice?
  • a

    aloof-angle-91616

    12/05/2017, 9:32 PM
    i could be completely wrong
  • w

    witty-crayon-22786

    12/05/2017, 9:32 PM
    @aloof-angle-91616: because it has a deprecated option scope
  • a

    aloof-angle-91616

    12/05/2017, 9:32 PM
    ah
  • w

    witty-crayon-22786

    12/05/2017, 9:33 PM
    so the options get installed both places
  • a

    aloof-angle-91616

    12/05/2017, 9:33 PM
    i actually was just looking at that code
  • w

    witty-crayon-22786

    12/05/2017, 9:33 PM
    @aloof-angle-91616: not a good thing to pull into your current review, but: would be awesome if the deprecated scope was just ignored if it collided
  • w

    witty-crayon-22786

    12/05/2017, 9:33 PM
    anywho
  • a

    aloof-angle-91616

    12/05/2017, 9:33 PM
    noted
  • b

    busy-car-23170

    12/05/2017, 9:34 PM
    Fresh cache, same error, here's the 
    register.py
    code:
    Copy code
    def register_goals():
    Goal.by_name('lint').uninstall_task('scalastyle')
    task(name='scalastyle', action=Scalastyle).install('compile', first=True)
  • b

    busy-car-23170

    12/05/2017, 9:34 PM
    I've been trying to tweak the installation flags as well
  • w

    witty-crayon-22786

    12/05/2017, 9:38 PM
    hm.
  • w

    witty-crayon-22786

    12/05/2017, 9:38 PM
    so... yea. i think that because of the deprecated scope, it is colliding with itself.
1...186318641865...2420Latest