pantsbuild #general

Channels

welcome

github-notifications

announce

straight-sandwich-38111

11/06/2017, 10:11 PM

So I took a look at adding Kotlin/Clojure support to pants on a lark. Am I correct in assessing that Pants defers JVM compilation almost entirely to zinc, and that unless such language library targets were added as pre-zinc codegen steps which happened to emit collections of classfiles (and thus couldn't depend mutually on Java or Scala code) this would require zinc support?

straight-sandwich-38111

11/06/2017, 10:15 PM

Yeah it looks like you'd want to hook into

pants.backend.jvm.tasks.jvm_compile.zinc.zinc_compile

, which assumes that you're injecting a plugin.

enough-analyst-54434

11/07/2017, 12:54 AM

@straight-sandwich-38111 yes. The state of the universe appears to be that each jvm-ecosystem language individually supports [lang]<->java mutual deps via that language's compiler, but there is no existing meta-compiler that can work across 3 or more jvm languages. As a historical artifact, due to scala's importance at Foursquare and Twitter, the priviledged compiler became Zinc, since the only supported JVM languages at those companies were java and scala.

enough-analyst-54434

11/07/2017, 12:56 AM

Pants could be smarter about all this and support graphs of code with strictly 2-lang cycles and fail fast for 3+ lang-cycles. But we're not in a position to support this yet.

enough-analyst-54434

11/07/2017, 1:08 AM

@bulky-motorcycle-41302 ACK: I'll try to formulate a useful PR review tomorrow. My gut concern is that your next steps should be the first steps. The thing that stopped me from saying this on review is I'm not sure whether or not a completion of next steps would obviate the PR's introduced option (flag). If it would, I'd be against the PR to prevent option-thrash.

straight-sandwich-38111

11/07/2017, 6:18 PM

@enough-analyst-54434 So after doing some more digging and thinking about this right now I think that's fine. Groovy, Kotlin and Clojure aren't designed to be built mutually with Java, unlike Scala. The existing ecosystems outside of pants are all designed for phased compilation where you build your Java (typically first) and then your $OTHERLANG which will link against the Java. It looks like it should be reasonable to add at least Clojure and Kotlin as compiler steps which just happen after zinc using the classpath generated by the zinc compile.

straight-sandwich-38111

11/07/2017, 6:19 PM

Doesn't look like there's a good way to emit a

jvm_class_library

synthetic product (directory tree of classfiles) short of emitting a full Jar which isn't super incremental friendly.

witty-crayon-22786

11/08/2017, 5:10 PM

@straight-sandwich-38111: the easy thing to do would be to allow any of those languages to depend on java/scala: you would just install your new task after zinc

flaky-twilight-29457

11/08/2017, 5:10 PM

I’ve got a small fix for the Git related issues the testsuite throws at me here: https://github.com/pantsbuild/pants/pull/5076 Can someone have a look?

witty-crayon-22786

11/08/2017, 5:11 PM

@straight-sandwich-38111 :having both, where java/scala can depend on language X, and vice versa, is not a thing that is easy in the current model. we're working on new model, but.

flaky-twilight-29457

11/08/2017, 5:11 PM

Also, I get 3 failed tests for JUnit/JVM related tests that look half-conclusive to me

witty-crayon-22786

11/08/2017, 5:12 PM

@flaky-twilight-29457: looking

witty-crayon-22786

11/08/2017, 5:13 PM

@enough-analyst-54434: if you have time, could you take a look at @bulky-motorcycle-41302’s https://github.com/pantsbuild/pants/pull/5050 ?

flaky-twilight-29457

11/08/2017, 5:13 PM

This somewhat prevents me to get the PR https://github.com/pantsbuild/pants/pull/4514/files for the custom shebangs uploaded. I’ve got a solution that works for the v2 pipeline, but I’d rather upload with a working testsuite\

witty-crayon-22786

11/08/2017, 5:13 PM

@flaky-twilight-29457: well, it doesn't prevent uploading it, right? you can have travis run the tests?

flaky-twilight-29457

11/08/2017, 5:13 PM

(My functional parts look reasonably functional)

witty-crayon-22786

11/08/2017, 5:14 PM

(back in an hour)

flaky-twilight-29457

11/08/2017, 5:14 PM

@witty-crayon-22786 sure, I can just upload it and ignore failing tests from other parts but….green pipelines 😉

flaky-twilight-29457

11/08/2017, 5:15 PM

Will do that if things are less obvious with those 3 failing tests, likely tomorrow as it’s dinner time soon…

flaky-twilight-29457

11/08/2017, 5:36 PM

@witty-crayon-22786 I’ve uploaded the addition for v2. There are a few superfluous commits that I’d squash for a final PR but the basic idea should be visible here: https://github.com/pantsbuild/pants/pull/4514/files#diff-f22b8ffaa810dd964cada9380eb0c388

enough-analyst-54434

11/08/2017, 7:12 PM

Yeah, will do. Wanted to yesterday.

witty-crayon-22786

11/08/2017, 11:57 PM

@enough-analyst-54434: thanks a lot for the

1.3.x

fixes... i'll do another 1.3.1 rc soon.

enough-analyst-54434

11/08/2017, 11:58 PM

Cool. You're release master Friday so I was figuring it'd go out then.

rough-dog-96241

11/09/2017, 8:36 PM

Is it expected that resources() targets specified as dependencies (not as resources=) should work? or should not work? (And which of those incantations is recommended?)

witty-crayon-22786

11/09/2017, 9:47 PM

@rough-dog-96241: in "modern" pants, yes.

witty-crayon-22786

11/09/2017, 9:48 PM

@rough-dog-96241 :if your version gives you a deprecation warning for the

resources=[..]

argument, then that will be your answer.

witty-crayon-22786

11/09/2017, 9:49 PM

if you do not get that warning, it's because you're on something older where putting them in the dependencies list will not always work.

rough-dog-96241

11/09/2017, 9:50 PM

@witty-crayon-22786 cool, thank you. We're on 1.2.1 probably upgrading soon.

witty-crayon-22786

11/09/2017, 9:54 PM

1.3.0 (soon 1.3.1) will be the first stable version that does what you're asking for

rough-dog-96241

11/09/2017, 10:08 PM

👍