pantsbuild #general

Channels

welcome

github-notifications

announce

witty-crayon-22786

10/02/2017, 6:57 PM

(or, that would be my concern. haven't read back through what Kris was suggesting)

bright-apartment-76721

10/02/2017, 6:57 PM

all I do is call

PythonInterpreter.from_binary(fixed_interpreter)

from the

execute

logic if that option is provided

bright-apartment-76721

10/02/2017, 6:57 PM

which is functionality from pex

bright-apartment-76721

10/02/2017, 6:57 PM

can throw up a PR if it sounds somewhat reasonable

bright-apartment-76721

10/02/2017, 7:12 PM

how's this? https://github.com/pantsbuild/pants/pull/4930

bright-apartment-76721

10/02/2017, 7:20 PM

not sure if I should make two separate PRs for master and the 1.3 branch or what

bright-apartment-76721

10/02/2017, 7:20 PM

or if it's even sensible to include in the 1.3 release or if it's going to have to wait for 1.4

witty-crayon-22786

10/02/2017, 7:21 PM

just one master PR, generally... if it needs to go to 1.3, it will be a cherry pick. and if it's challenging to cherry-pick, then it might not be a good candidate to backport =/

bright-apartment-76721

10/02/2017, 7:22 PM

I think it's a trivial cherrypick, but I'll rebase onto master instead

bright-apartment-76721

10/02/2017, 7:23 PM

okay, on master now 🙂

brash-cricket-7489

10/02/2017, 8:52 PM

is there a way to invoke https://github.com/pantsbuild/pants/blob/master/contrib/node/src/python/pants/contrib/node/subsystems/node_distribution.py#L39 on the command line?

witty-crayon-22786

10/02/2017, 8:55 PM

to pass the option? yes

witty-crayon-22786

10/02/2017, 8:55 PM

all options can be passed as either environment variables, cli args, or pants.ini options

witty-crayon-22786

10/02/2017, 8:55 PM

--node-distribution-version=..

witty-crayon-22786

10/02/2017, 8:55 PM

@brash-cricket-7489: ^

brash-cricket-7489

10/02/2017, 8:56 PM

witty-crayon-22786

10/02/2017, 8:56 PM

https://www.pantsbuild.org/options.html#setting-option-values

bright-apartment-76721

10/03/2017, 2:27 PM

I have a slightly annoying question: I want to amend my ./pants script to pass a certain argument (the python thing I added yesterday in my PR) to all commands. I can do that just fine, but it breaks the help commands. I can't put my value in pants.ini because it's not statically knowable

bright-apartment-76721

10/03/2017, 2:28 PM

so I'm basically passing in

--python-setup-interpreter-search-paths=$(which python)

all the time, and that works except when writing

./pants help

and so on, which seem to take the option as an indication that I don't want help

witty-crayon-22786

10/03/2017, 4:30 PM

...hm. you're right. that is annoying. a bug would be good.

witty-crayon-22786

10/03/2017, 4:30 PM

once you've opened the bug, a workaround would seem to be to pass the option via the environment variable:

witty-crayon-22786

10/03/2017, 4:31 PM

Copy code

$ ./pants --python-setup-interpreter-requirement='CPython>=2.7,<3' help
# nada
$ PANTS_PYTHON_SETUP_INTERPRETER_REQUIREMENT='CPython>=2.7,<3' ./pants help
Pants 1.4.0.dev8+3831229698
...

bright-apartment-76721

10/03/2017, 4:51 PM

oh didn't realize that was possible

bright-apartment-76721

10/03/2017, 4:51 PM

awesome

witty-crayon-22786

10/03/2017, 4:53 PM

https://www.pantsbuild.org/options.html#setting-option-values

bright-apartment-76721

10/03/2017, 4:54 PM

thanks 🙂 I've RTFM'd parts of it but didn't know what I didn't know!

witty-crayon-22786

10/03/2017, 5:49 PM

@enough-analyst-54434: if you're around, another quick look at https://github.com/pantsbuild/pants/pull/4934 would be appreciated

enough-analyst-54434

10/03/2017, 5:53 PM

LGTM mod API public which still looks like a thing to me.

witty-crayon-22786

10/03/2017, 6:01 PM

@enough-analyst-54434: hm, you're right. it was marked public on

jar_library

, but not on

jvm_target

. i'm 98% sure that that was a mistake (based on the other fields already being public), so i think i'm going to violate the rules and strip that.

enough-analyst-54434

10/03/2017, 6:02 PM

Sgtm