pantsbuild #general

Channels

welcome

github-notifications

announce

rough-minister-58256

10/02/2017, 4:36 PM

we write a

/etc/pexrc

on all of our machines (laptops and servers) to ensure built pexes execute against a canonical interpreter

rough-minister-58256

10/02/2017, 4:36 PM

and then in our

./pants

wrapper we also slot in the

PEX_PYTHON

interpreter in a couple of ways for pants usage

bright-apartment-76721

10/02/2017, 4:36 PM

I see

bright-apartment-76721

10/02/2017, 4:37 PM

PEX_PYTHON did seem to do the trick, even though I annotated the interpreter_cache to print things out and it's still scanning all the pythons

bright-apartment-76721

10/02/2017, 4:37 PM

ah, but it doesn't appear to affect the cache

rough-minister-58256

10/02/2017, 4:37 PM

ideally pants would just have a config that says e.g.

[python-setup] preferred_interpreter_search: /path/to/python2.7:/path/to/python3.6

rough-minister-58256

10/02/2017, 4:38 PM

or else directly read from /etc/pexrc

bright-apartment-76721

10/02/2017, 4:38 PM

so yeah,

PEX_PYTHON

does the trick but meanwhile the

.pants.d/pyprep/interpreter/no_targets/interpreter.path

still writes down the wrong python

bright-apartment-76721

10/02/2017, 4:38 PM

so if I forget to set

PEX_PYTHON

, I get the wrong behavior

bright-apartment-76721

10/02/2017, 4:38 PM

but this seems to basically do the trick, thanks 🙂

bright-apartment-76721

10/02/2017, 4:38 PM

and yes, that config option would be ideal

bright-apartment-76721

10/02/2017, 4:39 PM

in my case it's kind of hard to compute that path statically though, so maybe just "follow PATH order" would be next best?

bright-apartment-76721

10/02/2017, 4:39 PM

maybe I could just amend the filter code in interpreter_cache to preserve order... hmm

rough-minister-58256

10/02/2017, 4:39 PM

iirc, the way it works now is it scans all interpreters on the $PATH and then uses the lowest version one

bright-apartment-76721

10/02/2017, 4:40 PM

ah, I missed logic looking for lowest version

rough-minister-58256

10/02/2017, 4:40 PM

but yeah, feel free to send a PR to adjust any of the PATH searching logic. we currently force that through other means (so doesn’t affect us), but seems like it could def use some work

bright-apartment-76721

10/02/2017, 4:40 PM

lowest version above 2.7 would explain the behavior I'm seeing

bright-apartment-76721

10/02/2017, 4:41 PM

I'll experiment a bit. For now

PEX_PYTHON

will do the trick

bright-apartment-76721

10/02/2017, 4:41 PM

thanks 🙂

rough-minister-58256

10/02/2017, 4:41 PM

👍

bright-apartment-76721

10/02/2017, 4:48 PM

hmm maybe PEX_PYTHON isn't doing it

bright-apartment-76721

10/02/2017, 4:48 PM

Copy code

12:47:11 00:15   [run]
FAILURE: /System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2.7 codebuild_trigger  ... exited non-zero (1)

bright-apartment-76721

10/02/2017, 4:48 PM

despite my

PEX_PYTHON

being set to something completely different

bright-apartment-76721

10/02/2017, 4:48 PM

will tinker some more 🙂

best-intern-74122

10/02/2017, 5:10 PM

@rough-minister-58256 I would be super interested in getting better and consistent python3 support

best-intern-74122

10/02/2017, 5:10 PM

how can I contribute

rough-minister-58256

10/02/2017, 5:11 PM

not sure yet, there’s a team of 2-3 folks spinning up on Python work starting today who are driving it

rough-minister-58256

10/02/2017, 5:12 PM

if you have known cases of python3 gaps/pain points/etc feel free to file github issues for tracking

rough-minister-58256

10/02/2017, 5:12 PM

otherwise would give them a week or two to spin up

best-intern-74122

10/02/2017, 5:13 PM

👍 some might be due to my peculiar needs but most are there already. will they use this slack?