pantsbuild #general

Channels

welcome

github-notifications

announce

gorgeous-alligator-94763

09/05/2017, 5:24 PM

rough-minister-58256

09/05/2017, 5:52 PM

refresh my memory - why can’t @twitter.com addresses work w/ pantsbuild slack?

wide-ram-55128

09/05/2017, 5:54 PM

I'm a living proof that they can 🙂.

rough-minister-58256

09/05/2017, 6:26 PM

maybe it’s just that they can’t self-request invites?

gorgeous-alligator-94763

09/05/2017, 6:30 PM

I’m not sure

enough-analyst-54434

09/05/2017, 7:55 PM

The domain as a whole cannot (could not anyway) be added to slack. Error message referred to ... Can't recall naming - SPF? - violations.

enough-analyst-54434

09/05/2017, 7:55 PM

Special DNS txt records are involved

enough-analyst-54434

09/05/2017, 7:55 PM

IIRC

rough-minister-58256

09/05/2017, 8:04 PM

rough-dog-96241

09/06/2017, 6:23 PM

Any quick suggestions for places to investigate if a coverage report is totally empty but the tests pass and you're pretty sure it's actually calling code?

rough-dog-96241

09/06/2017, 6:24 PM

Do I need to do anything in dependent libs? add coburtura to them?

rough-dog-96241

09/06/2017, 6:27 PM

ah, include_classes in pants.ini I suspect.

rough-dog-96241

09/06/2017, 6:31 PM

eh, or not: https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/jvm/tasks/coverage/cobertura.py#L119-L123 looks like it defaults to instrumenting all, and even if I specify .* explicitly I get nothin'. Any suggestions appreciated. 😄

rough-minister-58256

09/06/2017, 8:03 PM

if someone with admin privs can review, merge & sync https://github.com/pantsbuild/binaries/pull/32 it’d be much appreciated

rough-minister-58256

09/06/2017, 10:06 PM

@happy-kitchen-89482 did the rationale in https://github.com/pantsbuild/pants/pull/4846 make sense?

rough-minister-58256

09/06/2017, 10:11 PM

if there’s a motivation to eliminate binaryutil as a subsystem entirely, seems like we can always do that in subsequent changes.. but even in (or especially in) subsystems-in-v2-engine context I think tasks continuing to “request” an opaque

BinaryUtil

subsystem will be the ideal model.

happy-kitchen-89482

09/06/2017, 10:15 PM

At least we must document why we have a subsystem that registers no options

happy-kitchen-89482

09/06/2017, 10:15 PM

that is not a common pattern

rough-minister-58256

09/06/2017, 10:19 PM

https://github.com/pantsbuild/pants/blob/master/src/python/pants/pantsd/subsystem/subprocess.py is another case of this

rough-minister-58256

09/06/2017, 10:19 PM

iirc, when this went out either you or Stu had pushed me toward this ‘placeholder’ subsystem for subsystem dependency declaration - but purely sourcing global options

rough-minister-58256

09/06/2017, 10:20 PM

this==

Subprocess

rough-minister-58256

09/06/2017, 10:21 PM

seems reasonable to me to have a subsystem that itself registers no options but is used only as a context for retrieving global options and using them - w/ subsystem methods and such

rough-minister-58256

09/06/2017, 10:21 PM

afaik, nothing about a subsystem inherently requires options - it’s a feature, not a requirement

rough-minister-58256

09/06/2017, 10:22 PM

but that’s my subjective view

rough-minister-58256

09/06/2017, 10:22 PM

will add a quick comment to make it clearer

rough-minister-58256

09/06/2017, 10:24 PM

thanks!

happy-kitchen-89482

09/06/2017, 10:25 PM

Yeah, fair enough

happy-kitchen-89482

09/06/2017, 10:25 PM

Subprocesses exist to give access to options, but usually their own

happy-kitchen-89482

09/06/2017, 10:25 PM

Although, granted, there’s no reason not to access global ones

enough-analyst-54434

09/07/2017, 3:20 PM

if someone with admin privs can review, merge & sync https://github.com/pantsbuild/binaries/pull/32 it’d be much appreciated 1 reply Merged but not `./sync-s3.sh`'d. It was unclear to me whether the built 4.9.0 binaries had the fix in https://github.com/pantsbuild/binaries/pull/32. I'll be working until ~4pm Pacific today so ping me with that and I'll sync or hopefully have IAM setup so that committers can all sync.