https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    07/19/2017, 10:20 PM
    try declaring two jars: one with classifier tests, and one without. then depend on both
  • w

    witty-crayon-22786

    07/19/2017, 10:21 PM
    i remember this being odd, but not exactly what was necessary to get it working
  • m

    mysterious-farmer-45668

    07/19/2017, 10:21 PM
    ok. i'll try that
  • m

    mysterious-farmer-45668

    07/19/2017, 10:22 PM
    looks like it also depends on a bunch of other test jars- 
    For example, the finatra-http test-jar depends on the inject-app test-jar (among others). You will have to manually add a dependency on the inject-app test-jar when using the finatra-http test-jar since the inject-app test-jar will not be resolvedtransitively.
  • w

    witty-crayon-22786

    07/19/2017, 10:23 PM
    hm, yep.
  • w

    witty-crayon-22786

    07/19/2017, 10:24 PM
    ... it's really a nasty pattern. that should be named something like 
    finatrat-http-testing
    , and then just be unclassified, imo
  • m

    mysterious-farmer-45668

    07/19/2017, 10:29 PM
    so to achieve that, i'm doing something like
  • m

    mysterious-farmer-45668

    07/19/2017, 10:29 PM
    Copy code
    jar_library(name='inject-core',
            jars=[
                scala_jar(org='com.twitter', name='inject-core', rev='2.1.6')
            ],)

jar_library(name='inject-test',
            jars=[
                scala_jar(org='com.twitter', name='inject-core', rev='2.1.6', classifier='tests')
            ],)

jar_library(name='finatra-test',
            jars=[
                scala_jar(org='com.twitter', name='finatra-http', rev='2.11.0', classifier='tests')
            ],
            dependencies=[
                ':inject-core',
                ':inject-test',
            ])
  • m

    mysterious-farmer-45668

    07/19/2017, 10:29 PM
    (put in both core and test because just having test didn't really solve my problem)
  • m

    mysterious-farmer-45668

    07/19/2017, 10:30 PM
    is this the correct way to make finatra-test depend on inject-test?
  • w

    witty-crayon-22786

    07/19/2017, 10:30 PM
    that, or you could cheat and put them all in the same 
    jars
    list.
  • m

    mysterious-farmer-45668

    07/19/2017, 10:30 PM
    The fetched finatra-test jar contains the inject-core, but not inject-core-test
  • m

    mysterious-farmer-45668

    07/19/2017, 10:31 PM
    so something like
  • m

    mysterious-farmer-45668

    07/19/2017, 10:31 PM
    Copy code
    jar_library(name='finatra-test',
            jars=[
                scala_jar(org='com.twitter', name='finatra-http', rev='2.11.0', classifier='tests')
                scala_jar(org='com.twitter', name='inject-core', rev='2.1.6', classifier='tests')
            ],)
    ?
  • m

    mysterious-farmer-45668

    07/19/2017, 10:32 PM
    still not fetching for some reason 😞
  • m

    mysterious-farmer-45668

    07/19/2017, 10:33 PM
    it keeps on fetching the original jar, not the test jar
  • m

    mysterious-farmer-45668

    07/20/2017, 12:18 AM
    turns out i was fetching the wrong version! dumb old me
  • m

    mysterious-farmer-45668

    07/20/2017, 5:58 AM
    I have something that doesn't compile when compiled with 
    ./pants compile ::
    , but compiles when it's the only target being compiled. Why would that be?
  • m

    mysterious-farmer-45668

    07/20/2017, 6:16 AM
    i needed to add a bunch of transitive dependencies manually
  • f

    fast-megabyte-33579

    07/20/2017, 8:52 AM
    compile ::
    takes all the targets, joins all their classpaths together and tries to compile everything with that
  • f

    fast-megabyte-33579

    07/20/2017, 8:53 AM
    at FR we basically had no transitive 3rdparty deps, everything was specified as a target
  • p

    purple-oil-45048

    07/20/2017, 9:21 AM
    @fast-megabyte-33579 so you would list all the jars a 3rdparty jar would depend on?
  • f

    fast-megabyte-33579

    07/20/2017, 10:26 AM
    @purple-oil-45048 taking the example above, we would mark all the `scala_jar`s as 
    intransitive=True
    , and add targets for each jar in turn
    ✨ 1
  • f

    fast-megabyte-33579

    07/20/2017, 10:27 AM
    we were "lucky" in that in most cases we were able to specify one version of guava, commons-lang etc that all of our deps were happy with
  • m

    most-wire-83210

    07/20/2017, 1:10 PM
    thanks @rough-minister-58256 - will do
  • m

    most-wire-83210

    07/20/2017, 3:49 PM
    @rough-minister-58256 - updated the issue https://github.com/pantsbuild/pex/issues/68
  • m

    mysterious-farmer-45668

    07/20/2017, 6:39 PM
    How do you make a jar out of a 
    java_library
    or a 
    scala_library
    target? i thought this was possible with 
    ./pants binary
    but it's not creating anything in dist- do the targets have to be 
    jvm_binary
    ?
  • m

    mysterious-farmer-45668

    07/20/2017, 6:41 PM
    even 
    ./pants jar
    doesn't create the jar in 
    dist/
  • w

    witty-crayon-22786

    07/20/2017, 6:44 PM
    correct: there are generally two models: 1) publishing and, 2) deployment
  • w

    witty-crayon-22786

    07/20/2017, 6:45 PM
    to deploy an app, you'd create a 
    jvm_binary
    to be the entrypoint for the app
1...178217831784...2420Latest