pantsbuild #general

Channels

welcome

github-notifications

announce

witty-crayon-22786

06/29/2017, 8:40 PM

@great-midnight-1044 : re "One question: have you ever benchmarked how much it takes to rewrite the analysis files?" -- yes, but not recently. The reason the analysis rewrites were initially ported out of zinc itself and into the python code surrounding it was that analysis serialization was slow. see Benjy's comments above

witty-crayon-22786

06/29/2017, 8:41 PM

and because we were calling back into the jvm to request splitting and merging of analysis files on disk, rather than analysis in memory

limited-memory-65960

06/30/2017, 8:52 AM

Hi all, just wanted to introduce myself as @fast-megabyte-33579 (soon to be former, hmpf 😉 ) colleague

limited-memory-65960

06/30/2017, 8:53 AM

@alert-addition-34873 has joined with me too, so there's two of us here now- hooray!

🎊 1

🦜 2

👋 1

happy-kitchen-89482

06/30/2017, 8:53 PM

Hi to you both

happy-kitchen-89482

06/30/2017, 8:53 PM

Welcome

rough-dog-96241

06/30/2017, 11:23 PM

Anyone know of a good place to find what the complete list of possible wheel platform strings is?

rough-minister-58256

06/30/2017, 11:30 PM

afaik, it’s arbitrary and only bounded by existing OS + cpu arch representations

rough-minister-58256

06/30/2017, 11:30 PM

https://www.python.org/dev/peps/pep-0425/#platform-tag

rough-minister-58256

06/30/2017, 11:32 PM

so the complete list is anything that can be generated by: https://github.com/kwlzn/python-sources/blob/master/Python-2.7.13/Lib/distutils/util.py#L16

rough-dog-96241

06/30/2017, 11:35 PM

fun fun

chilly-planet-38178

07/02/2017, 9:09 AM

I have a problem with https://github.com/pantsbuild/pants/tree/master/contrib/node and node_remote_module. I'm trying to take node-sass into use in my project but pants fails running the node-sass installation script:

Copy code

Error: Cannot find module '/data/.pants.d/resolve/node/252d64521cf9/projects.node.frontend.react-frp-todomvc.react-frp-todomvc/ff8cd7631233/node_modules/node-sass/scripts/install.js'
   at Function.Module._resolveFilename (module.js:469:15)
   at Function.Module._load (module.js:417:25)
   at Module.runMain (module.js:604:10)
   at run (bootstrap_node.js:393:7)
   at startup (bootstrap_node.js:150:9)
   at bootstrap_node.js:508:3

> node-sass@4.5.3 install /data/.pants.d/resolve/node/252d64521cf9/projects.node.frontend.react-frp-todomvc.react-frp-todomvc/ff8cd7631233/node_modules/node-sass
> node scripts/install.js

I do have node installed in my docker container where that was run, so I'm guesssing it's using it instead of the bundled one. Any ideas?

chilly-planet-38178

07/02/2017, 3:01 PM

debug log looks like this:

Copy code

83143 verbose lifecycle node-sass@4.5.3~install: unsafe-perm in lifecycle false
83144 verbose lifecycle node-sass@4.5.3~install: PATH: /data/.cache/bin/node/linux/x86_64/v6.10.2/node/lib/node_modules/npm/bin/node-gyp-bin:/data/.pants.d/resolve/node/252d64521cf9/projects.node.frontend.react-frp-todomvc.react-frp-todomvc/7f272772437a/node_modules/node-sass/node_modules/.bin:/data/.pants.d/resolve/node/252d64521cf9/projects.node.frontend.react-frp-todomvc.react-frp-todomvc/7f272772437a/node_modules/.bin:/data/.cache/bin/node/linux/x86_64/v6.10.2/node/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
83145 verbose lifecycle node-sass@4.5.3~install: CWD: /data/.pants.d/resolve/node/252d64521cf9/projects.node.frontend.react-frp-todomvc.react-frp-todomvc/7f272772437a/node_modules/node-sass
83146 silly lifecycle node-sass@4.5.3~install: Args: [ '-c', 'node scripts/install.js' ]
83147 silly lifecycle node-sass@4.5.3~install: Returned: code: 1  signal: null
83148 info lifecycle node-sass@4.5.3~install: Failed to exec install script

chilly-planet-38178

07/02/2017, 3:05 PM

hmm, could it be because of unsafe-perm?

chilly-planet-38178

07/02/2017, 3:09 PM

phew finally it works. I added .npmrc with a line

unsafe-perm=true

and included that in my BUILD file.

chilly-planet-38178

07/03/2017, 6:58 AM

Good morning 🙂 I ran into a problem with react-hot-loader. When I do

pants run

it builds my app into

~/.pants.d/resolve/node/current/...

and starts it from there. Now when I edit code in my project the changes are of course not hot reloaded because it's a different copy of the project. So my question is that is there a way to tell `pants run`to use a certain directory for running, rather than building the app into pants.d and starting it from there?

enough-analyst-54434

07/03/2017, 2:36 PM

@chilly-planet-38178 there is no way to do that today. I expect what you'd want is a mode (or the default / standard mode) where run built its node chroot as a symlink farm so live edits from the main source tree would be seen in the chroot pants uses for the resolve. That is, if a symlink farm would work with react's file change watching system - not sure about that.

chilly-planet-38178

07/03/2017, 5:29 PM

@enough-analyst-54434 ok. I will simply use another node installation and run the project using that.

great-midnight-1044

07/04/2017, 1:41 PM

@witty-crayon-22786 thanks for the answer! @happy-kitchen-89482 we can discuss why we chose binary format in the scala channel, but Zinc will provide ways to get JSON output from protobuf generated analysis files

straight-waiter-86090

07/05/2017, 2:40 PM

does anyone have recommendations for using jrebel with pants builds?

fast-nail-55400

07/05/2017, 4:16 PM

pants v1.3.0 pins its requirements to very narrow version ranges. where would be a good place to discuss why that is? background: we bootstrap pants into a repo-specific virtualenv by listing in our repo's

requirements.txt

and, for example, the pants requirement for

requests>=2.5.0,<2.6

conflicts with our repo's requirement of later version of

requests

fast-nail-55400

07/05/2017, 4:17 PM

I'd like to whether we could relax those narrow version ranges somewhat. Should I open a GitHub issue?

wide-energy-11069

07/05/2017, 5:10 PM

may not be the right solution, but you can make another BUILD at a different location with

wide-energy-11069

07/05/2017, 5:10 PM

Copy code

$ cat 3rdparty/python/BUILD 
python_requirements('requirements.txt')

fast-nail-55400

07/05/2017, 5:46 PM

separate from

3rdparty/python/BUILD

fast-nail-55400

07/05/2017, 5:47 PM

we already have that BUILD file with

python_requirements()

as the contents

wide-energy-11069

07/05/2017, 5:48 PM

3rdparty/another_python/BUILD

wide-energy-11069

07/05/2017, 5:48 PM

then for the targets in the repo, depends on

3rdparty/another_python:requests

with a different request version

wide-energy-11069

07/05/2017, 5:49 PM

(not the best approach from maintenance perspective on multiple requirements.txt)

fast-nail-55400

07/05/2017, 6:04 PM

yeah this means I have to fixup every reference to

requests

to be this alternate set of targets, and set our main requirements.txt to have requests match the pants requirement