https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    06/27/2017, 9:03 PM
    the approximate path is: 1) resolve.ivy creates a 
    compile_classpath
    , 2) compile.zinc consumes the 
    compile_classpath
    to create a 
    runtime_classpath
    , 3) test.junit consumes the 
    runtime_classpath
    to run && bundle.consolidate-classpath consumes the 
    runtime_classpath
    to create 
    consolidated_classpath
    👍 1
  • f

    fast-megabyte-33579

    06/27/2017, 10:04 PM
    hey guys, it's my last day at football radar on friday. I've attempted to rope in some replacements and when/if they show up i'll introduce them. please treat them gently!
  • f

    fast-megabyte-33579

    06/27/2017, 10:05 PM
    I'd like to stay involved with pants though so can I maybe get an invite to my personal email?
  • f

    fast-megabyte-33579

    06/27/2017, 10:06 PM
    maybe I can do that now I'm here.
  • w

    wide-energy-11069

    06/27/2017, 10:07 PM
  • h

    happy-kitchen-89482

    06/27/2017, 10:15 PM
    Congrats (?) What’s next for you?
  • f

    fast-megabyte-33579

    06/27/2017, 11:13 PM
    thanks benjy - off to a startup called Thought Machine
  • h

    happy-kitchen-89482

    06/28/2017, 12:47 AM
    Good luck!
  • a

    acceptable-kitchen-41259

    06/29/2017, 5:17 PM
    hey guys, I'm having an issue where a python target that I added in 1.2.x is no longer seen by pants when I rebased onto 1.3.x
  • a

    acceptable-kitchen-41259

    06/29/2017, 5:18 PM
    did something change around task registration between the versions?
  • e

    enough-analyst-54434

    06/29/2017, 5:34 PM
    You could help responses along with a paste of the relevant registration code I think, as well as which task you expected to pick up the custom target type, maybe by pasting the pants command line you ran that used to work and now no-ops on the custom target type.
  • a

    acceptable-kitchen-41259

    06/29/2017, 5:52 PM
    Hopefully this helps, couldn't get gist to include the full paths of the files: https://gist.github.com/wkiser/e36bd4b86b8c06d52265affcd0b448da
  • a

    acceptable-kitchen-41259

    06/29/2017, 5:52 PM
    the command I was running to check it just ./pants targets | grep python_protobuf_library
  • w

    witty-crayon-22786

    06/29/2017, 5:53 PM
    @acceptable-kitchen-41259 : is this in a branch of pants itself?
  • a

    acceptable-kitchen-41259

    06/29/2017, 5:53 PM
    yeah
  • w

    witty-crayon-22786

    06/29/2017, 5:53 PM
    iirc, the codegen backend was split up
  • w

    witty-crayon-22786

    06/29/2017, 5:53 PM
    into a bunch of backends
  • w

    witty-crayon-22786

    06/29/2017, 5:54 PM
    Copy code
    src/python/pants/backend/codegen/antlr/java/register.py
src/python/pants/backend/codegen/antlr/python/register.py
src/python/pants/backend/codegen/jaxb/register.py
src/python/pants/backend/codegen/protobuf/java/register.py
src/python/pants/backend/codegen/ragel/java/register.py
src/python/pants/backend/codegen/register.py
src/python/pants/backend/codegen/thrift/java/register.py
src/python/pants/backend/codegen/thrift/python/register.py
src/python/pants/backend/codegen/wire/java/register.py
  • e

    enough-analyst-54434

    06/29/2017, 5:54 PM
    PythonProtobufLibrary is dead
  • e

    enough-analyst-54434

    06/29/2017, 5:55 PM
    ?
  • e

    enough-analyst-54434

    06/29/2017, 5:55 PM
    I'm surprised that import works - is this a silent failure @acceptable-kitchen-41259
  • w

    witty-crayon-22786

    06/29/2017, 5:55 PM
    i think that if you recreated the old codegen 
    register.py
    file, it's probably no longer being loaded anywhere
  • e

    enough-analyst-54434

    06/29/2017, 5:55 PM
    Also - why do you need to re-register builtins?
  • e

    enough-analyst-54434

    06/29/2017, 5:56 PM
    That makes you brittle to changes like this in general. Good to avoid if possible
  • a

    acceptable-kitchen-41259

    06/29/2017, 5:56 PM
    is PythonProtobufLibrary a builtin?
  • e

    enough-analyst-54434

    06/29/2017, 5:56 PM
    it was in your code snippet
  • w

    witty-crayon-22786

    06/29/2017, 5:56 PM
    @acceptable-kitchen-41259 : see the register.py files i listed above. the one you've editted doesn't exist anymore.
  • w

    witty-crayon-22786

    06/29/2017, 5:56 PM
    in 1.3.x
  • e

    enough-analyst-54434

    06/29/2017, 5:57 PM
    You have 
    from pants.backend.codegen.targets.python_protobuf_library import PythonProtobufLibrary
  • w

    witty-crayon-22786

    06/29/2017, 5:57 PM
    when you get this fixed up, recommend upstreaming it, which will allow/force the pants devs to maintain it for you 😃
1...176917701771...2420Latest