pantsbuild #general

Channels

welcome

github-notifications

announce

witty-crayon-22786

06/27/2017, 7:55 PM

in the

runtime_classpath

consolidated_classpath

products, depending on what you need

witty-crayon-22786

06/27/2017, 7:55 PM

if you need jars, probably

consolidated_classpath

witty-crayon-22786

06/27/2017, 7:55 PM

but if you mean "deploy binaries" similar to the output of

./pants binary

, that's another thing

strong-motorcycle-90761

06/27/2017, 7:56 PM

I'm going to need both. When running tests, the jar I'm interested in seems to live in

.pants.d/compile/zinc/252d64521cf9/mypackagename/ccacb4ad7a92/z.jar

strong-motorcycle-90761

06/27/2017, 7:57 PM

when running

./pants binary

it ends up in

./dist/mystuff.jar

witty-crayon-22786

06/27/2017, 7:57 PM

those are different jars

strong-motorcycle-90761

06/27/2017, 7:57 PM

I'm able to deal with the

./pants binary

case. It's the tests case that's harder.

strong-motorcycle-90761

06/27/2017, 7:57 PM

I know, one ends up being shaded and the other doesn't.

witty-crayon-22786

06/27/2017, 7:58 PM

consolidated_classpath

should contain jars for targets as a

ClasspathProducts

instance

strong-motorcycle-90761

06/27/2017, 7:58 PM

I don't see consolidated_classpath:

Copy code

(Pdb) self.context.products.data_products.keys()
[u'compile_classpath', u'go_remote_lib_src', u'jvm_build_tools_classpath_callbacks', <class 'pants.backend.jvm.tasks.jar_import_products.JarImportProducts'>, u'runtime_classpath', u'exec_binary', 'classpath_products']

witty-crayon-22786

06/27/2017, 7:59 PM

then your task hasn't requested it

witty-crayon-22786

06/27/2017, 7:59 PM

see http://www.pantsbuild.org/dev_tasks.html#product_types-and-require_data-why-test-comes-after-compile

strong-motorcycle-90761

06/27/2017, 8:00 PM

I initially had

round_manager.require_data('compile_classpath')

(mostly because I copied an existing plugin to get started)

witty-crayon-22786

06/27/2017, 8:02 PM

yep. that's not the one you want.

witty-crayon-22786

06/27/2017, 8:03 PM

this API is pretty unfortunate, and we're working to change it, but: a task should declare the products it will use

witty-crayon-22786

06/27/2017, 8:03 PM

it primarily matters when the goal that you're installed in would not otherwise have a dependency on the product. but it's the right thing to do.

strong-motorcycle-90761

06/27/2017, 8:05 PM

my plugin depends on JavaLibrary. I just want to know where the compile step put the jar.

witty-crayon-22786

06/27/2017, 8:06 PM

see http://www.pantsbuild.org/dev_tasks.html#product_types-and-require_data-why-test-comes-after-compile

strong-motorcycle-90761

06/27/2017, 8:16 PM

still doesn't answer my question

witty-crayon-22786

06/27/2017, 8:16 PM

"`consolidated_classpath` should contain jars for targets as a

ClasspathProducts

instance" is the answer to your question

witty-crayon-22786

06/27/2017, 8:16 PM

your task should request that product

witty-crayon-22786

06/27/2017, 8:17 PM

and then it should use it.

strong-motorcycle-90761

06/27/2017, 8:18 PM

I can't request consolidated_classpath.

strong-motorcycle-90761

06/27/2017, 8:18 PM

Exception message: Cycle detected in goal dependencies:

strong-motorcycle-90761

06/27/2017, 8:21 PM

alternative question: is there a way to have my plugin run right before the tests + get a handle on the jar?

witty-crayon-22786

06/27/2017, 8:35 PM

"Exception message: Cycle detected in goal dependencies:" indicates that by being installed in goal X, you introduce a cycle between that goal and another goal

witty-crayon-22786

06/27/2017, 8:36 PM

would need to move your task to another goal probably

witty-crayon-22786

06/27/2017, 8:36 PM

@strong-motorcycle-90761 : ah. if you're trying to affect tests, then you probably want the

runtime_classpath

instead, as that's what

test.junit

consumes.

strong-motorcycle-90761

06/27/2017, 8:59 PM

I'm trying to modify a jar after it is created. running right before tests + right after the shaded jar is created might work.

witty-crayon-22786

06/27/2017, 9:00 PM

@strong-motorcycle-90761 : the "shaded jar" (ie, output to

dist

) is not created for the

test

goal