pantsbuild #general

Channels

welcome

github-notifications

announce

happy-kitchen-89482

06/08/2017, 12:25 AM

Ah, 1.2.1 might be broken in this regard

purple-oil-45048

06/08/2017, 12:26 AM

thanks @witty-crayon-22786 and @happy-kitchen-89482 ✨

witty-crayon-22786

06/08/2017, 12:26 AM

(all benjy: he fixed it)

witty-crayon-22786

06/08/2017, 12:27 AM

more discussion over here: https://groups.google.com/d/topic/pants-devel/b-28CClQSH4/discussion

purple-oil-45048

06/08/2017, 12:28 AM

I had a similar looking situation when my

python_library()

was depending on a platform-dependent

.egg

.. only after explicitly declaring the same dependency on the

python_binary()

did it show up in the

.pex

file

purple-oil-45048

06/08/2017, 12:30 AM

oh.

1.3.0

is out!

delightful-eye-58250

06/08/2017, 4:13 AM

Hi, I am trying trying to pass in -Xexperimental to compile a scala_library but it seems I can only do this in the pants.ini which is breaking another directories code, is there a way to-do this in the BUILD file for only the directory I want?

purple-oil-45048

06/08/2017, 4:14 AM

i remember there are some

jvm_extra_args

settings on the JVM targets for this ..

delightful-eye-58250

06/08/2017, 4:21 AM

maybe, but not sure I could add it at that point either seems as it would also break the other dir too. kinda need to have it isolated only for the target specifically I wanted, i might be not understanding how to-do what your saying too is possible

delightful-eye-58250

06/08/2017, 4:23 AM

I was looking at the code scala_library.py jvm_target.py etc etc seems like I could probably get it added in there feel like 95.2% sure I could do that still feel like a few parts I am not getting entirely and then need to compile and try it out but not adverse to doing that especially if it would be something useful to others and could get added in

most-wire-83210

06/08/2017, 8:01 AM

I had a question regarding pants

most-wire-83210

06/08/2017, 8:02 AM

we are looking to integrate pants into our product

most-wire-83210

06/08/2017, 8:03 AM

so that they can develop using Pants and generate PEX files

most-wire-83210

06/08/2017, 8:03 AM

Pants expects it to be installed in the same repo where the code resides. If we ship pants as part of the distribution, it will be in bin directory of the distribution. The users will invoke something like heron-pants <options> <args> instead of ./pants <options> <args>

most-wire-83210

06/08/2017, 8:04 AM

the current option is to use download and install pants for each repo - which might not be ideal in our case.

most-wire-83210

06/08/2017, 8:04 AM

Is there a way to do this?

most-wire-83210

06/08/2017, 8:05 AM

@delightful-eye-58250 - hi

enough-analyst-54434

06/08/2017, 3:54 PM

@most-wire-83210 not currently w/o at least touching an empty

pants

file at the root of the repo using

heron-pants

. The relevant code is here: https://github.com/pantsbuild/pants/blob/master/src/python/pants/base/build_root.py#L30-L57

enough-analyst-54434

06/08/2017, 3:57 PM

This same code used to look for

pants.ini

. I think we switched away from looking for that config file since a mjor goal was to reduce the amount of config needed to get pants running, ultimately with a goal of not needing a

pants.ini

. I think we could revisit though. At some point it would be nice to have pants as a user / system binary much like heron-pants that multiple repos could share instead of installing a pants script in each repo running pants. In that world, touching pants.ini arguably seems like a low overhead repo setup step.

witty-crayon-22786

06/08/2017, 4:59 PM

agreed.

witty-crayon-22786

06/08/2017, 5:03 PM

but in this case, is the issue that the code being built into pexes may not live under the path where pants is installed?

witty-crayon-22786

06/08/2017, 5:04 PM

that one is challenging regardless, because pants operates under some root directory (doesn't need to be the root of the repo)

enough-analyst-54434

06/08/2017, 5:56 PM

but in this case, is the issue that the code being built into pexes may not live under the path where pants is installed?

Yes, that's the issue afaict. That issue is solved if the build root sentinel in different from the pants executable. Seems like

pants.ini

is the natural choice in that case? IE: pretend heron-pants does not exist, but installing pants system wide does exist as a concept. In that world, having

pants

at the root of the repo be the sentinel is confusing since

pants

would already be a binary on the PATH.

rough-minister-58256

06/08/2017, 6:30 PM

wonder if it’d be easier to plumb “slurp this directory into a pex” into the

pex

cli tool and then just use that for the heron case vs a full blown pants installation?

rough-minister-58256

06/08/2017, 6:30 PM

pex wouldn’t have the same constraints and could be located in e.g. an off to the side bin dir

rough-minister-58256

06/08/2017, 6:32 PM

could even use it today with some kind of autogenerated or user authored setup.py

fast-megabyte-33579

06/08/2017, 6:34 PM

could you symlink a

pants

in the repo root to your system directory

witty-crayon-22786

06/08/2017, 6:36 PM

yes. the file/script can contain anything, so it needn't even be a symlink

most-wire-83210

06/08/2017, 8:06 PM

thanks @enough-analyst-54434 @witty-crayon-22786

most-wire-83210

06/08/2017, 8:11 PM

few of ex-twitter folks have started a company - we are working with Heron and DLOG. We really like Pants and we want to bundle into the product

👍 1