pantsbuild #general

Channels

welcome

github-notifications

announce

witty-crayon-22786

06/06/2017, 8:50 PM

./pants test x

, where x is the target alias i defined above, is essentially equivalent to

./pants test y z

, afaik

able-finland-42099

06/06/2017, 9:36 PM

@witty-crayon-22786 Cool, that makes sense. I thought I was seeing different behavior but forgot that there was some default filtering on tags going on. Thanks for your help!

witty-crayon-22786

06/07/2017, 12:00 AM

@enough-analyst-54434 , @rough-minister-58256 : so both https://github.com/pantsbuild/pants/pull/4648 and https://github.com/pantsbuild/pants/issues/4640 should probably be backported to 1.3.x... but they both seem like non-blockers for

1.3.0

, yea?

witty-crayon-22786

06/07/2017, 12:00 AM

unless we think in aggregate they're worth waiting for

enough-analyst-54434

06/07/2017, 12:01 AM

I think 1.3.1 is fine for https://github.com/pantsbuild/pants/pull/4648, its a corner-case bug that can be worked around by devs - I doubt a CI job uses

-- -k...

witty-crayon-22786

06/07/2017, 12:02 AM

sounds good.

enough-analyst-54434

06/07/2017, 12:08 AM

For each I added the

needs-rc-cherrypick

label and placed in a new 1.3.1 milestone.

witty-crayon-22786

06/07/2017, 12:10 AM

thanks a lot. i was just working on updating the docs with regards to those

witty-crayon-22786

06/07/2017, 12:25 AM

https://github.com/pantsbuild/pants/pull/4652

purple-oil-45048

06/07/2017, 1:44 AM

Do you bundle

resources

inside with your

*.pex

? Or do you have your

resources

alongside the

*.pex

inside a

*.zip

archive ?

plain-sundown-25537

06/07/2017, 7:01 PM

Hello, how would I get my java_library target to execute a prep_command?

Copy code

prep_command(name='prep',
    prep_executable='oucommon/schemas/scripts/genAvroJava.sh',
    prep_args=[],
    goal='compile'
)

Copy code

java_library = (.. 

dependencies = [":prep"]
..

doesnt seem to work

plain-sundown-25537

06/07/2017, 7:03 PM

Oh it is pants 1.2

plain-sundown-25537

06/07/2017, 7:04 PM

I read from this CR, it should work.. https://rbcommons.com/s/twitter/r/3519/diff/2/

happy-kitchen-89482

06/07/2017, 9:42 PM

@purple-oil-45048 I like to have my resources inside the pex, which happens automatically if your python_binary target depends (transitively) on the relevant resources() targets.

happy-kitchen-89482

06/07/2017, 9:43 PM

E.g., this is how I bundle templates in a django app

witty-crayon-22786

06/07/2017, 9:51 PM

the

1.3.0

milestone is closed! https://github.com/pantsbuild/pants/milestone/8

witty-crayon-22786

06/07/2017, 9:51 PM

please target any fixes that should be cherry-picked to

1.3.x

at https://github.com/pantsbuild/pants/milestone/10

👍 1

fast-megabyte-33579

06/07/2017, 10:26 PM

nice work

plain-sundown-25537

06/07/2017, 10:48 PM

anyone knows how to invoke with prep_command in java_lib? sorry for bugging 🙂

witty-crayon-22786

06/08/2017, 12:00 AM

@plain-sundown-25537 : please open a ticket with an example that isn't working. we don't really use it internally, so i don't know off the top of my head how it is supposed to work.

witty-crayon-22786

06/08/2017, 12:00 AM

but do know that creating something using prep_command and then trying to capture it with a glob later will stop working in 1.3.0

👍 1

purple-oil-45048

06/08/2017, 12:21 AM

@happy-kitchen-89482 it didn’t get bundled up when I had

resources() <= python_library() <= python_binary()

where

<=

is a declared dependency

happy-kitchen-89482

06/08/2017, 12:22 AM

Hmmm, it should. I have exactly that scenario.

purple-oil-45048

06/08/2017, 12:22 AM

but now using

python_binary(.., resources=[..])

works just fine

witty-crayon-22786

06/08/2017, 12:23 AM

@purple-oil-45048 : which pants version?

happy-kitchen-89482

06/08/2017, 12:23 AM

Hmm, works for me

happy-kitchen-89482

06/08/2017, 12:23 AM

E.g.,

purple-oil-45048

06/08/2017, 12:24 AM

pants_version : 1.2.1

witty-crayon-22786

06/08/2017, 12:24 AM

resources in the

dependencies

list only completely work in

1.3.0

happy-kitchen-89482

06/08/2017, 12:25 AM

Copy code

python_binary(
  name='app',
  dependencies=[
    ':foo',
  ])

python_library(
  name='foo',
  dependencies=[
    ':templates',
    '3rdparty/python:Django',
    '3rdparty/python:jinja2',
  ],
)

resources(
  name='templates',
  sources=rglobs('jinja2/*'),
  dependencies=[
    'src/python/snowchain/django/site:templates',
  ]
)