pantsbuild #general

Channels

welcome

github-notifications

announce

fast-nail-55400

05/23/2017, 9:45 PM

hmm and looking at

src/python/pants/reporting/html_reporter.py

, it keys on TOOL to show the stdout/err in

./pants server

page

fast-nail-55400

05/23/2017, 9:46 PM

lemme try that

fast-nail-55400

05/23/2017, 9:55 PM

hmm mateo had me fix by using

.communicate

on the subprocess

fast-nail-55400

05/23/2017, 9:55 PM

instead of

.check_call

witty-crayon-22786

05/23/2017, 9:55 PM

fast-nail-55400

05/23/2017, 9:55 PM

although will still change to

TOOL

so I get output in pants server

fast-nail-55400

05/23/2017, 9:56 PM

actually

.communicate

is just capturing everything and not dumping

fast-nail-55400

05/23/2017, 9:57 PM

or was that from using

TOOL

witty-crayon-22786

05/23/2017, 10:09 PM

possibly... should try a few of those.

witty-crayon-22786

05/23/2017, 10:10 PM

MULTITOOL

iirc is the one that results in a dot-per-run

witty-crayon-22786

05/23/2017, 10:10 PM

TOOL

may only dump output on failure

fast-nail-55400

05/23/2017, 10:27 PM

I'm trying both

RUN

and

TOOL

and now output is dumped again

fast-nail-55400

05/23/2017, 10:28 PM

seems like

src/python/pants/reporting/plaintext_reporter.py

contains the code that dumps it out?

fast-nail-55400

05/23/2017, 10:30 PM

actually the error output made it out, just not merged into the appropriate place with the stdout output

fast-nail-55400

05/23/2017, 10:30 PM

(as if they were a single stream)

wide-energy-11069

05/23/2017, 10:31 PM

@fast-nail-55400 you want both stdout and stderr to be printed?

fast-nail-55400

05/23/2017, 10:31 PM

I'll probably just redirect the stderr output into stdout

fast-nail-55400

05/23/2017, 10:31 PM

yeah I'm running a tool in a docker container and being able to see the error is the goal

fast-nail-55400

05/23/2017, 10:32 PM

versus stdout saying "there's an error" and the stderr output being somewhere not near that message

wide-energy-11069

05/23/2017, 10:33 PM

maybe https://github.com/pantsbuild/pants/blob/bd01a9abcdb4d7427ccfdbb0348989c7fe2e3114/contrib/scrooge/src/python/pants/contrib/scrooge/tasks/thrift_linter.py#L99-L100 can be related?

fast-nail-55400

05/23/2017, 10:39 PM

probably.

WorkUnitLabel.COMPILER

is set to show indented output

fast-nail-55400

05/23/2017, 10:39 PM

I was using just

WorkUnitLabel.RUN

before which shows unindented output

fast-nail-55400

05/23/2017, 10:39 PM

but w/o

TOOL

as well, it wouldn't be shown in the pants server web UI

fast-nail-55400

05/23/2017, 10:40 PM

now I'm using

RUN

and

TOOL

and get the output dumped and accessible in the web UI

fast-nail-55400

05/23/2017, 10:40 PM

as for the ordering of stdout/err, I'm redirecting stderr into stdout (via

stderr=subprocess.STDOUT

) on the

subprocess.Popen

call and now the ordering is correct

wide-energy-11069

05/23/2017, 10:43 PM

printing out to stdout directly may have unintended result for console tasks?

wide-energy-11069

05/23/2017, 10:44 PM

i’d recommend using just the labels if possible

fast-nail-55400

05/23/2017, 10:44 PM

I don't know, the task that my question was about is not a console task

fast-nail-55400

05/23/2017, 10:45 PM

I redirect stderr->stdout and stdout is the result of a call to

workunit.output

fast-nail-55400

05/23/2017, 10:45 PM

so I'm still using the workunit method of capturing output