https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    05/22/2017, 5:50 PM
    @straight-waiter-86090 : yea, i repro.
  • w

    witty-crayon-22786

    05/22/2017, 5:50 PM
    thanks!
  • s

    straight-waiter-86090

    05/22/2017, 5:50 PM
    np
  • w

    witty-crayon-22786

    05/22/2017, 5:54 PM
    @straight-waiter-86090 : mmm. looks like the file mode is different on osx vs linux.
  • w

    witty-crayon-22786

    05/22/2017, 5:55 PM
    ...hm. or something else. let me see.
  • w

    witty-crayon-22786

    05/22/2017, 6:13 PM
    ...aha.
  • w

    witty-crayon-22786

    05/22/2017, 6:13 PM
    Copy code
    $ tar --list --verbose -f osx.tar
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/p
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/a
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/n
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/t
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/s
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/b
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/u
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/i
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/l
-rw-rw----  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/d
$ tar --list --verbose -f linux.tar
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/p
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/a
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/n
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/t
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/s
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/b
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/u
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/i
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/l
-rw-rw-r--  0 0      0           0 Dec 31  1969 testprojects/src/resources/org/pantsbuild/testproject/ordering/d
  • w

    witty-crayon-22786

    05/22/2017, 6:19 PM
    ...agh. because they are actually different in the repo in this case...
  • w

    witty-crayon-22786

    05/22/2017, 6:19 PM
    hm.
  • w

    witty-crayon-22786

    05/22/2017, 6:20 PM
    @straight-waiter-86090 : mind checking whether that is the case for you as well? 
    ls -l
    for the input files
  • w

    witty-crayon-22786

    05/22/2017, 6:20 PM
    in the filesystem
  • s

    straight-waiter-86090

    05/22/2017, 6:22 PM
    osx:
  • s

    straight-waiter-86090

    05/22/2017, 6:22 PM
    Copy code
    -rw-r--r--  1 dyoung  SKYDIVE\Domain Users  13931 Apr  7 08:36 nucleus/java/com/r9/nucleus/message/MessageBundle.java
  • s

    straight-waiter-86090

    05/22/2017, 6:22 PM
    linux:
  • s

    straight-waiter-86090

    05/22/2017, 6:23 PM
    Copy code
    -rw-rw-r--. 1 bamboo bamboo 13931 May  9 08:40 nucleus/java/com/r9/nucleus/message/MessageBundle.java
  • w

    witty-crayon-22786

    05/22/2017, 6:24 PM
    yea, so those are getting captured... which was intentional. but i did not expect them to actually be different across platforms
  • w

    witty-crayon-22786

    05/22/2017, 6:24 PM
    Copy code
    $ git config --list | grep mode
core.filemode=true
  • w

    witty-crayon-22786

    05/22/2017, 6:24 PM
    so... in theory those mode changes should be tracked as "different" files.
  • s

    straight-waiter-86090

    05/22/2017, 6:26 PM
    I see filemode=true on the Mac, not set on linux.
  • w

    witty-crayon-22786

    05/22/2017, 6:26 PM
    ...aha.
  • w

    witty-crayon-22786

    05/22/2017, 6:26 PM
    ...hm, i have it enabled in both places.
  • w

    witty-crayon-22786

    05/22/2017, 6:27 PM
    alright, regardless... we can't rely on git being "correctly" configured
  • s

    straight-waiter-86090

    05/22/2017, 6:27 PM
    I’m not sure git is used on the build machine though. we use bamboo. I’m not sure if that calls out to git or has its own embedded version.
  • w

    witty-crayon-22786

    05/22/2017, 6:28 PM
    yea, i'm seeing the same thing with pure git and alignment on 
    filemode=True
  • w

    witty-crayon-22786

    05/22/2017, 6:28 PM
    bamboo could be using jgit
  • s

    straight-waiter-86090

    05/22/2017, 6:28 PM
    you said it was intentional to capture the permissions?
  • w

    witty-crayon-22786

    05/22/2017, 6:28 PM
    yes, in the sense that if we can, we would want to.
  • w

    witty-crayon-22786

    05/22/2017, 6:29 PM
    ie, if we capture a binary and it is executable, nuking that would be unfortunate.
  • s

    straight-waiter-86090

    05/22/2017, 6:29 PM
    I can see capturing that part, but not necessarily if it’s writable or group writable.
  • w

    witty-crayon-22786

    05/22/2017, 6:30 PM
    yea.
1...174217431744...2420Latest