https://pantsbuild.org/ logo
Powered by
#general
  • h

    happy-kitchen-89482

    05/18/2017, 4:22 AM
    @gorgeous-alligator-94763 Done!
  • g

    gorgeous-alligator-94763

    05/18/2017, 7:19 AM
    Thank you @happy-kitchen-89482!! I just updated it with the changes. I wasn't sure what you meant exactly by "a function that wraps it" in https://github.com/pantsbuild/pants/pull/4593/files/2d608e2fde346485b9410af14e3855357812e0c2#diff-8603ca893539bade8d782040a56d85b8 because I wasn't sure what "it" was referring to, so if you don't like it, let me know!
  • w

    witty-crayon-22786

    05/18/2017, 5:04 PM
    @straight-waiter-86090 : yi is right... first thing to check is that the relevant options are aligned.
  • s

    straight-waiter-86090

    05/18/2017, 5:06 PM
    to do that I would compare pants.ini on the developer machines vs the ci machines?
  • w

    witty-crayon-22786

    05/18/2017, 5:06 PM
    ./pants options | grep compile.zinc
    is a good place to start
  • w

    witty-crayon-22786

    05/18/2017, 5:06 PM
    pants.ini would work too, but rc files or environment variables also apply
  • w

    witty-crayon-22786

    05/18/2017, 5:06 PM
    so good to get the whole picture from 
    ./pants options
    generally
  • s

    straight-waiter-86090

    05/18/2017, 5:08 PM
    ok. I’ll try.
  • s

    straight-waiter-86090

    05/18/2017, 5:08 PM
    by the way - I had been asking about compile speed. we took the time to get strict_deps working. With that and the latest versions of 1.3.0 our compile speed is much improved.
  • w

    witty-crayon-22786

    05/18/2017, 5:09 PM
    huzzah! and congratulations on strict deps... that has taken us a good long while to get in place
  • s

    straight-waiter-86090

    05/18/2017, 5:11 PM
    I wrote something a little like buildgen, but more specific to our environment. it generates build files based on imports. but with strict_deps, this is usually not all that’s necessary. So, I added a script that tries to compile targets that are failing, parses the output looking for missing dependencies/classfiles, then updates the BUILD file with what’s missing. then repeats until success.
  • s

    straight-waiter-86090

    05/18/2017, 5:11 PM
    brute force, but it actually works really well.
  • w

    witty-crayon-22786

    05/18/2017, 5:14 PM
    yep, excellent. we're currently applying something similar to scala.
  • w

    witty-crayon-22786

    05/18/2017, 7:33 PM
    looks like a lot of network flakiness today... or maybe just bintray. either way, yuck
  • h

    high-advantage-47550

    05/18/2017, 7:55 PM
    does pants 1.3.0 have watching features? or is that 2.x?
  • w

    witty-crayon-22786

    05/18/2017, 8:01 PM
    it does, but as alpha
  • w

    witty-crayon-22786

    05/18/2017, 8:02 PM
  • w

    witty-crayon-22786

    05/18/2017, 8:03 PM
    ...we'll need to draft something more substantial for the final release, but.
  • h

    high-advantage-47550

    05/18/2017, 8:05 PM
    thanks!
  • w

    witty-crayon-22786

    05/18/2017, 8:05 PM
    but yea, the caveat is a big one. you're likely to hit it while switching branches
    👍 1
  • h

    high-advantage-47550

    05/18/2017, 8:08 PM
    super exciting list of features / upgrades though!
    👖 1
  • w

    witty-crayon-22786

    05/18/2017, 10:31 PM
    @happy-kitchen-89482 : i have an integration test for https://github.com/pantsbuild/pants/issues/4590 set up, but passing through the entire environment as 
    pex.run(env=os.environ)
    causes the module that is being invoked to fail to load with 
    ImportError: No module named print_env
  • w

    witty-crayon-22786

    05/18/2017, 10:31 PM
    any brainstorms?
  • w

    witty-crayon-22786

    05/18/2017, 10:31 PM
    (where 
    print_env
    is the name of the module that is being loaded in the pex)
  • w

    witty-crayon-22786

    05/18/2017, 10:33 PM
    hm. maybe the pythonpath...
  • w

    witty-crayon-22786

    05/18/2017, 10:46 PM
    ...argh. 
    os.environ
    != 
    os.environ.copy
    .
  • w

    witty-crayon-22786

    05/18/2017, 10:47 PM
    *shakes fist at cloud / python
  • w

    wide-energy-11069

    05/18/2017, 10:59 PM
    i’ve compared the invocation by py.run and py.run2, and there’s almost no difference, i wonder if there is other ways for py.run to env to the pex compared to py.run2
  • w

    witty-crayon-22786

    05/18/2017, 11:06 PM
  • w

    wide-energy-11069

    05/18/2017, 11:23 PM
1...173917401741...2420Latest