https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    08/14/2015, 10:47 PM
    It looks like this will beat you into master based on the CI queue: https://travis-ci.org/pantsbuild/pants/builds/75679069 - up to you on the release. Its Kosher to edit the CHANGELOG upon rbt patch or else you can just make sure your master branch is set behind that commit
  • w

    witty-crayon-22786

    08/14/2015, 11:01 PM
    @enough-analyst-54434: do you need that in this release?
  • e

    enough-analyst-54434

    08/14/2015, 11:01 PM
    nope
  • w

    witty-crayon-22786

    08/14/2015, 11:01 PM
    kk
  • w

    witty-crayon-22786

    08/14/2015, 11:18 PM
    @enough-analyst-54434: when you say 
    pants_plugin
    isn't exported: should it be?
  • w

    witty-crayon-22786

    08/14/2015, 11:18 PM
    my understanding was that that was a public API
  • w

    witty-crayon-22786

    08/14/2015, 11:19 PM
    we'd certainly like to use it
  • e

    enough-analyst-54434

    08/14/2015, 11:19 PM
    no - its not
  • e

    enough-analyst-54434

    08/14/2015, 11:19 PM
    the public api are the setuptools plugin group id and the entry_point names
  • w

    witty-crayon-22786

    08/14/2015, 11:19 PM
    i mean for consuming an in-repo plugin of our own
  • e

    enough-analyst-54434

    08/14/2015, 11:20 PM
    Those aren't for consuming, they're for publishing and have pantsbuild.pants specific-bits
  • w

    witty-crayon-22786

    08/14/2015, 11:20 PM
    ok
  • e

    enough-analyst-54434

    08/14/2015, 11:20 PM
    I'll be happy though to extract the non-pantsbuild specific bits
  • e

    enough-analyst-54434

    08/14/2015, 11:20 PM
    and put that in backend/python
  • e

    enough-analyst-54434

    08/14/2015, 11:21 PM
    but - to be clear, to publish your own compliant plugin today - its just this bit in your setup_py: https://github.com/pantsbuild/pants/blob/master/pants-plugins/src/python/internal_backend/utilities/register.py#L149
  • w

    witty-crayon-22786

    08/14/2015, 11:21 PM
    seems like a nicer way to have in-repo plugins than the 3 step process
  • w

    witty-crayon-22786

    08/14/2015, 11:21 PM
    not interested in publishing though
  • w

    witty-crayon-22786

    08/14/2015, 11:21 PM
    just running from source.
  • e

    enough-analyst-54434

    08/14/2015, 11:22 PM
    ok - so, to use the setuptools entrypoint plugin infra, the plugin must be packaged
  • e

    enough-analyst-54434

    08/14/2015, 11:22 PM
    the packaing generates metadata files setuptools uses to discover plugins
  • w

    witty-crayon-22786

    08/14/2015, 11:23 PM
    there is a process by which contrib plugins run from source though, right?
  • e

    enough-analyst-54434

    08/14/2015, 11:23 PM
    if the pants backend is loose source in your repo - no need for all that - agreed
  • w

    witty-crayon-22786

    08/14/2015, 11:23 PM
    ok
  • e

    enough-analyst-54434

    08/14/2015, 11:23 PM
    yes - add a [DEFAULT] pythonpath entry and a backend entry
  • e

    enough-analyst-54434

    08/14/2015, 11:23 PM
    vs add 1 plugins requirement entry
  • e

    enough-analyst-54434

    08/14/2015, 11:23 PM
    that is all
  • w

    witty-crayon-22786

    08/14/2015, 11:23 PM
    k
  • e

    enough-analyst-54434

    08/14/2015, 11:24 PM
    the 3rd step in pantsbuild has no bearing on what you'd do
  • e

    enough-analyst-54434

    08/14/2015, 11:24 PM
    that add a bootstrap BUILDfile bit for source roots
  • e

    enough-analyst-54434

    08/14/2015, 11:24 PM
    presumably you develop the local plugin in your pre-existing src/python source root
1...173174175...2420Latest