pantsbuild #general

Channels

welcome

github-notifications

announce

adventurous-art-72916

05/03/2017, 8:50 PM

is the monkeypatch included in the repo @rough-sundown-61224 ?

rough-sundown-61224

05/03/2017, 8:51 PM

Yeah https://github.com/toddgardner/pants-plugins/blob/master/src/python/verst/pants/s3cache/cache_setup.py

rough-dog-96241

05/03/2017, 9:31 PM

Does "topological_order" in a build mean "in reverse dependency order" (e.g., build something that is depended on before the thing that does the depending) ?

rough-dog-96241

05/03/2017, 9:33 PM

(And that order is reflected in the invalidation check invalid_vts list?)

witty-crayon-22786

05/03/2017, 9:34 PM

if you guys feel like getting the s3 plugin in contrib (or just in master, frankly), it would be awesome.

witty-crayon-22786

05/03/2017, 9:35 PM

@rough-dog-96241 : correct... so it's technically a reverse topological ordering

rough-dog-96241

05/03/2017, 9:35 PM

👍

witty-crayon-22786

05/03/2017, 9:35 PM

iirc, it's optional to request the topological sort?

witty-crayon-22786

05/03/2017, 9:36 PM

most tasks do not

witty-crayon-22786

05/03/2017, 9:44 PM

@rough-dog-96241 : yea:

topological_order=False

Task.invalidated

by default

rough-dog-96241

05/03/2017, 10:00 PM

Yeah. Thanks!

rough-sundown-61224

05/03/2017, 10:43 PM

Yeah, I’d love to push s3 cache upstream.

rough-sundown-61224

05/03/2017, 10:47 PM

Would introduce a boto3 dependency if we pushed to master, or we’d have to do a plugin system for remote cache types if we wanted to put it in contrib.

straight-waiter-86090

05/04/2017, 5:47 PM

Hi - how does jvm-platform-validate interact with the cache? I always see it trying to read from cache but always missing 100%. I don’t see any artifacts in .pants.d produced by this task. Our CI machine doesn’t publish anything in its cache for this task (and doesn’t create a directory for it either). should it normally produce artifacts?

witty-crayon-22786

05/04/2017, 7:14 PM

hm... iirc, we disable it

witty-crayon-22786

05/04/2017, 7:15 PM

so, unknown. ping @jolly-chef-92794 ?

jolly-chef-92794

05/04/2017, 7:16 PM

I don't remember x-) I wouldn't be surprised if it never can hit the cache

jolly-chef-92794

05/04/2017, 7:19 PM

@straight-waiter-86090 Looking at the code again, it's not too surprising that the cache misses most of the time

jolly-chef-92794

05/04/2017, 7:19 PM

because it will cache-miss if any of the JVM targets/dependencies in the repo change at all,

jolly-chef-92794

05/04/2017, 7:19 PM

or if the platform changes

jolly-chef-92794

05/04/2017, 7:20 PM

Additionally, if you do have invalid platform dependencies,

jolly-chef-92794

05/04/2017, 7:20 PM

the cache will never be used

jolly-chef-92794

05/04/2017, 7:20 PM

So it should only skip the analysis if almost nothing as changed, and if the state of your repo is entirely valid according to the check.

jolly-chef-92794

05/04/2017, 7:21 PM

But, to your other question, no, it never produces artifacts.

rich-helicopter-79006

05/04/2017, 7:46 PM

Are there any best practices to set up a resources directory?

rich-helicopter-79006

05/04/2017, 7:46 PM

Especially one in which there will be multiple targets?

straight-waiter-86090

05/04/2017, 7:51 PM

@jolly-chef-92794 maybe I’ll try to turn off cache reads from this plugin. or can the plugin itself be disabled? We use only java 8, so I don’t believe there will be any cases of mixed platforms.

jolly-chef-92794

05/04/2017, 7:52 PM

Yeah you can just disable the check.

jolly-chef-92794

05/04/2017, 7:52 PM

Should be a flag for it

witty-crayon-22786

05/04/2017, 8:04 PM

(oh, nvm: we leave it on. i was thinking of right after it was introduced)