pantsbuild #general

Channels

welcome

github-notifications

announce

enough-sundown-78166

04/20/2017, 7:54 PM

thanks a lot. I'll take a crack at it

cool-hairdresser-41102

04/21/2017, 12:17 AM

would anyone point me in the direction of anything that could help me modify https://github.com/thesamet/play-pants for pants 1.3.0?

cool-hairdresser-41102

04/21/2017, 12:18 AM

running with 1.2.x seems to work, so it’s nbd. but don’t want to get left behind on 1.3.x stuff and planning ahead.

cool-hairdresser-41102

04/21/2017, 12:18 AM

the error i’m getting with 1.3.0 is

Exception message: Failed to load the play.register backend: No module named tasks.simple_codegen_task

witty-crayon-22786

04/21/2017, 5:39 AM

simple_codegen_task moved, but should still be accessible (and deprecated) in its old location

witty-crayon-22786

04/21/2017, 5:41 AM

in 1.3.0.dev its new home is

python.pants.task.simple_codegen_task

... but it remains in a deprecated form at

python.pants.backend.codegen.tasks.simple_codegen_task

witty-crayon-22786

04/21/2017, 5:41 AM

ie, https://github.com/pantsbuild/pants/blob/master/src/python/pants/task/simple_codegen_task.py and https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/codegen/tasks/simple_codegen_task.py

witty-crayon-22786

04/21/2017, 5:46 AM

how are you loading the plugin? that code should be accessible at either location, which makes me suspicious.

happy-kitchen-89482

04/21/2017, 5:48 PM

I am release human today. Will start it soon, unless anyone tells me of any outstanding changes they are dying to get in.

enough-sundown-78166

04/21/2017, 6:18 PM

I'm writing a plugin that includes some extra files that get bundled with an artifact to publish, similar to the publish_extras example. I need to know the version number of the artifact, though. Is there a way to access that from within a task?

enough-sundown-78166

04/21/2017, 6:18 PM

perhaps in the product mappings?

enough-analyst-54434

04/21/2017, 6:24 PM

@enough-sundown-78166 afraid not

enough-analyst-54434

04/21/2017, 6:24 PM

You'll need to extract this thing: https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/jvm/tasks/jar_publish.py#L43-L143

enough-analyst-54434

04/21/2017, 6:25 PM

I think and your upstream task producing the extra publish product would need to use that utility (bonus if you split out a read-only core for PushDb) to read the current version for the associated target

enough-analyst-54434

04/21/2017, 6:26 PM

Immediately a problem though since you don't know what version the

publish

goal will bump the current version too! User can send that goal flags to set a custom version vs the default patch bump

cool-hairdresser-41102

04/21/2017, 6:26 PM

@witty-crayon-22786 i’m going to have to do a little digging to answer your questions - is there a good example/reference plugin i can take a look at?

enough-analyst-54434

04/21/2017, 6:30 PM

So @enough-sundown-78166 I think the only way to both add extra products and have those products produceable knowing the to-be-published-version would be to break up the current [extra products] -> [publish] chain into [prepare publish] -> [extra products] -> [publish] , where [prepare publish] takes the flags that set artifact versions numbers / reads the pushdb, and [publish] would just write the pushdb having read the versions to use via a new product that [prepare publish] populates. Obviously a lot of churn and alot of work to do all this.

enough-analyst-54434

04/21/2017, 6:35 PM

The only other avenue I can see is making the concept of (optionally) embedding a resource in published artifacts a first class concept. In that case, the jar publish goal could include advanced configuration options to maybe accept a template and produce a resource using that template along with a way to name the path the resource gets added to the jar with. That might not be totally unreasonable given the precedent, for example, of maven metadata files in jars.

enough-sundown-78166

04/21/2017, 6:59 PM

@enough-analyst-54434 thanks for the reply. That's what I was afraid of....

enough-sundown-78166

04/21/2017, 7:00 PM

I think for the short term, a little copy-pasta isn't the end of the world. Long term, it would be nice to do as you say and have a task that sets the version numbers in the product mappings

fast-megabyte-33579

04/21/2017, 7:33 PM

was there any word of the zinc changes?

fast-megabyte-33579

04/21/2017, 7:33 PM

I'm sorry I didn't get a chance to try to repro my bug

fast-megabyte-33579

04/21/2017, 7:34 PM

(https://github.com/pantsbuild/pants/issues/4477)

witty-crayon-22786

04/21/2017, 10:02 PM

@fast-megabyte-33579 : there is definitely one issue that I'm going to be trying to track down before 1.3.0 stable.

witty-crayon-22786

04/21/2017, 10:03 PM

If we're able to fix it before 1.3.0, we'll likely keep the upgrade in there... otherwise might revert it until after cutting 1.3.0

fast-megabyte-33579

04/21/2017, 10:40 PM

thanks @witty-crayon-22786 - I'm working tomorrow so I'll see what I can do about a repro for my issue

witty-crayon-22786

04/24/2017, 7:14 PM

@rough-minister-58256 : can you take another look at https://github.com/pantsbuild/pants/pull/4134 ?

curved-manchester-66006

04/24/2017, 8:47 PM

Are there compatibility guarantees about the contents of .

cache

? If I copy

.cache

from macOS and pants version

to Linux and pants version

n+q

, is that at worse ignored, and at best a build speedup?

witty-crayon-22786

04/24/2017, 8:48 PM

correct

witty-crayon-22786

04/24/2017, 8:48 PM

if the entry is not compatible, it should have a different key