pantsbuild #general

Channels

welcome

github-notifications

announce

gifted-beard-62952

04/16/2017, 7:11 PM

Prior to that, here's a snippet of the stack trace:

Copy code

File "/home/rakan/myproduct/build/pants-plugins/python/tasks/wheel.py", line 41, in execute
    with self.invalidated(wheels, invalidate_dependents=True) as invalidation_check:
  File "/home/rakan/.pyenv/versions/2.7/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/home/rakan/.cache/pants/setup/bootstrap-Linux-x86_64/1.2.1/lib/python2.7/site-packages/pants/task/task.py", line 381, in invalidated
    self._maybe_create_results_dirs(invalidation_check.all_vts)
  File "/home/rakan/.cache/pants/setup/bootstrap-Linux-x86_64/1.2.1/lib/python2.7/site-packages/pants/task/task.py", line 471, in _maybe_create_results_dirs
    vt.create_results_dir(self.workdir)
  File "/home/rakan/.cache/pants/setup/bootstrap-Linux-x86_64/1.2.1/lib/python2.7/site-packages/pants/invalidation/cache_manager.py", line 202, in create_results_dir
    self.ensure_legal()
  File "/home/rakan/.cache/pants/setup/bootstrap-Linux-x86_64/1.2.1/lib/python2.7/site-packages/pants/invalidation/cache_manager.py", line 129, in ensure_legal
    errors = ''

Exception message:
The results_dirs state should not be manually cleaned or recreated by tasks.

gifted-beard-62952

04/16/2017, 7:12 PM

It's evident from the task that i have not (yet) done anything inside the

invalidated

context manager... so am not sure how my task could have caused this

witty-crayon-22786

04/17/2017, 12:44 AM

moving from binary to compile should be fine, as it will cause your cache keys to change

witty-crayon-22786

04/17/2017, 12:44 AM

if you've changed the code of the task though, might need to bump the http://www.pantsbuild.org/dev_tasks.html#task-implementation-versioning

fast-megabyte-33579

04/17/2017, 2:25 PM

Hi folks, I'm having some errors with pants 1.3.0.dev16

fast-megabyte-33579

04/17/2017, 2:25 PM

Copy code

[error] bad symbolic reference. A signature in package.class refers to type compileTimeOnly
                       [error] in package scala.annotation which is not available.

fast-megabyte-33579

04/17/2017, 2:26 PM

It seems to only happen in

package.scala

files

fast-megabyte-33579

04/17/2017, 2:27 PM

(we're still using scala 2.10)

fast-megabyte-33579

04/17/2017, 2:28 PM

it looks like some new version of scala is escaping somewhere -

Copy code

scala.reflect.internal.Types$TypeError: package macros contains object and package with same name: blackbox

fast-megabyte-33579

04/17/2017, 2:29 PM

I wonder if I need to override the zinc version

fast-megabyte-33579

04/17/2017, 2:29 PM

https://github.com/pantsbuild/pants/pull/4176 looks related

fast-megabyte-33579

04/17/2017, 2:30 PM

but that suggests that I should still be able to compile 2.10 sources

enough-analyst-54434

04/17/2017, 2:56 PM

@fast-megabyte-33579 - Benjy noticed this too, Stu filed.

enough-analyst-54434

04/17/2017, 2:57 PM

Erm, sorry - I'm off, these are different. Nmm.

flat-pizza-44400

04/17/2017, 3:14 PM

Hi folks, I’m trying to bring in both a 3rd party scalac plugin & an internal scalac plugin. Using 1.3.0.dev13. My repo currently just has the internal scalac plugin working fine (the scala_libraries that need it have the scalac_plugin in dependencies & then by plugin name in scalac_plugins). I’ve added the 3rd party jar into ://scalac-plugin-dep and in pants.ini compile.zinc scalac_plugins. With an empty cache/clean-all, I get: compile(dependentLibrary:dependentLibrary) failed: Could not find requested plugins: [u’internalPlugin’] Calling compile again magically solves that (and subsequent compiles work fine w/ no changes to my internal scalac plugin). Any idea what might cause this? Will work on getting a simple repro, but wanted to ask the question here first. Thanks.

flat-pizza-44400

04/17/2017, 5:18 PM

https://github.com/pantsbuild/pants/issues/4475 for full repro of the above scalac plugin issue

witty-crayon-22786

04/17/2017, 5:47 PM

@fast-megabyte-33579 : hm...

2.10

should definitely still be supported. worth filing that one separately if you have a small repro

fast-megabyte-33579

04/17/2017, 7:22 PM

thanks stu - this is our monorepo but I'll give it a go

witty-crayon-22786

04/17/2017, 7:24 PM

going to be looking at whether these issues collectively justify a revert of the zinc upgrade

fast-megabyte-33579

04/17/2017, 7:25 PM

I guess I can try using 1.3.0.dev6 which predates that change afaict

witty-crayon-22786

04/17/2017, 7:25 PM

by a very large amount... the zinc upgrade was recent

fast-megabyte-33579

04/17/2017, 7:25 PM

witty-crayon-22786

04/17/2017, 7:26 PM

https://github.com/pantsbuild/pants/pull/4419

fast-megabyte-33579

04/17/2017, 7:26 PM

oh yes I was looking at http://pantsbuild.github.io/notes-master.html#heading_apichanges_147

witty-crayon-22786

04/17/2017, 7:26 PM

@fast-megabyte-33579 : but a repro would be really, really helpful if you have time. trying to nail stuff down for 1.3.0 stable

fast-megabyte-33579

04/17/2017, 7:27 PM

👍 won't get to it tonight but will spend some time on it tomorrow am

witty-crayon-22786

04/17/2017, 8:32 PM

any objections to

Copy code

--- a/build-support/bin/isort.sh
+++ b/build-support/bin/isort.sh
@@ -33,4 +33,4 @@ do
   esac
 done

-./pants -q --changed-parent=HEAD fmt.isort -- ${isort_args[@]}
+./pants -q --changed-parent=master fmt.isort -- ${isort_args[@]}

witty-crayon-22786

04/17/2017, 8:33 PM

(ie, isort all files changed in a branch, rather than only since the most recent commit)

happy-kitchen-89482

04/17/2017, 8:45 PM

Yeah, makes sense

witty-crayon-22786

04/17/2017, 8:48 PM

lol:

Copy code

return isinstance(target, JvmTarget) and target.has_sources('.scala'),