#general
- a
adventurous-twilight-44110
08/13/2015, 7:35 PMso I think the simplest solution is just to keep the zipfiles on disk... - w
witty-crayon-22786
08/13/2015, 7:35 PM@enough-analyst-54434: er... how else could he fork pants and have it read the target? - e
enough-analyst-54434
08/13/2015, 7:35 PMI'm really confused - w
witty-crayon-22786
08/13/2015, 7:35 PMit's an integration test - w
witty-crayon-22786
08/13/2015, 7:35 PMmake_target is fine for unit tests - e
enough-analyst-54434
08/13/2015, 7:36 PMSo - my proposal is integraion tests use real go_remote_library targets with real github urls - and only those style - e
enough-analyst-54434
08/13/2015, 7:36 PMAnd then unit tests can use make_target and create zips on the fly so its all local - no network - e
enough-analyst-54434
08/13/2015, 7:36 PMis that crazy? - a
adventurous-twilight-44110
08/13/2015, 7:36 PMso the unit tests are already doing that - a
adventurous-twilight-44110
08/13/2015, 7:36 PMbut the integration tests are taking real code on disk and zipping it up before they start - e
enough-analyst-54434
08/13/2015, 7:36 PM... what about the IT half of the proposal then? - w
witty-crayon-22786
08/13/2015, 7:36 PMsure, that's fine... i think that's what we were saying above. - w
witty-crayon-22786
08/13/2015, 7:37 PMre: bintray - e
enough-analyst-54434
08/13/2015, 7:37 PMSo ... what is this for?: contrib/go/examples/3rdparty/go/github.com/gorilla/mux/BUILD - w
witty-crayon-22786
08/13/2015, 7:38 PM@enough-analyst-54434: do we have docs about adding stuff to bintray? - e
enough-analyst-54434
08/13/2015, 7:38 PMwhy can't that target and those like it be used for ITs - w
witty-crayon-22786
08/13/2015, 7:38 PMor an example i guess - a
adventurous-twilight-44110
08/13/2015, 7:38 PMno — contrib/go/examples/3rdparty/go/github.com/fakeuser/rlibX - e
enough-analyst-54434
08/13/2015, 7:38 PMcontrib/go/examples/3rdparty/go/github.com/gorilla/mux/BUILD is a real BUILD file target in the RB - a
adventurous-twilight-44110
08/13/2015, 7:39 PMright, but there’s also five remote libraries defined in contrib/go/examples/test_remote_libs - a
adventurous-twilight-44110
08/13/2015, 7:40 PM^those are the libraries whose BUILD files are causing problems, because they’re zipfiles don’t exist on disk - a
adventurous-twilight-44110
08/13/2015, 7:40 PMtheir* - e
enough-analyst-54434
08/13/2015, 7:40 PMthen don't define them in BUILD files on disk - e
enough-analyst-54434
08/13/2015, 7:40 PMwhy do they need to be there? - w
witty-crayon-22786
08/13/2015, 7:40 PMthey're for integration tests - a
adventurous-twilight-44110
08/13/2015, 7:40 PMright - e
enough-analyst-54434
08/13/2015, 7:40 PMbutbutbut - e
enough-analyst-54434
08/13/2015, 7:40 PMmy point is why? - e
enough-analyst-54434
08/13/2015, 7:40 PMwhy do ITs need to test local zips when the unit does - e
enough-analyst-54434
08/13/2015, 7:41 PMwhy can't they just test remotes?