Yeah, we could update jarjar to exclude module-info.class when it is relocating classes

When ASM encounters a classfile version it can’t handle (53, i.e., Java9, in this case) it throws IllegalArgumentException

We could also change the pants shader to exclude that rule from the shading rules.

And jarjar basically ignores that exception and just keeps going

I suspect when Java 9 is released we'll need to update several things with jarjar

I’m not sure how it comes to rewrite the wrong entries in the constant pool though

That’s clearly a jarjar bug

I saw it rewrite string literals...

Yeah, that feels like a bug. It relocates all references that match '*'

@fast-megabyte-33579 I finally got around to pushing up a branch with JAX-WS wsdl support. I still need to add tests and README but you can take a look at the branch https://github.com/cheister/pants/tree/add-jax-ws-support/contrib/jax_ws Hopefully I'll be able to get a PR for that in the next few days.

This one adds support for JAX-WS but we also have a plugin for Axis2, which is really similar to the JAX-WS. If you need Axis2 let me know and I can add that to the branch.

thanks chris, I think we use axis2 at the moment - I'll check tomorrow

really appreciate you pushing that 🙂

Hmm, trying to run the tests on master on mac in a clean client is giving me a cffi

_PyUnicodeUCS4_AsASCIIString

while doing `tests/python/pants_test/engine/examples:planners`; it looks like pants is definitely going after a wide unicode wheel, and I’m not sure how to convince it to do otherwise. AFAIK I don’t actually have a ucs4 build installed, and debug log indicates it only finds system and brewed python, and I force it to use the brew one. I thought I could force it to use the correct one by downloading it, dropping it in a

wheelhouse

and passing

—python-repos-repos=”+[‘wheelhouse/’]”

but it’s still fetching

cffi-1.7.0-cp27-cp27mu-macosx_10_10_x86_64.whl

which is the wide version.

@witty-crayon-22786 http://event.scaladays.org/scaladays-chicago-2017#!#schedulePopupExtras-8105 looks cool, any projects i can look at related to that talk?

does anyone here use

ensime

with pants?

I knew some people at my old company who did; the default plugin needed to be updated.

Ensime moves pretty fast about it’s file format. I saw there was an issue where one of the ensime guys offered to take over the plugin: https://github.com/pantsbuild/pants/issues/2939

Is there a way to shadow a bit of pants core python in your local monorepo in order to test a change to it? (Perhaps there's a better way?)

If you have a local copy of pants, you can run pants from the sources in that copy. I’m not sure if there’s a good doc on how to do it.

ah, here: http://pantsbuild.github.io/howto_develop.html

👍

and if not

ensime

, what are people using for tooling with pants / scala? “just" intellij?

IntelliJ 🙂

The vimmer that I am, I hate myself for it. But how else am I supposed to know what implicit conversions are active?

@full-kilobyte-93429 all of my zinc problems friday were red herrings, the real issue was OOM 😳

yea, not surprised, did you get the stacktraces?

I am working on getting the newer zinc released hopefully this week

thank you! i wasn’t able to get the stacktraces to show

@witty-crayon-22786 @happy-kitchen-89482 I just left this issue on github, before I threw away my example snippet in subime