https://pantsbuild.org/ logo
Powered by
#general
  • h

    happy-kitchen-89482

    03/21/2017, 10:12 PM
    But I can repro the problem, so I’m looking into it
  • h

    happy-kitchen-89482

    03/21/2017, 10:14 PM
    @clean-fish-15260 
    —pants-config-files=’[”pants-jenkins.ini","pants.ini"]'
    is working for you as expected, right?
  • h

    happy-kitchen-89482

    03/21/2017, 10:19 PM
    Oh, wait, this is working as expected
  • h

    happy-kitchen-89482

    03/21/2017, 10:20 PM
    when you use 
    —pants-config-files='pants-jenkins.ini'
    (or 
    —pants-config-files=’+[”pants-jenkins.ini”]’
    ) it appends to the default, which is the regular 
    pants.ini
  • h

    happy-kitchen-89482

    03/21/2017, 10:20 PM
    So any values in the regular 
    pants.ini
    will take precedence
  • h

    happy-kitchen-89482

    03/21/2017, 10:21 PM
    If you want some other file to take precedence you have to replace the value, not append to it
  • w

    witty-crayon-22786

    03/21/2017, 10:22 PM
    oh, weird. guess it's too late to reverse the order the list is applied in, huh =/
  • h

    happy-kitchen-89482

    03/21/2017, 10:23 PM
    Yeah...
  • h

    happy-kitchen-89482

    03/21/2017, 10:23 PM
    That’s a whole container ship of worms
  • w

    witty-crayon-22786

    03/21/2017, 10:24 PM
    haha
  • p

    purple-oil-45048

    03/22/2017, 1:02 AM
    @witty-crayon-22786 @high-advantage-47550 @clean-fish-15260 thanks guys, learning a lot from you guys about how to use the build cache
  • c

    clean-fish-15260

    03/22/2017, 4:16 AM
    I think the docs just need an update then
  • h

    high-advantage-47550

    03/22/2017, 2:09 PM
    i based our cache setup off of https://docs.google.com/document/d/1_RMg8yvURMmewG-dVwl5Z9cSJfejKokecgCD075J2iI/edit#heading=h.jzlpkido5b1k ("Distributed Artifact Caching in Pants At Square”)
  • r

    rough-minister-58256

    03/22/2017, 5:10 PM
    any objections to trying out the new travis auto-cancellation feature?
  • r

    rough-minister-58256

    03/22/2017, 5:10 PM
    @User uploaded a file:

    Pasted image at 2017-03-22, 10:10 AM▾

  • r

    rough-minister-58256

    03/22/2017, 5:10 PM
    afaict, it will auto-cancel re-pushed PRs to preserve queue space
  • s

    salmon-summer-38098

    03/22/2017, 5:10 PM
    that sounds great!
  • r

    rough-minister-58256

    03/22/2017, 5:10 PM
    sweet! lets try it out.
  • s

    straight-waiter-86090

    03/22/2017, 5:49 PM
    question about pants cache contents - it appears the symlinks are not preserved. is that correct? I’m running into issues with node. It looks like if the content of the directory is stored in cache, then retrieved from cache, all symlinks are replaced with real files. running scripts from 
    node_modules/.bin
    doesn’t work because they’re normally symlinks to files that have relative paths in them.
  • s

    straight-waiter-86090

    03/22/2017, 5:50 PM
    babel is an example of this. 
    node_modules/.bin/babel -> ../babel-cli/bin/babel.js
  • s

    straight-waiter-86090

    03/22/2017, 5:50 PM
    Copy code
    #!/usr/bin/env node

require(”../lib/babel”);
  • s

    straight-waiter-86090

    03/22/2017, 5:50 PM
    this won’t work if the file is not a symlink.
  • w

    witty-crayon-22786

    03/22/2017, 9:29 PM
    @straight-waiter-86090 : that should* have been changed/fixed recently. @brash-cricket-7489 implemented it
  • w

    witty-crayon-22786

    03/22/2017, 9:29 PM
    what version are you using?
  • b

    brash-cricket-7489

    03/22/2017, 9:51 PM
    @straight-waiter-86090 @witty-crayon-22786 This is the PR https://github.com/pantsbuild/pants/pull/3794
  • b

    brash-cricket-7489

    03/22/2017, 9:52 PM
    However, it does not seem to solve all caching issues when turned on for node targets
  • h

    high-advantage-47550

    03/22/2017, 9:57 PM
    is it possible to cache the output of a 
    prep_command
    ? and/or cache some arbitrary generated file? (this sounds difficult to implement so i’m guessing no, but i might as well ask 🙂 )
  • w

    witty-crayon-22786

    03/22/2017, 9:59 PM
    not currently, no. but it's a thing that should be possible with the new engine: https://github.com/pantsbuild/pants/issues/3734
    🎉 1
  • f

    future-baker-79805

    03/23/2017, 1:38 AM
    I wonder if there is anything to do now, or which could be done with future node contrib patches, with regard to npm run scripts which watch local dev files?
  • f

    future-baker-79805

    03/23/2017, 1:42 AM
    (the problem being that they see sources in .pants.d/resolve/node/ABC/foo.bar/XYZ rather than the actual sources …ultimately due to the ‘second fallout’ described at https://rbcommons.com/s/twitter/r/2723/ ?)
1...167316741675...2420Latest