https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    03/21/2017, 9:06 PM
    yea, just passing 
    --pants-config-files='X'
    is equivalent to 
    --pants-config-files='+["X"]'
    ... sorry.
  • c

    clean-fish-15260

    03/21/2017, 9:06 PM
    don't be sorry - I appreciate the help!
  • w

    witty-crayon-22786

    03/21/2017, 9:07 PM
    so, variable interpolation is not aware of there being multiple configs.
  • c

    clean-fish-15260

    03/21/2017, 9:07 PM
    ohhh, and I am using that feature here
  • c

    clean-fish-15260

    03/21/2017, 9:07 PM
    Copy code
    $ cat pants.ini | grep -C3 write
[cache]

read_from: [ "<https://myhost:8080/pants>", "%(homedir)s/pantscache" ]
write_to: [ "%(homedir)s/pantscache" ]
  • w

    witty-crayon-22786

    03/21/2017, 9:07 PM
    recommend trying 
    ./pants --pants-config-files=X options | grep 'relevant.*option'
    until you see what you want.
  • c

    clean-fish-15260

    03/21/2017, 9:08 PM
    Copy code
    $ cat pants-jenkins.ini
[cache]

read_from: [ "<https://myhost:8080/pants>", "%(homedir)s/pantscache" ]
write_to: [ "<https://myhost:8080/pants>", "%(homedir)s/pantscache" ]
  • w

    witty-crayon-22786

    03/21/2017, 9:08 PM
    that should be fine.
  • c

    clean-fish-15260

    03/21/2017, 9:09 PM
    ok I'll try listing both I guess, it seems like the docs are a little off though
  • w

    witty-crayon-22786

    03/21/2017, 9:09 PM
    how so
  • c

    clean-fish-15260

    03/21/2017, 9:10 PM
    well we're using 
    --pants-config-files=somefile.ini
    and the overriding isn't happening
  • w

    witty-crayon-22786

    03/21/2017, 9:11 PM
    according to 
    ./pants options
    ?
  • c

    clean-fish-15260

    03/21/2017, 9:13 PM
    yes
  • w

    witty-crayon-22786

    03/21/2017, 9:13 PM
    hm. yea, definite bug.
  • w

    witty-crayon-22786

    03/21/2017, 9:13 PM
    @clean-fish-15260 : please report that one. but then, recommend using 
    --config-override
    , as i know that that option works.
  • c

    clean-fish-15260

    03/21/2017, 9:14 PM
    roger, and tyvm
  • c

    clean-fish-15260

    03/21/2017, 9:14 PM
    the repro is very simple
  • c

    clean-fish-15260

    03/21/2017, 9:16 PM
    just double checking here...
  • c

    clean-fish-15260

    03/21/2017, 9:16 PM
    Copy code
    jim$ ./pants  --pants-config-files='["pants-jenkins.ini","pants.ini"]' options | grep cache | grep write_to
cache.write_to = ['<https://myhost.com:8080/pants>', '/Users/jim/pantscache'] (from CONFIG)

jim$ ./pants  --pants-config-files='["pants.ini", "pants-jenkins.ini"]' options | grep cache | grep write_to
cache.write_to = ['/Users/jim/pantscache'] (from CONFIG)

jim$ ./pants  --pants-config-files='["pants-jenkins.ini"]' options | grep cache | grep write_to
cache.write_to = ['<https://myhost.com:8080/pants>', '/Users/jim/pantscache'] (from CONFIG)

jim$ ./pants  --pants-config-files='["pants.ini"]' options | grep cache | grep write_to
cache.write_to = ['/Users/jim/pantscache'] (from CONFIG)

jim$ ./pants  --pants-config-files='pants.ini' options | grep cache | grep write_to
cache.write_to = ['/Users/jim/pantscache'] (from CONFIG)

jim$ ./pants  --pants-config-files='pants-jenkins.ini' options | grep cache | grep write_to
cache.write_to = ['/Users/jim/pantscache'] (from CONFIG)
  • w

    witty-crayon-22786

    03/21/2017, 9:17 PM
    ...hm. so the bare flag (ie, without the list) isn't adding to the list.
  • c

    clean-fish-15260

    03/21/2017, 9:17 PM
    doesn't seem like it, not erroring either though
  • w

    witty-crayon-22786

    03/21/2017, 9:17 PM
    that's a more general bug. should ping @happy-kitchen-89482 on it
  • c

    clean-fish-15260

    03/21/2017, 9:17 PM
    I'm on 1.2.0 btw
  • c

    clean-fish-15260

    03/21/2017, 9:32 PM
    peeked in the source and I see
  • c

    clean-fish-15260

    03/21/2017, 9:32 PM
    Copy code
    # TODO: Deprecate --config-override in favor of --pants-config-files.
    # But only once we're able to both append and override list-valued options, as there are
    # use-cases for both here.
  • w

    witty-crayon-22786

    03/21/2017, 9:47 PM
    fyi, i broke master. sorry. will fix with one of the other reviews that is outstanding.
  • h

    happy-kitchen-89482

    03/21/2017, 9:56 PM
    Hmm
  • h

    happy-kitchen-89482

    03/21/2017, 9:57 PM
    --pants-config-files
    is handled specially, since it has to be read before the full options machinery can be started
  • h

    happy-kitchen-89482

    03/21/2017, 9:57 PM
    See 
    get_config_file_paths
    in 
    src/python/pants/option/options_bootstrapper.py
  • h

    happy-kitchen-89482

    03/21/2017, 9:59 PM
    But we use 
    --pants-config-files
    quite a bit in tests, and it seems to work
1...167216731674...2420Latest